Hi Arndt, I wonder why it did not cause more crashes or wrong overview maps. Maybe because style authors don't put many extended type polygons or lines into the overview map. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Arndt Röhrig <arndt@speichenkarte.de> Gesendet: Dienstag, 24. April 2018 18:29:17 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] r4175 & canary-islands dont work Hi Gerd, it works! Thank you for that fast fix. (the word fast is to slow for that fix-tempo :)) Arndt Gerd Petermann hat am 24. April 2018 um 18:14 geschrieben: Hi Arndt, I hope I found the right place to fix this, please try r4176: http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4176 Gerd ________________________________________ Von: mkgmap-dev im Auftrag von Arndt Röhrig Gesendet: Dienstag, 24. April 2018 17:56:57 An: Development list for mkgmap Betreff: [mkgmap-dev] r4175 & canary-islands dont work Hi @all r4175 will not build the canary-islands. r4165 works ok. Other countrys are ok too. After mkgmap build all tiles it crashes. Mayby when it try to build the gmapsupp? mkgmap report this: Exception in thread "main" java.lang.AssertionError at uk.me.parabola.imgfmt.app.trergn.RGNFileReader.readLineCommonExtType(RGNFileReader.java:331) at uk.me.parabola.imgfmt.app.trergn.RGNFileReader.shapesForSubdiv(RGNFileReader.java:248) at uk.me.parabola.imgfmt.app.map.MapReader.shapesForLevel(MapReader.java:155) at uk.me.parabola.mkgmap.combiners.OverviewBuilder.readShapes(OverviewBuilder.java:358) at uk.me.parabola.mkgmap.combiners.OverviewBuilder.readFileIntoOverview(OverviewBuilder.java:267) at uk.me.parabola.mkgmap.combiners.OverviewBuilder.onMapEnd(OverviewBuilder.java:93) at uk.me.parabola.mkgmap.main.Main.endOptions(Main.java:649) at uk.me.parabola.mkgmap.CommandArgsReader.readArgs(CommandArgsReader.java:128) at uk.me.parabola.mkgmap.main.Main.mainStart(Main.java:143) at uk.me.parabola.mkgmap.main.Main.main(Main.java:114) Greets Arndt @gerd My contour-style is new and not so confused :) _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap<mailto:mkgmap-dev@lists.mkgmap>.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Gerd I think this patch fixes an as yet undiscovered problem and won't cause any other problems. Regards Ticker On Wed, 2018-04-25 at 11:27 +0100, Ticker Berkin wrote:

Hi Gerd

Reading and checking the initial getting.patch and your fix yesterday, I've noticed a few lines in the same file that should be changed for clarity and to make them similar to other logic in the same file.

I also noticed a 3 byte signed offset for fetchLabel that has been wrong for a long time.

Patch attached

Regards Ticker _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Gerd I don't have a sample case for the problem, but it might be possible. It looks like the labels for the copyrights are generated after Cities, Roads and POI, so enough of these to get into the 24th bit would make it fail; but something else would probably overflow it's area first. Ticker On Mon, 2018-05-14 at 09:32 +0000, Gerd Petermann wrote:

Hi Ticker,

sorry, I somehow missed this one. I wonder if the offset error in TreFileReader ever caused a problem? Do you have a sample case?

Gerd

________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Montag, 14. Mai 2018 10:54:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] r4175 & canary-islands dont work

Hi Gerd

I think this patch fixes an as yet undiscovered problem and won't cause any other problems.

Regards Ticker

On Wed, 2018-04-25 at 11:27 +0100, Ticker Berkin wrote:

...

Hi Gerd

Reading and checking the initial getting.patch and your fix yesterday, I've noticed a few lines in the same file that should be changed for clarity and to make them similar to other logic in the same file.

I also noticed a 3 byte signed offset for fetchLabel that has been wrong for a long time.

Patch attached

Regards Ticker _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

---

mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev