Hi, as I build my precompiled sea data myself: can we build the PrecompSeaGenerator of mkgmap by default with the binary mkgmap jar? This would allow to use the default mkgmap jar and does not require to always rebuild it at my own. Thanks, Thorsten -- Thorsten Kukuk, Distinguished Engineer, Senior Architect SLES & MicroOS SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)
Hi Thorsten, to be honest, I don't know why it is not done. I see no problem to build mkgmap.jar without the line <exclude name="**/optional/*.java"/> in build.xml. The jar grows by ~ 20 KB, but still works without any of the optional libs when you use it for the normal purposes. Maybe some QA tools would complain? If you think about releasing a jar file that also contains all the optional libs for the PrecompSeaGenerator this would be a bigger change, the libs are > 20 MB and I fear that the old splitter.jar needed for the PrecompSeaGenerator might confuse new users. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Thorsten Kukuk <kukuk@suse.de> Gesendet: Sonntag, 14. Oktober 2018 11:51 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] Build PrecompSeaGenerator by default? Hi, as I build my precompiled sea data myself: can we build the PrecompSeaGenerator of mkgmap by default with the binary mkgmap jar? This would allow to use the default mkgmap jar and does not require to always rebuild it at my own. Thanks, Thorsten -- Thorsten Kukuk, Distinguished Engineer, Senior Architect SLES & MicroOS SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg) _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
On Sun, Oct 14, Gerd Petermann wrote:
Hi Thorsten, to be honest, I don't know why it is not done. I see no problem to build mkgmap.jar without the line <exclude name="**/optional/*.java"/> in build.xml. The jar grows by ~ 20 KB, but still works without any of the optional libs when you use it for the normal purposes. Maybe some QA tools would complain?
The readme.txt says: "The PrecompSeaGenerator is not included in the mkgmap.jar due to additional dependencies." But I don't see it as problem.
If you think about releasing a jar file that also contains all the optional libs for the PrecompSeaGenerator this would be a bigger change, the libs are > 20 MB and I fear that the old splitter.jar needed for the PrecompSeaGenerator might confuse new users.
Do you mean with optional libs the "geotools"? I don't think we need to include them. Whoever is using the SeaGenerator, should have enough knowledge to enhance the searchpath with help of the readme.txt from mkgmap. Thorsten
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Thorsten Kukuk <kukuk@suse.de> Gesendet: Sonntag, 14. Oktober 2018 11:51 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] Build PrecompSeaGenerator by default?
Hi,
as I build my precompiled sea data myself: can we build the PrecompSeaGenerator of mkgmap by default with the binary mkgmap jar? This would allow to use the default mkgmap jar and does not require to always rebuild it at my own.
Thanks, Thorsten -- Thorsten Kukuk, Distinguished Engineer, Senior Architect SLES & MicroOS SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg) _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Thorsten Kukuk, Distinguished Engineer, Senior Architect SLES & MicroOS SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)
@Steve: Do you see any problems with this change? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Thorsten Kukuk <kukuk@suse.de> Gesendet: Montag, 15. Oktober 2018 08:40 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Build PrecompSeaGenerator by default? On Sun, Oct 14, Gerd Petermann wrote:
Hi Thorsten, to be honest, I don't know why it is not done. I see no problem to build mkgmap.jar without the line <exclude name="**/optional/*.java"/> in build.xml. The jar grows by ~ 20 KB, but still works without any of the optional libs when you use it for the normal purposes. Maybe some QA tools would complain?
The readme.txt says: "The PrecompSeaGenerator is not included in the mkgmap.jar due to additional dependencies." But I don't see it as problem.
If you think about releasing a jar file that also contains all the optional libs for the PrecompSeaGenerator this would be a bigger change, the libs are > 20 MB and I fear that the old splitter.jar needed for the PrecompSeaGenerator might confuse new users.
Do you mean with optional libs the "geotools"? I don't think we need to include them. Whoever is using the SeaGenerator, should have enough knowledge to enhance the searchpath with help of the readme.txt from mkgmap. Thorsten
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Thorsten Kukuk <kukuk@suse.de> Gesendet: Sonntag, 14. Oktober 2018 11:51 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] Build PrecompSeaGenerator by default?
Hi,
as I build my precompiled sea data myself: can we build the PrecompSeaGenerator of mkgmap by default with the binary mkgmap jar? This would allow to use the default mkgmap jar and does not require to always rebuild it at my own.
Thanks, Thorsten -- Thorsten Kukuk, Distinguished Engineer, Senior Architect SLES & MicroOS SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg) _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Thorsten Kukuk, Distinguished Engineer, Senior Architect SLES & MicroOS SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg) _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (2)
-
Gerd Petermann -
Thorsten Kukuk