Hi Mike, quite complex code. Did you find the formular in Coord.offset() on your own? If not, please add a comment with the source, I guess it is "Destination point given distance and bearing from start point" at http://www.movable-type.co.uk/scripts/latlong.html which is mentioned at the top commant in Coord.java ? Please add a named constant for 6371000 and a unit test. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <GPetermann_muenchen@hotmail.com> Gesendet: Freitag, 6. Januar 2017 09:20:52 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] copyright and check roundabouts improvements Hi Mike, thanks for the reminder, it seems I forgot it :-( I'll have a look today. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 6. Januar 2017 09:07:04 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] copyright and check roundabouts improvements HI Gerd, have you made any progress on testing the two patches on copyright reader improvements and checking roundabouts that I posted before Christmas (attached)? Cheers, Mike _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Mike, I'd like to understand the problem with the compacted headings first before I commit the patch. I don't know for sure why mkgmap uses 6378137 instead of 6371000. It seems to be the value used in the WGS 84 projection. @Steve: It seems rationale to use the mean value everywhere. What do you think? Gerd Mike Baggaley wrote

HI Gerd, please find attached an updated patch that attributes the source of the new Coord.offset method, moves 6371000 to a constant and adds a unit test.

I note that http://www.movable-type.co.uk/scripts/latlong.html suggests 6371000 as the mean radius of the earth to be used in calculations, but that elsewhere the code uses 6378137 which is the radius at the equator. The difference is only 0.1%, but is there a reason why the existing code uses the equatorial figure?

Cheers, Mike

-----Original Message----- From: Gerd Petermann [mailto:

GPetermann_muenchen@

] Sent: 06 January 2017 09:01 To: Development list for mkgmap <

mkgmap-dev@.org

> Subject: Re: [mkgmap-dev] copyright and check roundabouts improvements

Hi Mike,

quite complex code. Did you find the formular in Coord.offset() on your own? If not, please add a comment with the source, I guess it is "Destination point given distance and bearing from start point" at http://www.movable-type.co.uk/scripts/latlong.html which is mentioned at the top commant in Coord.java ?

Please add a named constant for 6371000 and a unit test.

Gerd

________________________________________ Von: mkgmap-dev <

mkgmap-dev-bounces@.org

> im Auftrag von Gerd Petermann <

GPetermann_muenchen@

> Gesendet: Freitag, 6. Januar 2017 09:20:52 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] copyright and check roundabouts improvements

Hi Mike,

thanks for the reminder, it seems I forgot it :-( I'll have a look today.

Gerd

________________________________________ Von: mkgmap-dev <

mkgmap-dev-bounces@.org

> im Auftrag von Mike Baggaley <

mike@.co

> Gesendet: Freitag, 6. Januar 2017 09:07:04 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] copyright and check roundabouts improvements

HI Gerd, have you made any progress on testing the two patches on copyright reader improvements and checking roundabouts that I posted before Christmas (attached)?

Cheers, Mike _______________________________________________ mkgmap-dev mailing list

mkgmap-dev@.org

http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________ mkgmap-dev mailing list

mkgmap-dev@.org

http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

roundabouts3.patch (16K) <http://gis.19327.n8.nabble.com/attachment/5888836/0/roundabouts3.patch>;

-- View this message in context: http://gis.19327.n8.nabble.com/copyright-and-check-roundabouts-improvements-... Sent from the Mkgmap Development mailing list archive at Nabble.com.

Hi Gerd, I used the two terms to mean slightly different things in the error message - I used road if the way included a highway that would be classed as a road, otherwise I used highway. The check is primarily to determine whether there are multiple roads joining a roundabout, other highways such as paths joining at the same point are of less importance. Hence the use of different terms. Regards, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 09 January 2017 06:23 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] copyright and check roundabouts improvements Hi Mike, I've noticed that the warning messages distinguish between "road" and "highway". This happens since 3693 and I am not sure what the difference is (if there is any). Can you explain? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 6. Januar 2017 16:35:29 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] copyright and check roundabouts improvements HI Gerd, please find attached an updated patch that attributes the source of the new Coord.offset method, moves 6371000 to a constant and adds a unit test. I note that http://www.movable-type.co.uk/scripts/latlong.html suggests 6371000 as the mean radius of the earth to be used in calculations, but that elsewhere the code uses 6378137 which is the radius at the equator. The difference is only 0.1%, but is there a reason why the existing code uses the equatorial figure? Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 06 January 2017 09:01 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] copyright and check roundabouts improvements Hi Mike, quite complex code. Did you find the formular in Coord.offset() on your own? If not, please add a comment with the source, I guess it is "Destination point given distance and bearing from start point" at http://www.movable-type.co.uk/scripts/latlong.html which is mentioned at the top commant in Coord.java ? Please add a named constant for 6371000 and a unit test. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <GPetermann_muenchen@hotmail.com> Gesendet: Freitag, 6. Januar 2017 09:20:52 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] copyright and check roundabouts improvements Hi Mike, thanks for the reminder, it seems I forgot it :-( I'll have a look today. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 6. Januar 2017 09:07:04 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] copyright and check roundabouts improvements HI Gerd, have you made any progress on testing the two patches on copyright reader improvements and checking roundabouts that I posted before Christmas (attached)? Cheers, Mike _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev