Commit r3756: improve MapSplitter: avoid "Too many POIs at location" error message

Version mkgmap-r3756 was committed by gerd on Mon, 16 Jan 2017 improve MapSplitter: avoid "Too many POIs at location" error message http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3756

HI Gerd, since r3756, I am getting an index out of bounds crash in uk.me.parabola.mkgmap.build.MapArea.distPointsEqually() at the line containing extraArea.addPoint(this.points.get(done + j)); There are two loops affecting done and j, but the inner loop doesn't appear to check that done + j is less than points.size(). I could just add a test to the inner loop, but am not sure whether there are any side effects of doing this. Can you take a look? I assume whatever the fix is, it will also need applying to distLinesEqually(). Thanks, Mike -----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk] Sent: 16 January 2017 15:41 To: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Commit r3756: improve MapSplitter: avoid "Too many POIs at location" error message Version mkgmap-r3756 was committed by gerd on Mon, 16 Jan 2017 improve MapSplitter: avoid "Too many POIs at location" error message http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3756

Hi Mike, thanks for reporting. No idea how this bug passed my tests. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 20. Januar 2017 22:31:46 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Commit r3756: improve MapSplitter: avoid "Too many POIs at location" error message HI Gerd, since r3756, I am getting an index out of bounds crash in uk.me.parabola.mkgmap.build.MapArea.distPointsEqually() at the line containing extraArea.addPoint(this.points.get(done + j)); There are two loops affecting done and j, but the inner loop doesn't appear to check that done + j is less than points.size(). I could just add a test to the inner loop, but am not sure whether there are any side effects of doing this. Can you take a look? I assume whatever the fix is, it will also need applying to distLinesEqually(). Thanks, Mike -----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk] Sent: 16 January 2017 15:41 To: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Commit r3756: improve MapSplitter: avoid "Too many POIs at location" error message Version mkgmap-r3756 was committed by gerd on Mon, 16 Jan 2017 improve MapSplitter: avoid "Too many POIs at location" error message http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3756 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

I have tested this codechange with r3766 and it's working fine, all my errors are gone now. Unfortunately the download page suggestes to download r3759 which is not working. Walter -----Ursprüngliche Nachricht----- From: svn commit Sent: Monday, January 16, 2017 4:41 PM To: mkgmap-svn@lists.mkgmap.org.uk ; mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Commit r3756: improve MapSplitter: avoid "Too many POIs at location" error message Version mkgmap-r3756 was committed by gerd on Mon, 16 Jan 2017 improve MapSplitter: avoid "Too many POIs at location" error message http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3756 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Walter, thanks for the feedback. The link is updated now. I am not sure if this is done with a scheduled script or manually, typically it happens over night. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Walter Schlögl <Walter.Schloegl-Resch@aon.at> Gesendet: Samstag, 21. Januar 2017 21:03:41 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Commit r3756: improve MapSplitter: avoid "Too many POIs at location" error message I have tested this codechange with r3766 and it's working fine, all my errors are gone now. Unfortunately the download page suggestes to download r3759 which is not working. Walter -----Ursprüngliche Nachricht----- From: svn commit Sent: Monday, January 16, 2017 4:41 PM To: mkgmap-svn@lists.mkgmap.org.uk ; mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Commit r3756: improve MapSplitter: avoid "Too many POIs at location" error message Version mkgmap-r3756 was committed by gerd on Mon, 16 Jan 2017 improve MapSplitter: avoid "Too many POIs at location" error message http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3756 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (4)
-
Gerd Petermann
-
Mike Baggaley
-
svn commit
-
Walter Schlögl