Hi, I'm attaching proposed patch for aeroways. It corrects following problems: - aeroway is a highway, example http://www.openstreetmap.org/way/23832044 - aeroway=runway is an area, example http://www.openstreetmap.org/way/306366732 Patch also adds support for aeroway=taxilane and aeroway=heliport. -- Best regards, Andrzej
In my OFM style I use the continue statement for rendering highways and is_closed() for detecting areas aeroway=runway & is_closed()!=true [0x10117 resolution 20 continue with_actions] aeroway=taxiway & is_closed()!=true [0x10117 resolution 23 continue with_actions] ________________________________
Hi, continue is a good solution but without TYP aeroway becomes invisible. That's why I decided to drop it. is_closed() looks interesting. Official wiki says, that areaway=taxiway can only be a line but I can see these objects mapped as areas too. With is_closed() condition, some objects can be converted better, for example these: http://www.openstreetmap.org/way/306366739 http://www.openstreetmap.org/way/306366733 -- Best regards, Andrzej
Hi, attached is second version of patch, where function is_closed() is used instead of area=yes. It looks like tag area is most often not used for aeroway objects. -- Best regards, Andrzej
Hi Andrzej, looks good to me. Just a side note: There should be no need to check is_closed()=true in style file polygons since r3081 as mkgmap ignores the polygons rules for ways which are not closed. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Montag, 13. Februar 2017 23:19:40 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] aeroway in default style Hi, attached is second version of patch, where function is_closed() is used instead of area=yes. It looks like tag area is most often not used for aeroway objects. -- Best regards, Andrzej
Hi Gerd, I have removed is_closed() form polygon file and changed resolution of aeroway=heliport to match aeroway=aerodrome. Here attached patch v3. I miss a bit explanation, how mkgmap process objects. It looks reasonable though to forward only closed lines to polygon processing. -- Best regards, Andrzej
Hi Andrzej, I've committed the patch with r3812. I found quite a lot of aeroway=runway in combination with highway=* http://overpass-turbo.eu/s/mNZ Do you see a way to add some overlay line to mark it special without using a TYP file? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Dienstag, 14. Februar 2017 11:43:28 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] aeroway in default style Hi Gerd, I have removed is_closed() form polygon file and changed resolution of aeroway=heliport to match aeroway=aerodrome. Here attached patch v3. I miss a bit explanation, how mkgmap process objects. It looks reasonable though to forward only closed lines to polygon processing. -- Best regards, Andrzej
Hi Gerd, I can't see any easy way to make runway visible over a road, without using a TYP. I treat default style as some kind of reference. An attempt to solve this problem would result in cluttering of the style or use of non-standard objects. Both approach would destroy educational values of style and probably results would be rather mediocre. So I prefer to ignore runway. W can create additional POI for this kind of runway, but I think mappers add a POI anyway, so this could be superfluous. Just a thought: if we get a function like line-to-area, then w could draw a runway below road as an area. I imagine rule like this: aeroway=runway & highway=* & is_closed()!=true { create_area(20m); } This should result in a new polygon created as a strip with 20m width, which then would be processed according to rules in polygon file. -- Best regards, Andrzej
Hi Andrzej, sorry, I somehow missid this post before. I agree in all points. The "create_area" function seems a bit too special as it only makes sense for maps without a TYP file, right? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Samstag, 18. Februar 2017 00:29 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] aeroway in default style Hi Gerd, I can't see any easy way to make runway visible over a road, without using a TYP. I treat default style as some kind of reference. An attempt to solve this problem would result in cluttering of the style or use of non-standard objects. Both approach would destroy educational values of style and probably results would be rather mediocre. So I prefer to ignore runway. W can create additional POI for this kind of runway, but I think mappers add a POI anyway, so this could be superfluous. Just a thought: if we get a function like line-to-area, then w could draw a runway below road as an area. I imagine rule like this: aeroway=runway & highway=* & is_closed()!=true { create_area(20m); } This should result in a new polygon created as a strip with 20m width, which then would be processed according to rules in polygon file. -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, functions like proposed create_area() perform tasks, that I usually would do with a GIS program. Unfortunately processing OSM is not easy like for example SHP. That's why I'd like to put some of these functions into mkgmap. It's not a good solution but could be convenient. create_area() could be usable for maps with or without TYP. I don't suggest to work on it, I only share some ideas. -- Best regards, Andrzej
participants (3)
-
Andrzej Popowski -
Gerd Petermann -
lig fietser