Hi all, I've fixed a major bug in splitter which results in wrong output files when you pass a --split-file which contains overlapping areas. See also http://www.mkgmap.org.uk/websvn/revision.php?repname=splitter&rev=440 Splitter doesn't generate such a file, but one can create such a file in an editor (intended or accidentially) I am not sure what happens when you create a gmapsupp with overlapping tiles, I'd expect problems with routing at the tile boundaries. So, I think splitter should stop when overlaps between tiles with the same mapid prefix are found, e.g. overlapping tiles 63240010 and 63240013 are not allowed, while overlapping tiles 12340001 and 43210001 would be considered okay. I've not yet implemented this test, what do you think about it? Gerd -- View this message in context: http://gis.19327.n8.nabble.com/splitter-r440-released-tp5885986.html Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Gerd, When I first started using Splitter, I experienced this overlapping tiles problem and can confirm that it causes routing problem at tile boundaries. I agree with this test, but I have doubt whether the best solution would be to stop Splitter or simply issue a warning message. In principle, I suggest that the test only generate a warning. Alexandre 2016-11-16 9:31 GMT-02:00 Gerd Petermann <gpetermann_muenchen@hotmail.com>:
Hi all,
I've fixed a major bug in splitter which results in wrong output files when you pass a --split-file which contains overlapping areas. See also http://www.mkgmap.org.uk/websvn/revision.php?repname=splitter&rev=440
Splitter doesn't generate such a file, but one can create such a file in an editor (intended or accidentially)
I am not sure what happens when you create a gmapsupp with overlapping tiles, I'd expect problems with routing at the tile boundaries. So, I think splitter should stop when overlaps between tiles with the same mapid prefix are found, e.g. overlapping tiles 63240010 and 63240013 are not allowed, while overlapping tiles 12340001 and 43210001 would be considered okay. I've not yet implemented this test, what do you think about it?
Gerd
-- View this message in context: http://gis.19327.n8.nabble. com/splitter-r440-released-tp5885986.html Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Alexandre, okay, let's see what the users say about the test in r440. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Alexandre Loss <alexandre.loss@gmail.com> Gesendet: Mittwoch, 16. November 2016 13:19:53 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] splitter r440 released Hi Gerd, When I first started using Splitter, I experienced this overlapping tiles problem and can confirm that it causes routing problem at tile boundaries. I agree with this test, but I have doubt whether the best solution would be to stop Splitter or simply issue a warning message. In principle, I suggest that the test only generate a warning. Alexandre 2016-11-16 9:31 GMT-02:00 Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>: Hi all, I've fixed a major bug in splitter which results in wrong output files when you pass a --split-file which contains overlapping areas. See also http://www.mkgmap.org.uk/websvn/revision.php?repname=splitter&rev=440 Splitter doesn't generate such a file, but one can create such a file in an editor (intended or accidentially) I am not sure what happens when you create a gmapsupp with overlapping tiles, I'd expect problems with routing at the tile boundaries. So, I think splitter should stop when overlaps between tiles with the same mapid prefix are found, e.g. overlapping tiles 63240010 and 63240013 are not allowed, while overlapping tiles 12340001 and 43210001 would be considered okay. I've not yet implemented this test, what do you think about it? Gerd -- View this message in context: http://gis.19327.n8.nabble.com/splitter-r440-released-tp5885986.html Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
On 11/16/2016 12:31 PM, Gerd Petermann wrote:
I've fixed a major bug in splitter which results in wrong output files when you pass a --split-file which contains overlapping areas. See also http://www.mkgmap.org.uk/websvn/revision.php?repname=splitter&rev=440
The lintian QA tool reported a spelling error in the manpage. The attached patch fixes the issue. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Thanks, Bas, committed to r441: http://www.mkgmap.org.uk/websvn/revision.php?repname=splitter&rev=441 Gerd Sebastiaan Couwenberg wrote
On 11/16/2016 12:31 PM, Gerd Petermann wrote:
I've fixed a major bug in splitter which results in wrong output files when you pass a --split-file which contains overlapping areas. See also http://www.mkgmap.org.uk/websvn/revision.php?repname=splitter&rev=440
The lintian QA tool reported a spelling error in the manpage. The attached patch fixes the issue.
Kind Regards,
Bas
-- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
spelling-errors.patch (2K) <http://gis.19327.n8.nabble.com/attachment/5886046/0/spelling-errors.patch>;
-- View this message in context: http://gis.19327.n8.nabble.com/splitter-r440-released-tp5885986p5886048.html Sent from the Mkgmap Development mailing list archive at Nabble.com.
As you know, I'm using overlapping tiles, but in different gmapsupps. Never had any problems. Is splitter still able to split overlapping tiles? Henning
Should have read your mail better :( I think the test should be implemented in mkgmap while reading the input data tiles. Henning
participants (5)
-
Alexandre Loss -
Gerd Petermann -
Gerd Petermann
-
Henning Scholland -
Sebastiaan Couwenberg