Commit: r2578: tweaks to option --check-styles:
Version 2578 was committed by gerd on Fri, 26 Apr 2013 tweaks to option --check-styles: - show style name first, don't show info - print all warnings to stdout (one was printed to stderr by mistake)
Am 26.04.2013 11:14, schrieb svn commit:
- print all warnings to stdout (one was printed to stderr by mistake) Hi Gerd, would it be possible to print out also the osm-way-id?
I get actually some reports, but my style is ok, so I would like to investigate why these reports occur. Henning
Hi Henning, please try r2580 first if you use an overlays file. The problem is detected at a stage were the OSM id is not known. I can try to report details like a name. We can also add the OSM id to all map elements with the cost of 8 additional bytes for each element. Ciao, Gerd Henning Scholland wrote
Am 26.04.2013 11:14, schrieb svn commit:
- print all warnings to stdout (one was printed to stderr by mistake) Hi Gerd, would it be possible to print out also the osm-way-id?
I get actually some reports, but my style is ok, so I would like to investigate why these reports occur.
Henning
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Commit-r2578-tweaks-to-option-check-styles-tp... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Gerd Am 27.04.2013 21:07, schrieb GerdP:
Hi Henning,
please try r2580 first if you use an overlays file. I tried it with r2580 with same result.
SEVERE (MapBuilder): 10000042.o5m: Non-routable way with routable type 0x0e is used for a routable map. This leads to routing errors. Try --check-styles to check the style. SEVERE (MapBuilder): 10000043.o5m: Non-routable way with routable type 0x0b is used for a routable map. This leads to routing errors. Try --check-styles to check the style.
The problem is detected at a stage were the OSM id is not known. I can try to report details like a name. We can also add the OSM id to all map elements with the cost of 8 additional bytes for each element. Ok, if ID is not available, maybe a (rounded) coordinate or BBox should also be enough.
Henning
Hi Henning, what does --check-styles show? Gerd Henning Scholland wrote
Hi Gerd
Am 27.04.2013 21:07, schrieb GerdP:
Hi Henning,
please try r2580 first if you use an overlays file. I tried it with r2580 with same result.
SEVERE (MapBuilder): 10000042.o5m: Non-routable way with routable type 0x0e is used for a routable map. This leads to routing errors. Try --check-styles to check the style. SEVERE (MapBuilder): 10000043.o5m: Non-routable way with routable type 0x0b is used for a routable map. This leads to routing errors. Try --check-styles to check the style.
The problem is detected at a stage were the OSM id is not known. I can try to report details like a name. We can also add the OSM id to all map elements with the cost of 8 additional bytes for each element. Ok, if ID is not available, maybe a (rounded) coordinate or BBox should also be enough.
Henning
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Commit-r2578-tweaks-to-option-check-styles-tp... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Am 28.04.2013 13:24, schrieb GerdP:
Hi Henning,
what does --check-styles show? java -jar -Xmx6000M ./bin/mkgmap.jar --style-file=./resources/style_rrk --check-styles Time started: Sun Apr 28 13:35:21 CEST 2013 Found one style in ./resources/style_rrk finished check-styles Time finished: Sun Apr 28 13:35:22 CEST 2013 Total time taken: 364ms
Hello Henning, that should not happen :-( I've changed mkgmap to print the location of the first point in the warning message. I hope that helps you to tell me what the check-styles function is missing. see http://files.mkgmap.org.uk/download/117/mkgmap.jar Gerd Henning Scholland wrote
Am 28.04.2013 13:24, schrieb GerdP:
Hi Henning,
what does --check-styles show? java -jar -Xmx6000M ./bin/mkgmap.jar --style-file=./resources/style_rrk --check-styles Time started: Sun Apr 28 13:35:21 CEST 2013 Found one style in ./resources/style_rrk finished check-styles Time finished: Sun Apr 28 13:35:22 CEST 2013 Total time taken: 364ms
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Commit-r2578-tweaks-to-option-check-styles-tp... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Gerd SEVERE (MapBuilder): 10000042.o5m: Non-routable way with routable type 0x0e starting at http://www.openstreetmap.org/?mlat=46.15820&mlon=11.94077&zoom=17 is used for a routable map. This leads to routing errors. Try --check-styles to check the style. is caused by way:210139111 and matches to the following rule in my style: highway=path & area!=yes & indoor!=yes { set mkgmap:unpaved=yes } [0x0E road_class=1 road_speed=2 level 3] SEVERE (MapBuilder): 10000043.o5m: Non-routable way with routable type 0x0b starting at http://www.openstreetmap.org/?mlat=46.38067&mlon=12.25267&zoom=17 is used for a routable map. This leads to routing errors. Try --check-styles to check the style. is caused by way:125170744 and matches to the following rule in my style: highway=normal & area!=yes & indoor!=yes [0x0B road_class=1 road_speed=2 level 3] (explanation: highway=track + surface=gravel => highway=normal) It's quite surprising, because in the map of Germany-Alps should be a lot of ways with such tags and there are only these two reports. Maybe you or someone else finds something special with these ways. Just for your information: Both coordinates doesn't match with the start- or endpoint of the osm-way. So a guess could be that mkgmap split the way and something unexpected happens. Henning
Hi Henning,
It's quite surprising, because in the map of Germany-Alps should be a lot of ways with such tags and there are only these two reports. Maybe you or someone else finds something special with these ways.
Well, mkgmap prints only one message for each input file. I'll try to change that so that it prints all messages in the log and just one to stderr.
Just for your information: Both coordinates doesn't match with the start- or endpoint of the osm-way. So a guess could be that mkgmap split the way and something unexpected happens.
Yes, I looked at the sources and for a while and think that the LineSplitterFilter may be "responsible". Unfortunately I was not yet able to reproduce the error. Can you try the attached patch, please? If you see some more error messages I have to find out why these ways are not split in the right way. Are you able to reproduce the problem with a small change in the default style? If yes, please post your changes, the mkgmap options and a link to the input file. Gerd
Hi Gerd, I haven't tested with your patch, but I played a little bit with my style. I reduced lines-style to (highway=path | highway=track) [0x01 road_class=1 road_speed=1 level 3] and some more Tiles are effected. This is ok, because now ways which are unsuitable for bicycle are also used for routing. These are the problems: http://www.openstreetmap.org/?mlat=45.56528&mlon=7.91788&zoom=17 http://www.openstreetmap.org/?mlat=46.15820&mlon=11.94077&zoom=17 http://www.openstreetmap.org/?mlat=46.38067&mlon=12.25267&zoom=17 http://www.openstreetmap.org/?mlat=46.20043&mlon=12.45386&zoom=17 http://www.openstreetmap.org/?mlat=46.32402&mlon=12.40305&zoom=17 http://www.openstreetmap.org/?mlat=46.23219&mlon=12.59995&zoom=17 http://www.openstreetmap.org/?mlat=46.33003&mlon=12.65127&zoom=17 http://www.openstreetmap.org/?mlat=46.59662&mlon=12.69899&zoom=17 http://www.openstreetmap.org/?mlat=47.11006&mlon=11.92188&zoom=17 http://www.openstreetmap.org/?mlat=47.47690&mlon=11.50578&zoom=17 http://www.openstreetmap.org/?mlat=46.40230&mlon=13.11338&zoom=17 http://www.openstreetmap.org/?mlat=46.33106&mlon=13.31131&zoom=17 http://www.openstreetmap.org/?mlat=46.41861&mlon=8.33879&zoom=17 http://www.openstreetmap.org/?mlat=47.30953&mlon=10.08390&zoom=17 http://www.openstreetmap.org/?mlat=46.53088&mlon=10.54722&zoom=17 Henning mkgmap-call: heute=`date +"%Y%m%d"` threads=4 name=Germany-Alps famid=1000 codepage=1252 java -Xmx10000M -XX:+UseCompressedOops -jar ./bin/mkgmap.jar --read-config=./resources/minimal/options --max-jobs=$threads --code-page=$codepage --mapname=$famid"0001" --overview-mapname=$famid"0000" --family-name="RRK $name" --series-name="RRK $name $heute" --description="RadReiseKarte $heute" --family-id=$famid --output-dir=./maps/$name 10000042.o5m 2> mkgmap_error.log options-file: style-file=./resources/minimal draw-priority=24 license-file=./resources/license-mkgmap.txt copyright-message=OpenStreetMap contributors, ODbL. See: http://www.openstreetmap.org/copyright levels=0:24, 1:23, 2:22, 3:21, 4:20, 5:18, 6:16 route tdbfile link-pois-to-ways location-autofill=is_in,nearest index bounds=./resources/bounds.zip ignore-maxspeeds add-pois-to-lines add-pois-to-areas pois-to-areas-placement=entrance=main;entrance=yes;building=entrance product-id=1 preserve-element-order merge-lines remove-short-arcs=2.8 reduce-point-density=4 reduce-point-density-polygon=8 min-size-polygon=8 precomp-sea=./resources/sea generate-sea gmapsupp nsis 10000042.o5m: http://www.aighes.de/data/10000042.o5m
Hi Henning, thanks for the data. The problem is caused by a wrong test in combination with the merge-lines option. The merge-lines option is not used for resolution 24, but for lower ones. My test did only verify if the road is written at res 24, but not if the actual resolution is also 24. So, if I got this right, the messages are wrong and your map should be ok. Working on a fix now. Gerd Henning Scholland wrote
Hi Gerd, I haven't tested with your patch, but I played a little bit with my style.
I reduced lines-style to
(highway=path | highway=track) [0x01 road_class=1 road_speed=1 level 3]
and some more Tiles are effected. This is ok, because now ways which are unsuitable for bicycle are also used for routing.
These are the problems: http://www.openstreetmap.org/?mlat=45.56528&mlon=7.91788&zoom=17 http://www.openstreetmap.org/?mlat=46.15820&mlon=11.94077&zoom=17 http://www.openstreetmap.org/?mlat=46.38067&mlon=12.25267&zoom=17 http://www.openstreetmap.org/?mlat=46.20043&mlon=12.45386&zoom=17 http://www.openstreetmap.org/?mlat=46.32402&mlon=12.40305&zoom=17 http://www.openstreetmap.org/?mlat=46.23219&mlon=12.59995&zoom=17 http://www.openstreetmap.org/?mlat=46.33003&mlon=12.65127&zoom=17 http://www.openstreetmap.org/?mlat=46.59662&mlon=12.69899&zoom=17 http://www.openstreetmap.org/?mlat=47.11006&mlon=11.92188&zoom=17 http://www.openstreetmap.org/?mlat=47.47690&mlon=11.50578&zoom=17 http://www.openstreetmap.org/?mlat=46.40230&mlon=13.11338&zoom=17 http://www.openstreetmap.org/?mlat=46.33106&mlon=13.31131&zoom=17 http://www.openstreetmap.org/?mlat=46.41861&mlon=8.33879&zoom=17 http://www.openstreetmap.org/?mlat=47.30953&mlon=10.08390&zoom=17 http://www.openstreetmap.org/?mlat=46.53088&mlon=10.54722&zoom=17
Henning
mkgmap-call:
heute=`date +"%Y%m%d"` threads=4 name=Germany-Alps famid=1000 codepage=1252
java -Xmx10000M -XX:+UseCompressedOops -jar ./bin/mkgmap.jar --read-config=./resources/minimal/options --max-jobs=$threads --code-page=$codepage --mapname=$famid"0001" --overview-mapname=$famid"0000" --family-name="RRK $name" --series-name="RRK $name $heute" --description="RadReiseKarte $heute" --family-id=$famid --output-dir=./maps/$name 10000042.o5m 2> mkgmap_error.log
options-file:
style-file=./resources/minimal draw-priority=24 license-file=./resources/license-mkgmap.txt copyright-message=OpenStreetMap contributors, ODbL. See: http://www.openstreetmap.org/copyright levels=0:24, 1:23, 2:22, 3:21, 4:20, 5:18, 6:16 route tdbfile link-pois-to-ways location-autofill=is_in,nearest index bounds=./resources/bounds.zip ignore-maxspeeds add-pois-to-lines add-pois-to-areas pois-to-areas-placement=entrance=main;entrance=yes;building=entrance product-id=1 preserve-element-order merge-lines remove-short-arcs=2.8 reduce-point-density=4 reduce-point-density-polygon=8 min-size-polygon=8 precomp-sea=./resources/sea generate-sea gmapsupp nsis
10000042.o5m: http://www.aighes.de/data/10000042.o5m
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Commit-r2578-tweaks-to-option-check-styles-tp... Sent from the Mkgmap Development mailing list archive at Nabble.com.
participants (4)
-
Gerd Petermann -
GerdP
-
Henning Scholland -
svn commit