Hi Mike & Gerd I agree that the existing default partial check is pointless and it is better for the default to be no checking of land in sea / sea in land. With checks enabled, much more thorough checks are done. Re. the wording for the sea options The documentation for --generate-sea says: ... When this option is defined, natural=coastline tags from the input OSM tiles are ignored and the precompiled data is used instead. This option can be combined with the generate-sea options multipolygon, polygons and land-tag. ... If this was changed to something like: ... When this option is defined, natural=coastline tags from the input OSM tiles are ignored and the precompiled data is used to generate the sea. The generate-sea options multipolygon, polygons and land-tag, with associated default values, control how this is done. ... Ticker On Wed, 2021-02-10 at 09:58 +0000, Mike Baggaley wrote:
Hi Gerd,
In my view it does not make sense to make the option only operate on the new checks (land within land) leaving sea within sea always checked. I think that either checks are wanted or they are not, hence the option switches on and off all the checks. It seems overkill to go for - -check=[land|sea].
To me, because the default behaviour statement is on the multipolygon value, not the generate-sea option, the docs indicate that multipolygon is the default when --generate-sea is specified without a value, not that --generate-sea=multipolygon is on by default. If --generate -sea=multipolygon is the default, how is it switched off if sea processing is not needed?
The minor changes look fine to me. Looks like I had got too used to editing style files with its & and | rather than the Java && and ||!
Cheers, Mike
-----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 10 February 2021 08:47 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Fix Sea Patch
Hi Mike,
if I got that right there is no impact on the PrecompSeaGenerator as that doesn't execute this part of SeaGenerator. There is also no impact on processing when --precomp-sea is used. However, now the patched code only performs any check when new parameter --check is given. Is that intended? Ticker suggested to add an option for the additional checks.
The doc says that --generate-sea=multipolygon is the default, this is also true with --precomp-sea. Not sure what is confusing you?
I've made some minor changes to the code to reduce complexity, but didn't check the details of the new code.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Montag, 8. Februar 2021 15:58 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Fix Sea Patch
HI Gerd, I don't have a build that includes the PrecompSeaGenerator, but I would expect the impact to be the same as for in-line sea generation: an increase in execution time if /check is specified with a reduction if it is not specified.
I'm not quite clear what happens if you specify --precomp-sea, but don't specify --generate-sea. The help only says that --precomp-sea can be combined with --generate-sea but doesn't say what happens if you don't. (Does it switch on --generate-sea=multipolygon?)
I think the order of the options in the documentation is not ideal either - I would think --generate-sea should come first, followed by - -coastline-file and that followed by --precomp-sea. Happy to tweak this.
Cheers, Mike
-----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 07 February 2021 17:36 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Fix Sea Patch
Hi Mike and Ticker,
do you expect an impact on the PrecompSeaGenerator?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Sonntag, 7. Februar 2021 18:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Fix Sea Patch
Hi Mike / Gerd
This patch seems fine to me.
Ticker
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev