Hi WanMil, good catch. I'll commit the corrected version tomorrow. Gerd WanMil wrote
Hi Gerd,
at the moment I have no Java environment so I can only comment on the patch without testing my changes.
The tags of the original way need to be copied to the new coastlineWay. After that you have a typo so that you delete the natural tag from the original way instead of coastlineWay. It should look like (on both places):
// add a copy of this way to be able to draw the coastline which is not possible with precompiled sea Way coastlineWay = new Way(FakeIdGenerator.makeFakeId(), way.getPoints()); coastlineWay.copyTags(way); coastlineWay.deleteTag("natural"); coastlineWay.addTag("mkgmap:removed_natural",natural); // tag that this way is used as polygon only coastlineWay.addTag(MultiPolygonRelation.STYLE_FILTER_TAG, MultiPolygonRelation.STYLE_FILTER_POLYGON); saver.addWay(coastlineWay);
Some small nit-picking: All tags added by mkgmap should start with "mkgmap:". So the tag need to be named mkgmap:removed_natural=coastline or mkgmap:removed:natural=coastline or ??.
WanMil
Hi WanMil,
I just want to avoid the situation that Minko had in the first place: A rule that checks for a tag that mkgmap has removed. I think that if we do this, it is a good idea to allow the style to ask for the removed info. Attached is a patch that implements your proposal and changes the natural=coastline tag to removed_natural=coastline.
coastline-v2.patch <http://gis.19327.n5.nabble.com/file/n5796845/coastline-v2.patch>;
Gerd
WanMil wrote
Hi Gerd,
mkgmap:natural=coastline?
For my example I don't see a good reason having that tag. Can you give one where you need this information?
WanMil
Hi WanMil,
I see. Wouldn't it be better to add also a tag so that the style can find out that Seagenerator deleted the natural=coastline tag? If yes, what would be a good tag for this?
Gerd
Date: Wed, 19 Feb 2014 21:00:46 +0100 From:
wmgcnfg@
To:
mkgmap-dev@.org
Subject: Re: [mkgmap-dev] Distorted lines
Hi Gerd,
I think this might cause problems.
In case you want to use polygons tagged with place=island you will lose all islands that are also tagged as natural=coastline. This tagging is described on the wiki page (http://wiki.openstreetmap.org/wiki/Tag:place%3Disland).
I think the patch can be extended in such a way that the coastline way is copied. The copy need to be processed by the polygon rules only and the natural=coastline is removed. This should catch all cases?
Sorry for having a look into the patch late!
WanMil
Hi Minko,
committed with r3064.
Gerd
ligfietser wrote > Gerd, can you commit your coastline patch in the branch version? > > _______________________________________________ > mkgmap-dev mailing list
> mkgmap-dev@.org
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- View this message in context: http://gis.19327.n5.nabble.com/Distorted-lines-tp5775761p5796839.html Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Distorted-lines-tp5775761p5796845.html Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Distorted-lines-tp5775761p5796852.html Sent from the Mkgmap Development mailing list archive at Nabble.com.