Wow, great work! If you filter the types with decreased polygon numbers you get: Residential City Park Large lake Medium lake Major river Forrest I *guess* that in most cases the multipolygon is tagged with name=XXX but not with the polygon tag (natural=* etc.). With patch mp_stricttagrule_v1 these polygons are tagged only with name=XXX but not with a polygon tag and therefore no rule in the style file matches. But the difference (<1%) is not as big as I expected. Maybe it is time to commit the mp_stricttagrule_v1 to squeeze mappers to tag mps correctly. Can you repeat your analysis for parts of europe? WanMil
Hi WanMil,
Here is a spread sheet of the Polygon numbers using the default style with each unique patch version. Patched with Mkgmap r1706.
The numbers are the total of each across all zoom levels.
Also the total number of Polyline and Polyline roads are included.
This is for Austalia. I understand if you need someone to try another part of the world due to different tagging schemes.
Not sure why the Polygons have decreased with the patch that allows all tags. I ran each twice to check. Also I started from a fresh trunk download for each patch.
Regards,
Markus_g
-----Original Message----- From: mkgmap-dev-bounces@lists.mkgmap.org.uk [mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk] On Behalf Of WanMil Sent: Saturday, 25 September 2010 7:18 PM To: Development list for mkgmap Subject: Re: [mkgmap-dev] Trouble getting somemultipolygons torender inmkgmap
Thanks for testing it. Before committing I would like to compare hard facts. How many mps are handled ok with the extended polygon tag list and how many mps are handled with the non polygon tag list.
Unfortunately I don't have time to do this. So anybody should feel free to start investigations.
WanMil
I have tried the patch and have looked around Australia and I can't find any problems. Seems to be a good addition as some multipolygons I have never seen now appear in mapsource.
Charlies missing multipolygons also now appear.
Regards,
Markus_g
-----Original Message----- From: mkgmap-dev-bounces@lists.mkgmap.org.uk [mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk] On Behalf Of WanMil Sent: Saturday, 25 September 2010 2:59 AM To: Development list for mkgmap Subject: Re: [mkgmap-dev] Trouble getting somemultipolygons to render inmkgmap
WanMil schrieb am 24.09.2010 17:35:
The mp code must check if the mp itself contains the relevant polygon tags or if the tagging should be taken from the outer ways. For this purpose a list of known polygon tags is used and up to now leisure is not in this list.
My understanding of the multipolygons is, that the tags may EITHER be in the relation OR on the outer polygons. So the outerpoylgons are only to be used, when there are no tags on the relation. If the relation itself is tagged and there is a tag on the outerpolygons, this does logical mean, that the outerpolygon tags apply to the complete area including the inner-area.
There shouldn't be a list of concerned tags, since any area tags may be used.
I agree. But the real world does not strictly follow this definition. Unfortunately very lots of mps are tagged with some non polygon tags and therefore I introduced the list of well known polygon tags. At least this was neccessary when I implemented the mp code.
You càn check yourself if it's now the time to remove this polygon list. I have attached a patch that follows your proposal. Just test it and let us know.
WanMil
Gruss Torsten
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev