Hi Ticker, please check: I think the areasHashMap should be a field in splitIntoAreas() and it should be empty for each shape. Without this change I see points "moving" when comparing the origial and the split shapes. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <GPetermann_muenchen@hotmail.com> Gesendet: Donnerstag, 12. Januar 2017 10:30:50 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] New code for splitting polygon Hi Ticker, will have a closer look today. I found some cases where the patched version produces different results, not yet sure which is better. I did not find a test case with an unconnected hole. Is the algo prepared for that, too? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Mittwoch, 11. Januar 2017 12:07:55 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] New code for splitting polygon Hi Gerd Here is a unit test for polygon splitting. To go in {trunk}/test/uk/me/parabola/util/ShapeSplitterTest.java Regards Ticker On Sun, 2017-01-08 at 10:30 +0000, Gerd Petermann wrote:
Hi Ticker,
I think you can take the tests in uk.me.parabola.util in mkgmap/test as an example. And sorry, I should already have coded one for clipSinglePathWithSutherlandHodgman().
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Sonntag, 8. Januar 2017 11:20:19 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] New code for splitting polygon
Hi Gerd
Will do. Can you point me to an example of the preferred style for a unit test.
Thanks Ticker
On Sat, 2017-01-07 at 18:14 +0000, Gerd Petermann wrote:
Hi Ticker,
sounds great. Please can you add some unit tests to show what it does with holes, points on the split line and one or more line segments on the split line?
Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Samstag, 7. Januar 2017 18:36:31 An: mkgmap development Betreff: [mkgmap-dev] New code for splitting polygon
Hi Gerd
I've written some new code for splitting polygons in an efficient manner. The main interface takes a shape and line of latitude or longitude and returns 2 lists of shapes on either side of the line. There is also a function to clip to rectangle.
I've put the code in util/ShapeSplitter but it could go elsewhere if you prefer.
So far I've only converted build/MapArea to use it, but I think it can be used throughout eventually. For the moment I've commented out the old code in MapArea, but this can be deleted in a while.
Regards Ticker _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev