Hi Gerd I had tried it on some in-between version that I think had equivalent logic to the patch and it didn't get overridden. Doesn't the final (or only) lineAdder set it unconditionally for oneway roads? If I've misread it I'll build and test. Ticker On Tue, 2021-05-18 at 14:01 +0000, Gerd Petermann wrote:
Hi Ticker,
I don't see that oneway forces direction flag when the tag mkgmap:has -direction=no is set in the branch. Did you try it?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Dienstag, 18. Mai 2021 15:53 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Line direction flag, merging etc
Hi Gerd
The code in low-res-opt looks like ignore-oneway-for-lines.patch. The disadvantage of this, as I see it, is that has-direction can't be forced false for one-way roads.
I think my version is clearer.
Considering substitute lines from /overlays:
I had intended that they all (first and duplicates) have the same has -direction value as the original.
An alternative is that the first has the original has-direction value and the duplicate set has-direction solely from lineTypesWithDirection.
I don't know which is better.
Ticker
On Tue, 2021-05-18 at 12:35 +0000, Gerd Petermann wrote:
Hi Ticker,
in the branch I found a solution which doesn't set the direction flag for overlay lines when the OSM way is a oneway and a road with overlay type is created. With your patch still ALL lines created from the overlay type have the direction flag set in that case. Tested this with the unchanged OFM style without any new options.
Do you see something wrong in the current branch version r4723? I think it's clearer.
Gerd
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev