Hi Gerd,
Hi WanMil,
thanks, and I like all your changes. Just one small point: You kept this comment: "The outline of the polygon is has clockwise order whereas ... " which I wanted to change to "The outline of the polygon has clockwise order whereas ... "
Was that intended?
No. I just removed the lines between the old areaToShapes method and the new verifyXXX method so this change was removed by mistake. WanMil
Gerd
Date: Sun, 12 Feb 2012 21:44:24 +0100 From: wmgcnfg@web.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [PATCH] Again NullPointerException
Sounds reasonable.
I have comitted the patch with some small changes: * Removed unused variables * Added/changed some comments for (my) better understanding * Reduced the depth of if clauses for better reading * Removed the duplicate check for the float values. It is not necessary and works only in very few cases. Interestingly there were lots of cases where the printed floats were equal but the check did not remove them. In the end it does not make a difference in the cw/ccw calculation. (The check for the int values is still there.)
WanMil
Hi Thorsten,
well, I think that difference is okay. The patch itself doesn't change the number of bytes that are written, but it changes the meaning. The data is read again by the BoundaryPreparer.workoutBoundaryRelations() method which interprets the data. A boundary that is counterclockwise is considered to be a hole in an outer area. Since the patch corrects a few missinterpretations, the workoutBoundaryRelations() will probably produce different results when it tries to find areas that lie within other areas.
Gerd
Thorsten Kukuk wrote
Hi Gerd,
On Sat, Feb 11, Gerd Petermann wrote:
Hi Thorsten,
okay, so you have to wait until someone with a big machine tries
it. I
may be able to download planet data, but I cannot run mkgmap on a file containing planet boundaries. My machine has max. ~3GB java heap available, that was just enough for europe boundary data.
I tried it now with my DACH extract. The differences are only small (two files) and this time the unpatched version is bigger than the one with your patch:
-bounds_2200000_400000.bnd 2294004 +bounds_2200000_400000.bnd 2293956 -bounds_2350000_600000.bnd 1817189 +bounds_2350000_600000.bnd 1816893
All other 82 files have the same size.
Thorsten -- Thorsten Kukuk, Project Manager/Release Manager SLES SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) _______________________________________________ mkgmap-dev mailing list mkgmap-dev@.org http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- View this message in context: http://gis.19327.n5.nabble.com/PATCH-Again-NullPointerException-tp5471749p54... Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev