Hi Mike,


as a cyclist I wonder why you treat cars that special. From the previous post I thought that we

may ignore pedestrian-only ways. 

Besides that some style authors use "car routing" to distinguish between racing bikes and

normal bikes. Not sure if that can cause problems here. 

I am unsure if we want to flag ways which are wrong reg. OSM rules or if we try to find

roundabouts were the Garmin algo will produce false exit hints.


Gerd

Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk>
Gesendet: Donnerstag, 4. August 2016 23:40:38
An: mkgmap-dev@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] [Patch v2] improve roundabout checks
 

HI Gerd, that looks like a good start. The attached patch improves on it slightly by ignoring highways that do not have access for cars.

 

Regards,

Mike

 

 

 

From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com]
Sent: 03 August 2016 14:40
To: mkgmap-dev@lists.mkgmap.org.uk
Subject: [mkgmap-dev] [Patch v1] improve roundabout checks

 

Hi all,

 

attached is a patch for the roundabout checks. It adds a test that will warn when

a node on a roundabout is connected to more than one routable way

(ways which are not accessable are not counted, e.g. highway=construction with the default style)

The check is only performed when option

--check-roundabouts is used, you have  to enable logging to see the result.
The check is implemented in class RouteNode, so a config line in logging.properties might be

uk.me.parabola.imgfmt.app.net.RouteNode.level=WARN

 

A binary based on r3688 is here:

http://files.mkgmap.org.uk/download/306/mkgmap.jar

 

Note that this check is very basic, it doesn't ignore when the road is going straight through the roundabout

or when it builds a tagent. If you think that this produces too many false warning I may add

code for this. 

 

Gerd