4 Mar
2011
4 Mar
'11
3:09 p.m.
On Fri, Mar 4, 2011 at 8:48 AM, Torsten Leistikow <de_muur@gmx.de> wrote:
What is the desired approach on the indentation when a patch has such a structure change like removing an if-bracketing?
Changing indentation when removing a nesting level is fine, but it should be confined to the area where the nesting was removed.
In my change I also "corrected" the indentation of otherwise unchanged lines. Shouldn't such changes be included in the patch? If they are not included, how is the indentation then "corrected"?
Whitespace-only changes should be included in a separate patch that does not change any functionality. That makes it easier to review changes. -- Jeff Ollie