Hi Gerd The crash in Carlos's original problem is due to the inconsistency in the dedups between Mdr5/Mdr25. This could be triggered with any --code-page where city names contain characters that exist in this character-set but are not given sort positions. My mistake with mdrUnicode_v1/2.patch was trying to tackle the case problem at the same time. This is going to be much more difficult. Ticker On Fri, 2021-11-05 at 11:00 +0000, Gerd Petermann wrote:
Hi Ticker,
sorry for my reluctance. I simply have no test case that shows an error (search for xyz not working). If you have one please share it so that I can understand the importance of the patch.
I would also be happy if you could create a new branch to test further changes reg. --lower-case. According to MdrCheck we also produce wrong data for mdr 27 (cities are not de-duped). Found this also with Arndts *.img data but did not yet try to find out if MdrCheck is right.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Freitag, 5. November 2021 11:34 An: mkgmap-dev@lists.mkgmap.org.uk; mkgmap-svn@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] [mkgmap-svn] Commit r4811: fix java.lang.AssertionError while building index from unicode tiles
Hi Gerd
I really don't like the idea of the consistent dedup part of this patch not being applied (Mdr5 & Mdr25). The Mdr7 changes are a slight refactor and a useful comment, but has no logical effect. The Mdr29 changes are an assert to detect inconsistency in Mdr5/25 index pointer lengths before these could cause a crash + .equal()/collator.compare() change that could be removed
Ticker
On Fri, 2021-11-05 at 09:02 +0000, svn commit wrote:
Version mkgmap-r4811 was committed by gerd on Fri, 05 Nov 2021
fix java.lang.AssertionError while building index from unicode tiles Changes extracted from mdrUnicode_v8.patch by Ticker Berkin
http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4811 _______________________________________________ mkgmap-svn mailing list To unsubscribe send an mail to mkgmap-svn-leave@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-svn
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev