Hi Mike/all, some remarks: - the field RoundaboutCheck.checkRoundaboutDirections is never read. I also see no easy way to move that check from StyledConverter to RoundaboutCheck. - it's a bit unclear what the program will do when a mix of new and old options is used. - Looking at the docs I've no clue what --roundabout-flare-rules-config=filename is about. This looks like total overkill to me as I have no clue why mkgmap should care about the geometry of flare roads in the first place. What kind of problem should be detected by those tests and what are those rules about? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Samstag, 22. Mai 2021 10:49 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] logging improvement Hi Gerd, Please find attached a version that functions that way. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 21 May 2021 18:37 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] logging improvement Hi Mike, I want that --check-roundabouts doesn't produce any messages in the console when no logging.properties are used, just reverses wrong roundabouts. That's what happened before the logging changes, right? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 21. Mai 2021 19:25 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] logging improvement Hi Gerd, Do you mean that --check-roundabouts (and --check-roundabout-flares) should not switch on any checks? If so, I think it would be best to change the wording from deprecated to obsolete in the messages and documentation, to indicate you won't get any checks. Another way would be to make those options stop execution, thus forcing users to choose whatever new option they want. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 21 May 2021 13:56 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] logging improvement Hi Mike, I meant to only set fixRoundaboutDirections to true when --check-roundabouts is used. My understanding is that only few users care about the messages from the checks, they just enabled the option in the hope for better results in the map. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 21. Mai 2021 14:12 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] logging improvement HI Gerd, Happy to set --fix-roundabout-direction on if --check-roundabouts is set - see attached updated patch. The reversing it message is only shown when fixRoundaboutDirections is set to true. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 20 May 2021 14:07 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] logging improvement Hi Mike, sorry, that slipped my mind. I've not tried it yet but I think the deprecated --check-roundabouts option should be interpreted as --fix-roundabout-direction so that the IMG file is the same as before. The message "... reversing it " is logged when --check-roundabouts is used but the way is not reversed? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Donnerstag, 20. Mai 2021 13:13 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] logging improvement Hi Gerd, I have already sent you the roundabout checks patch which covers both of the requests. It may have got missed as I know you are heavily involved in other issues at the moment. I've attached a copy. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 20 May 2021 10:20 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] logging improvement Hi Mike, I've hoped for a patch reg. the messages about roundabouts for users without a logging.config. I think we need a way to enable the functionality of reversing roundabouts (done in StyledConverter) without also getting all the check messages from RoadNetwork. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Mittwoch, 19. Mai 2021 12:18 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] logging improvement Hi Gerd, Please find attached the updated patch. In most cases where ways are duplicated, the duplicate ways are given a faked id. However, there are 3 places in StyledConverter where the id is copied rather than using a faked id - in addRoad, splitWayAt and makeCycleWay. I am unsure as to whether this is intentional or an oversight, so have left the id as it is currently (I have had to introduce new Way copy constructors to handle this). If these should also use a faked id, I can update the patch. I have followed your suggestion of amending the similar arcs code to get rid of duplicated ways, and using my style file have reduced the number of similar arcs warnings from about 21000 to about 600 which also results in a reduction in size of the gmapsupp file. I will be posting this patch shortly. Cheers, Mike -----Original Message----- From: Mike Baggaley [mailto:mike@tvage.co.uk] Sent: 16 May 2021 08:48 To: 'Development list for mkgmap' <mkgmap-dev@lists.mkgmap.org.uk> Subject: RE: [mkgmap-dev] logging improvement Hi Gerd, There are lots of pedestrian areas that are relations. Some of these overlap with adjacent pedestrian areas and produce a warning like: Similar arcs (generated way) and (generated way) found at http://www.openstreetmap.org/?mlat=50.728438&mlon=-1.143728&zoom=17 However, don't commit it yet - I have realised that although this fixes most of the messages, there are some still being displayed as generated way, presumably because the relation is copied prior to being used. I'm looking at this now. The above example after the patch displays: Similar arcs (generated way) and (http://www.openstreetmap.org/relation/9381074) found at http://www.openstreetmap.org/?mlat=50.728438&mlon=-1.143728&zoom=17 Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 16 May 2021 07:32 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] logging improvement Hi Mike, please help me: In what situation do we create roads from ways which were created from relations? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Samstag, 15. Mai 2021 14:31 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] logging improvement Hi Gerd, Please find attached a small patch that changes the logging of RoadDef when the original element is a relation. Currently it just says "generated way"; with the patch it gives the URL of the relation in the same way as it does for ways. Cheers, Mike _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev