Hi Gerd I was thinking that that either mdr20SortPos or mdr20Index could go, probably also int[] mdr20Index/setMdr20set() - I'd have kept mdr20SortPos I've updated the same machine (4 core but only have 3G memory) to a 64- bit OS and Java 11, but generally the performance is worse. The 21 seconds for either version of calcMdrSortPos() is doing all 232 tiles of NRW+. Ticker On Tue, 2021-11-02 at 08:39 +0000, Gerd Petermann wrote:
Hi Ticker,
here's the new version. No idea what I tested before. I don't see any significant performance improvement (calcMdr20SortPos() only takes a fraction of a second with nrw++ data) but I think the code is much clearer. Maybe you already hit memory limits on your 32-bit JRE?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Montag, 1. November 2021 11:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] [mkgmap-svn] Commit r4810: revert changes from r4809 for now, they caused more trouble
Hi Gerd
Looking at what Mdr5::calcMdr20SortPos() is doing, can't it be simplified away to just an extra call in genCitiesAndMdr20s():
... around line 106 if (!c.isSameByName(collator, lastCity)) mdr20count++; c.setMdr20Index(mdr20count); add this: c.setMdr20SortPos(mdr20count);
Ticker
On Sat, 2021-10-30 at 09:16 +0000, Gerd Petermann wrote:
Hi Ticker,
attached is a patch that simplifies calcMdr20SortPos(), no change in output intended. Does it help?
Gerd
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev