Hi all, I hope r4605 fixes this problem without introducing new ones. Reg. the roads in different suburbs of Melbourne: Turned out I was confused by messages like this found additional addr:interpolation way with same meaning, is ignored: Arnold Street http://www.openstreetmap.org/way/154652891 2..2, step=2 http://www.openstreetmap.org/way/154652891 2..2, step=2 I did not notice that the message refers to the same OSM way. The addr:interpolation=even way 154652891 https://www.openstreetmap.org/way/154652891 is a bit weird. It connects three address nodes with numbers 2, 2B and 2B. The program splits the way into different parts for each pair of numbers and of course this produces duplicate intervals. I could add code to produce a better message for this case, esp. as it is not clear which part is ignored, but in the end it's a garbage in -> garbage out case and probable the code in mkgmap will not cause trouble. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Montag, 1. März 2021 16:50 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] internal error: found no housenumber road Hi all, I made some progress here reg. the internal error. I think the attached patch is a good approach to avoid those problems without introducing too many unwanted changes. I've noticed another special case in the Melbourne area. They often have roads of the same name in different suburbs of the city, this causes another plausibility check to drop some of the addr:interpolation ways by mistake as it is not aware of suburbs. Have to think about that .... Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Samstag, 27. Februar 2021 21:52 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] internal error: found no housenumber road Hi Joris, reg. house numbers on footway: If you don't want them you can add a rule like this highway=footway {add mkgmap:numbers=false} Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Joris Bo <jorisbo@hotmail.com> Gesendet: Samstag, 27. Februar 2021 16:01 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] internal error: found no housenumber road Hi Gerd, If I understand correctly... For me searching the roadname really matching the addr:streetname would make the most sense even if it is not the closest way. The closest way could be divided from the address by a 'river' or 'fence/hedge/barrier' anyway? As far as i understand it only happens in odd situations. So using the first highway segment that matches the name is a solution to me. Kind regards Joris Met vriendelijke groeten, Joris Bo jorisbo@hotmail.com -----Oorspronkelijk bericht----- Van: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> Namens Gerd Petermann Verzonden: zaterdag 27 februari 2021 10:44 Aan: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Onderwerp: Re: [mkgmap-dev] internal error: found no housenumber road Hi all, I've uploaded a file with the problematic area: http://files.mkgmap.org.uk/detail/501 I see no obvious error in the housenumber data, all looks plausible, only some building=yes tags on nodes are probably wrong, but that isn't a problem here. I really wonder what result I want to get from this data. There are two addr:interpolation=odd ways along the footway https://www.openstreetmap.org/way/775843679, so I think mkgmap should produce data so that the address for e.g. the node https://www.openstreetmap.org/node/1025525702 addr:housenumber=477 addr:street=Royal Parade is found on that footway, as well as the interpolated numbers 459 ... 477 and many more numbers which belong to "Royal Parade", even though the footway has no name and is not connected to "Royal Parade" but to "Ievers Street". The alternative would be to use https://www.openstreetmap.org/way/573320541 as it has the right name, but it is not as close. All the other highways named "Royal Parade" should be dismissed (which isn't easy to compute) because way 573320541 is also split into fragments because of the --link-pois-to-ways processing. So, as so often with house numbers we have a lot of correct information and the heuristic in mkgmap should find out that footway belongs to "Royal Parade", but that doesn't work. The "internal error" is produced because node 1025525702 appears in two addr:interpolation intervals. The program tries to find a single road to use for the interpolation and that goes wrong here. The details are too complex to explain here. In short the data is "corrected" too often. The failing code exists to avoid cases were a single, obviously wrong addr:interpolation way would generate lots of wrong address nodes. IIRC I added it to detect nonsense in the imports of Canvec data (Canada). I have to find out if this code is still needed and if yes, how to improve the heuristic to avoid the internal error. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Freitag, 26. Februar 2021 20:11 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] internal error: found no housenumber road Hi Carlos, yes, it requires the footway, probably also other roads and a special order in the addr:interpolation way and maybe more. I found a possible fix but I need more time to understand in what case this will cause problems. The map is usable, a few house numbers may not be found. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Carlos Dávila <carlos@alternativaslibres.org> Gesendet: Freitag, 26. Februar 2021 20:06 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] internal error: found no housenumber road Thanks for investigating it. I've been using those two rules for several years, it's strange the problem didn't arise till now. El 26/2/21 a las 15:36, Gerd Petermann escribió:
Hi Carlos,
I didn't find a fix for the problem so far. I see what's going wrong but not why it only happens in this special situation. Your points file contains these two rules: highway=traffic_signals { add mkgmap:road-speed = '-1'; add mkgmap:road-speed-min = '1' } highway=crossing { add mkgmap:road-speed = '-1'; add mkgmap:road-speed-min = '1' }
When I copy them to the default style I see the same error. Because of the extra rules and --link-poi-to-ways the OSM way 573320541 is split into smaller parts and somehow mkgmap fails to find the right part for the numbers generated by the addr:interpolation way.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Freitag, 26. Februar 2021 08:00 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] internal error: found no housenumber road
Hi Carlos,
OK, I can now reproduce with java -Xmx4G -ea -jar d:\mkgmap\dist\mkgmap.jar --route --housenumbers --link-pois-to-ways --style-option=language=non_latin --style-file=..\mio 51690125.o5m
Also with a smaller extract. It seems your style in combination with --link-pois-to-ways triggers this...
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Carlos Dávila <carlos@alternativaslibres.org> Gesendet: Donnerstag, 25. Februar 2021 23:06 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] internal error: found no housenumber road
Removing --road-name-config didn't fix the problem. Error can be reproduced with command:
java -Xmx27G -ea -jar mkgmap.jar -c opciones_comunes -c opciones_teselas --latin1 --family-id=51169 --overview-mapname=OCE1169 --overview-mapnumber=51169000 --name-tag-list=int_name,name:en,name --report-similar-arcs --report-dead-ends=2 --drive-on=detect,right --check-roundabouts --check-roundabout-flares --license-file=license_OSM --copyright-file=copyright --style-option=language=non_latin --style=mio 51690125.o5m
You can get all (I hope) needed files at https://alternativaslibres.org/tmp/no_housenumber.zip
El 25/2/21 a las 22:34, Carlos Dávila escribió:
According to your comment, I think it may be caused by the line below passed by --road-name-config parameter. Testing now...
suffix:en = " Avenue", " Close", " Court", " Crescent", " Drive", " Gate", " Grove", " Lane", " Mews", " Parade", " Place", " Road", " Square", " Street", " Terrace", " View", " Way"
El 25/2/21 a las 20:53, Gerd Petermann escribió:
Hi Carlos,
I cannot reproduce this with the default style. The error message means that mkgmap found a matching road at some time and later it didn't. This should not happen, but maybe it depends on the style or other options. I downloaded the small area and tried with java -jar dist\mkgmap.jar --bounds=bounds.zip --route --housenumbers --index d:\OSM\addr-inter.osm
Please let me know how to reproduce.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Carlos Dávila <carlos@alternativaslibres.org> Gesendet: Donnerstag, 25. Februar 2021 20:33 An: Development list for mkgmap Betreff: [mkgmap-dev] internal error: found no housenumber road
While processing Australia I get several warnings of the form:
SEVERE (HousenumberGenerator): 51690125.o5m: internal error: found no housenumber road for interpolated house http://www.openstreetmap.org/?mlat=-37.782001&mlon=144.959382&zoom=1 7
Looking at that area in JOSM, I see addr:interpolation lines next to a footway without a name, connecting houses with addr:street=Royal Parede, and a primary road named Royal Parede some 20 m away from the addr:interpolation lines. I guess mkgmap searches for street name in the footway (which doesn't have a name) instead of in the Royal Parade road, and thus it fails to assign housenumbers.
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev