Hi Steve, yes, problem is that HousenumberGenerator only sets style to NONE when no numbers are found for a part of the road. Reg. your patch: fine for me as don't yet understand that part of the img file structure ;-) Gerd Date: Wed, 22 Apr 2015 10:55:36 +0100 From: steve@parabola.me.uk To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] error in NumberPreparer? On 22/04/15 08:11, Gerd Petermann wrote:
Besides that the img file with defaults -1 is a bit smaller, so I think we should change that in trunk (with the attached patch)
OK that would be safer. I guess that no test showed up the problem because both the Polish format and the tests make everything initialized with -1, whereas I guess that the HousenumberGenerator did not. I think I will add a check to NetCheck for negative or zero house numbers when read in, since they cannot be correct. I would also like to add the following patch to the number preparer to prevent any invalid number being used as a target in the equalizeBases() method. ..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev