Hi Gerd The only common bit is filling in the mode hierarchy. It could be moved into an include and shared, but it is only 15 lines. Ticker On Mon, 2020-04-13 at 11:31 +0000, Gerd Petermann wrote:
Hi Ticker,
did not check the details yet but the patch seems to duplicate a lot of stuff coded in inc/access. Is that needed?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Montag, 13. April 2020 13:21 An: mkgmap development Betreff: [mkgmap-dev] POI barrier/access restriction
Hi Gerd and others interested in routing issues
default style "points" has code that, when option --link-pois-to-ways is in effect, sets highway access and speed restrictions that mkgmap then imposes on the highway that the point is on.
These rules had various errors: - didn't expand the access mode hierarchy, see https://wiki.openstreetmap.org/wiki/Key:access - tested the wrong tag for mkgmap:bus and mkgmap:delivery - if the "access" tag was set, apply this to all modes before processing allowances and restrictions imposed by the barrier; but these actions would have no effect because the the specified mode tags are now all set - assumed that a gate stops motor_vehicle access - didn't handle other common forms of gate - allowed bicycle through kissing_gate and stile
This patch fixes these problems and also adds a speed restriction for all barriers.
The general principle is that barrier rules add specific "no" restrictions that the barrier prevents, but must not add "yes". The "access" tag is a default for all modes not implicitly or explicit handled; there could be, say, osm tags [barrier=stile, access=destination] and this should not imply there is unrestricted foot access.
Ticker _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev