Hi Steve, looks good for me, although you may simplify the code in isIndexable(): a) The expression ((ValueOp) op.getFirst()).isIndexable() appears three times b) the term (op.getSecond().isType(VALUE) || op.getSecond().isType(FUNCTION) appears two times and I wonder why it is needed. Do you have an example? The unit tests don't fail when I remove it. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve@parabola.me.uk> Gesendet: Donnerstag, 22. März 2018 12:26:05 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Error in my style with Version mkgmap-r4136 Hi
Who can help me. Since Version mkgmap-r4136 i get a error with my style. Error in style: Error: (points:179): Invalid rule expression: $mkgmap:admin_level2!=DEU & $name:en=$name:de
This is a bug in mkgmap. The attached patch fixes it. Thanks for reporting this problem. Steve