Hi Steve,
1. Use the option set by the user. +1
2. If options is not given, look up the countries (from LBL) in the LocatorConfig; if all are drive-on-the-same-side use that.
I counted the roundabouts because they seem to be the only affected elements of this flag and I thought it might be easier to find a clean cut between different "dol" and "dor" areas. The code for that is simple enough.
3. In all other cases (and --route is given) warn loudly. OK. I'll change that in my patch.
So I'd just ignore roundabouts in the normal case. Obviously --check-roundabouts can make any checks that it likes, it is useful to debug OSM data, its not supposed to be essential to produce a map.
I never liked the idea that an option called check-xxx is also changing the data, although I am not sure if this still happens today.
Probably not. The --country-* options were added very early on since every POI has to have a country either directly or it has a region that has to have a country. At that time they were defaults for when there was no addr:country on a POI (almost always in those days!).
I suppose that if the bounds file is complete there is no need for a default, but I would expect that the --country-name should be used if there isn't one.
Okay, if I got it right we just have to add a few lines in StyledConverter. I'll post a patch for this. Gerd