Hi Gerd Thinking about this a bit more, there are still some cases where adjacent shapes are next to cut-lines to get to holes (ie 3 or more lines at same cut-point) that might not be ordered correctly. I think it is possible to fix these by adding another sort structure. Starting on this, I didn't like some of my new awkward shape handling code and it has is a bug in the handling of the last element in the list - fixed in the tidy-up I've attached low-res-opt patch Ticker On Wed, 2021-06-02 at 14:58 +0000, Gerd Petermann wrote:
Hi Ticker,
That seems to work better. I still see some error messages but those are probably really invalid shapes produced by ShapeMerger. At least I see that one point is visited more than twice and that should not happen.
Maybe you can add unit tests to test the error cases?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Mittwoch, 2. Juni 2021 16:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] special case where splitting fails without a log message
Hi Gerd
I've found and fixed some stupid mistakes - sorry for wasting your time.
Patch attached - works with your test case.
Ticker
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev