Hi Carlos, I've committed this patch now. I hesitated because we also have a hard-coded check for "FIXME" and "fixme" in the java code. If I got that right, this code is only used to set mkgmap:dead-end-check=false for a routable way when either the start or end node is tagged with FIXME=* or fixme=*. I did not find many other spellings of these tag keys, so I guess that this code is still okay reg. the spelling. Gerd ________________________________________ Von: mkgmap-dev-bounces@lists.mkgmap.org.uk <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Carlos Dávila <cdavilam@orangecorreo.es> Gesendet: Montag, 11. Januar 2016 22:11 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Catch more fixme variants to delete Hi Gerd Good point. I have tested your patch on a large dataset (whole Asia) and all fixme's disappeared. El 11/01/16 a las 07:36, Gerd Petermann escribió:
Hi Carlos,
I think one test is enough, and your change doesn't seem to catch "fix_me". Try the attached version of the patch. The regex '(?i)fix[ _]?+me' uses a so called "Possessive quantifier" : X?+ means X, once or not at all
Gerd
________________________________________ Von: mkgmap-dev-bounces@lists.mkgmap.org.uk <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Carlos Dávila <cdavilam@orangecorreo.es> Gesendet: Sonntag, 10. Januar 2016 15:05 An: Development list for mkgmap Betreff: [mkgmap-dev] Catch more fixme variants to delete
Default style contains some rules in inc/name to catch fixme's in name, ref, brand and operator tags and delete them, but the number of variants of fixme's is quite wide and some are not catched, so I have replaced current rules with a regular expression, to try to catch them all. Attached is a patch that implement this.
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev