
28 Mar
2018
28 Mar
'18
4:53 p.m.
Hi Gerd
looks good for me, although you may simplify the code in isIndexable(): a) The expression ((ValueOp) op.getFirst()).isIndexable() appears three times b) the term (op.getSecond().isType(VALUE) || op.getSecond().isType(FUNCTION) appears two times and I wonder why it is needed. Do you have an example? The unit tests don't fail when I remove it.
OK a lot of that is not needed any more. The attached patch returns isIndexable() to its simplest form and all the other code is changed to fit. Steve