Hi Steve, thanks, problem occurs when one side has NONE and the other hasn't. I think the test should not produce values which the normal program never does (NONE with -1 for start + end). Or do you find such data in Garmin maps? In that case meaby it has a special meaning? Gerd
Date: Tue, 21 Apr 2015 10:24:47 +0100 From: steve@parabola.me.uk To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] error in NumberPreparer?
Hi Gerd
it seems that NumberPreparer (in trunk) doesn't completely ignore the start/end values when numberStyle == NONE.
I was just going to post that the patch failed with NumberRangeTest, wheras trunk passes. It seems you may have found the answer but I don't think this code should be reached when both styles are NONE since it should have exited at numbers.isEmpty() -- at least in the original code.
See line 116: if (first.getLeftStart() > first.getLeftEnd() || first.getRightStart() > first.getRightEnd()) initial = Math.max(initial, rightStart); else if (rightStart > 0) initial = Math.min(initial, rightStart);
I've got to go out now, I will try to have a look at it later.
..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev