18 Jan
2010
18 Jan
'10
9:31 p.m.
Hi Steve, On Mon, Jan 18, 2010 at 05:09:05PM +0000, Steve Ratcliffe wrote:
I produced the attached patch which makes all the previous examples compile (apart from the plain a~b example).
Great! The algorithm looks OK to me. I have some remarks about it, using stricter type casts, adding missing static qualifiers and adding or updating some comments, and replacing an "assert false" with an exception (in case someone runs with assertions disabled and the code is rearranged so that the assertion would be reached). Your patch with my revisions is attached. Unfortunately, I was unable to test on today's dump because of the NullPointerException that I mentioned earlier. Marko