- mkgmap-dev - The mkgmap lists

Commit r4384: code cleanup using hints from sonarlint, no change in output expected
by svn commit 03 Dec '19

03 Dec '19

Version mkgmap-r4384 was committed by gerd on Tue, 03 Dec 2019 code cleanup using hints from sonarlint, no change in output expected - remove dead code, remove redundant specification of type arguments, reformatting - make some fields final - make some methods static code cleanup using hints from sonarlint, no change in output expected - use more lambdas and computeIfAbsent - merge nested if-then clauses - improve formatting http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4384

1 0

Commit r4383: small correction: Last commit (r4382) removed a Math.round(). This is not really needed but it can cause an unintended change in the output in some cases.
by svn commit 03 Dec '19

03 Dec '19

Version mkgmap-r4383 was committed by gerd on Tue, 03 Dec 2019 small correction: Last commit (r4382) removed a Math.round(). This is not really needed but it can cause an unintended change in the output in some cases. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4383

1 0

Commit r4382: code cleanup using hints from sonarlint, no change in output expected
by svn commit 02 Dec '19

02 Dec '19

Version mkgmap-r4382 was committed by gerd on Mon, 02 Dec 2019 code cleanup using hints from sonarlint, no change in output expected - remove dead code, remove redundant specification of type arguments, reformatting - make some fields final - make some methods static - add method Way.calcLengthInMetres and use it in LengthFunction, SeaGenerator, and LinkDestinationHook http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4382

1 0

Commit r4381: Corrections in SeaGenerator:
by svn commit 02 Dec '19

02 Dec '19

Version mkgmap-r4381 was committed by gerd on Mon, 02 Dec 2019 Corrections in SeaGenerator: - no natural=sea way was added for the combination --precomp-sea=sea.zip --generate-sea=polygon - tag natural=coastline was removed while processing ways with this tag when neither precomp-sea nor coastlinefile is used. Now extra copies of those ways with just this tag are added http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4381

1 0

Old versions
by Jakob Mühldorfer 30 Nov '19

30 Nov '19

Hi folks, I ran into a new bug updating from 4289 to 4373. Are there some older builds in between available, so I can easily track where this started? Thank you

2 1

coastlines
by Gerd Petermann 29 Nov '19

29 Nov '19

Hi all, While improving the code of the SeaGenerator I've noticed that the map produced with option --precomp-sea has type 0x15 lines for the coastline while a map produced with option --generate-sea=multipolygon,extend-sea-sectors,close-gaps=350 (used by Ticker) has no such lines. I wonder if this is intended? My test data is attached, it just contains three islands in the ocean. I've also noticed that --precomp-sea in combination with generate-sea=polygon doesn't add any 0x32 polygon in this situation. I've fixed this already in my version. Gerd

2 1

Commit r4380: code simplification, no functional change
by svn commit 28 Nov '19

28 Nov '19

Version mkgmap-r4380 was committed by gerd on Thu, 28 Nov 2019 code simplification, no functional change http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4380

1 0

Basecamp and NET/NOD changes
by Ticker Berkin 27 Nov '19

27 Nov '19

Hi Gerd I'm getting routing problems with Basecamp when using routing island removal. Building with: java -jar ../mkgmap.trunk/mkgmap.jar -c ticker.cfg --check-routing -island-len=700 --family-name=trRIL700 -c template.args ticker.txt a high proportion of routes fail, ie it just generates a straight line. This is using Motorcar, Shortest distance, no avoids. My Garmin device generates routes correctly. Building with: java -jar ../mkgmap.trunk/mkgmap.jar -c ticker.cfg --check-routing -island-len=-1 --family-name=trRIL-1 -c template.args ticker.txt routes are calculated that follow roads. mkgmap.trunk is my build of the latest sources (r4373), attached are the various small files, with img data unchanged from before: http://files.mkgmap.org.uk/download/454/hants.pbf.zip Some examples that work: "SO22 6AN" to "SO23 8DS" "SO22 6AN" to "SO15 7NQ" Some examples that fail in Basecamp: "SO22 6AN" to "SO23 8RJ" "SO22 6AN" to "SO15 1AG" "SO22 6AN" to "SO15 7NG" "SO15 7NG" to "SO15 7NQ" I also notice that display:test.check.NetCheck and NodCheck run through on --c-r-i-l=700 but give quite a few errors, whereas, with --c-r-i-l= -1, NetCheck doesn't find any errors but NodCheck crashes after giving the message: --------- 74210002.img -------------------- Could not find node for road 48815 nod2=173db Exception in thread "main" java.lang.NullPointerException at test.check.NodCheck.checkNod2(NodCheck.java:91) at test.check.NodCheck.print(NodCheck.java:63) at test.display.CommonDisplay.display(CommonDisplay.java:204) at test.check.CommonCheck.runMain(CommonCheck.java:145) at test.check.NodCheck.main(NodCheck.java:1004) I wonder if you can help - I was trying to use Basecamp to narrow down another routing problem I was having with my Garmin device. Thanks Ticker

2 19

MKGMAP COMBINE using mkgmap-r4377 Map is Empty (mkgmap-r4373 is OK)
by AnkEric 27 Nov '19

27 Nov '19

MKGMAP COMBINE using mkgmap-r4377 Map is Empty: ovm_40010<nnn>.img is OK 40010<nnn>.img is EMPTY (0 bytes) Time started: Wed Nov 27 08:45:01 CET 2019 Setting max-jobs to 4 Number of MapFailedExceptions: 0 Number of ExitExceptions: 0 Time finished: Wed Nov 27 09:04:55 CET 2019 Total time taken: 19 minutes 54 seconds I did run map making procedure twice, both not ok. After these runs I reverted to mkgmap-4373, which is OK. MKGMAP COMBINE using mkgmap-r4373 Map is OK: ovm_40010<nnn>.img is OK 40010<nnn>.img is OK Time started: Wed Nov 27 09:25:36 CET 2019 Setting max-jobs to 4 Number of MapFailedExceptions: 0 Number of ExitExceptions: 0 Time finished: Wed Nov 27 09:49:24 CET 2019 Total time taken: 23 minutes 48 seconds Unknow is the result by latest version mkgmap-r4378. / AnkEric -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html

2 4

Commit r4379: fix NullPointerException when option --polygon-size-limits doesn't give a value for the resolution at level 1.
by svn commit 27 Nov '19

27 Nov '19

Version mkgmap-r4379 was committed by gerd on Wed, 27 Nov 2019 fix NullPointerException when option --polygon-size-limits doesn't give a value for the resolution at level 1. Problem was introduced with r4376, which used 0 for those resolutions. This behviour seems strange but it restored now. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4379

1 0