- mkgmap-dev - The mkgmap lists

Work on is_in branch
by Gerd Petermann 06 Mar '20

06 Mar '20

Hi all, sorry, something is broken in the mail system. The latest posts don't appear on nabble (1) and my answers to existing threads are rejected. @Ticker: I'd prefer to do the merge and I think it should be done in IsInUtil. Your patch is_in-function_v7.patch goes in the opposite direction. Not sure what you plan to do now? Gerd (1) http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html

3 42

is_in example?
by nwillink 05 Mar '20

05 Mar '20

Hi Can anyone tell me how to use the revised is_in function as I'm just getting the following errors. Error in style: Error: (points:521): Expecting ) instead saw landuse I can't seem to find any practical examples :( With an older version this works: barrier=gate & is_in(landuse,residential,all)=true {delete barrier} I tried barrier=gate & is_in(landuse,residential,in_or_on)=true {delete barrier} But again , I get the same error. Perhaps , the function still hush-hush ;) Regards Nick -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html

3 2

dead end check patch v3
by Mike Baggaley 05 Mar '20

05 Mar '20

Hi Gerd, please find attached an updated patch that resolves the issue of tags specified possibly not being picked up by the style file reader. Cheers, Mike -----Original Message----- From: Mike Baggaley [mailto:mike@tvage.co.uk] Sent: 01 March 2020 17:03 To: 'Development list for mkgmap' <mkgmap-dev(a)lists.mkgmap.org.uk> Subject: RE: [mkgmap-dev] dead end check patch v2 Hi Gerd, Adding # disable dead-end-check for ways with end nodes having special tags (amenity=parking_entrance | railway=car_shuttle | railway=rolling_highway) {add fixme=true} does cause those to be omitted from the report. However, it also omits those that already have fixme tags, which I do not want removed. I could add fixme=* {delete fixme} ahead of the above, but then I would not get the values of any fixme tags included in my reports. Regards, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 01 March 2020 16:49 To: Mike Baggaley <mike(a)tvage.co.uk>; 'Development list for mkgmap' <mkgmap-dev(a)lists.mkgmap.org.uk> Subject: AW: [mkgmap-dev] dead end check patch v2 Hi Mike, I don't understand why you don't add a rule to the points file containing something like # disable dead-end-check for ways with end nodes having special tags (amenity=parking_entrance | railway=car_shuttle | railway=rolling_highway) {add fixme=true} You did not yet say why this doesn't work for you. I would also agree to add this in the default style. I'd also agree to change the java code to handle the tag mkgmap:dead-end-check=no in addition to the fixme tags so that we could write (amenity=parking_entrance | railway=car_shuttle | railway=rolling_highway) {add mkgmap:dead-end-check=no} BTW: I was about to commit your patch v2 with a few changes, but it suffers from the same problem mentioned before: If the style doesn't use the tag railway anywhere you might not find railway=car_shuttle though this is very unlikely. Gerd ________________________________________ Von: Mike Baggaley <mike(a)tvage.co.uk> Gesendet: Sonntag, 1. März 2020 17:30 An: 'Gerd Petermann'; 'Development list for mkgmap' Betreff: RE: [mkgmap-dev] dead end check patch v2 Hi Gerd, there are several issues. Firstly, omitting ways from the dead end check because they have fixme tags is not something I want to do. Whilst this may be one way of reducing the number of reported warnings, and some users may want to do this, I do not. As it is undocumented behaviour, other users will probably not expect it to do this either. For my report, I only want to omit ways that are marked with valid reasons for a dead end (I am currently using amenity=parking_entrance, railway=car_shuttle and railway=rolling_highway, but there may be other tags I have not come across yet). I do not want to delete existing fixme tags because I want to see the value of any relevant fixme tag in the report. The current method of using fixme to control whether or not a way with certain tags on an end node is omitted from dead end checks is obscure and requires prospective users to have to ask whether it can be done and if so how. I have offered two simple solutions with appropriate documentation that will reduce the likelihood of such questions having to be asked. The first, using a style file is more flexible as it allows the power of the style to use combinations of values (e.g. amenity=parking_entrance & highway=service {set mkgmap:dead-end-check=no}). This method does require anyone currently using dead end checks to review their style file to determine which tags they want to be omitted from the check (if they are not using the supplied default style). The second option can only use the existence of a tag on its own to omit a way (e.g. --dead-ends=amenity=parking_entrance), but does not require users to make any changes if they want to continue to omit the same ways as they do currently. I do not understand why you are so resistant to making a change that improves the way mkgmap works, has no effect on the actual map and whose only impact for existing users is a possible slight change in the handling of reporting of dead ends. In the patches, I also corrected a typo in one other message and fixed a double space in another. These changes can equally be said to be not backwards compatible, but I don't believe anyone would say that this should prevent them from being done. Regards, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 27 February 2020 11:04 To: 'Development list for mkgmap' <mkgmap-dev(a)lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] dead end check patch v2 Hi Mike, I fear I don't understand the problem yet. It seems you don't like the idea that a tag like fixme=* set in the points rules changes the behaviour of the dead-end-check? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces(a)lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike(a)tvage.co.uk> Gesendet: Donnerstag, 27. Februar 2020 00:17 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] dead end check patch v2 Hi Gerd, Please find attached the alternate patch for improving the dead end check, which is fully backwards compatible. This adds a new command line option -- dead-ends which lists the tags and optional values that are to be considered to be valid dead ends when found on the node at the end of a way. The default is --dead-ends=fixme,FIXME. Regards, Mike

2 1

Commit r4462: implement new option --dead-ends[=key[=value]][, key[=value]...]
by svn commit 05 Mar '20

05 Mar '20

Version mkgmap-r4462 was committed by gerd on Thu, 05 Mar 2020 implement new option --dead-ends[=key[=value]][,key[=value]...] --dead-ends[=key[=value]][,key[=value]...] Specify a list of keys and optional values that should be considered to be valid dead ends when found on the node at the end of a way. Ways with nodes matching any of the items in the list will not be reported as dead ends. If no value or * is specified for value then presence of the key alone will cause the dead end check to be skipped. The default is --dead-ends=fixme,FIXME. Also corrects some typos in documentation and javadoc. deadendcheck3.patch by Mike Baggaley with small modifications http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4462

1 0

NSIS Script
by Dave 04 Mar '20

04 Mar '20

Hi All, Just to let you know that compiling NSIS scripts with the Nullsoft Install System v3.05 there are warnings that ANSI installers are deprecated. By inserting the line 'Unicode true' in the script file a Unicode installer is created, I have inserted it below the 'SetCompressor' line. But the same effect can be achieved by the user editing the nsisconf.nsh file in the NSIS install directory and adding Unicode true to that file, doing this means any NSIS script run on the users machine will produce an Unicode installer regardless. >From the documentation: 4.8.2.9 Unicode true|false Generate a Unicode installer. It can only be used outside of sections and functions and before any data is compressed. Regards, Dave

1 0

dead end check patch v2
by Mike Baggaley 01 Mar '20

01 Mar '20

Hi Gerd, Please find attached the alternate patch for improving the dead end check, which is fully backwards compatible. This adds a new command line option -- dead-ends which lists the tags and optional values that are to be considered to be valid dead ends when found on the node at the end of a way. The default is --dead-ends=fixme,FIXME. Regards, Mike

2 4

dead end check patch
by Mike Baggaley 26 Feb '20

26 Feb '20

Hi Gerd, please find attached a small patch that improves the dead end check. It amends the code that looks for a fixme tag on a node to make it look for a mkgmap:dead-end-check tag instead, and adds a line to the points file setting mkgmap:dead-end-check=no for nodes with amenity=parking_entrance, railway=car_shuttle, railway=rolling_highway, fixme=* or FIXME=*. Please review. Thanks, Mike

2 4

wrong result from is_in style function
by Gerd Petermann 24 Feb '20

24 Feb '20

Hi Ticker, please try attached sample file with the two rules in polygons. With r4456 I see Way -101782 all OK but not Way -101782 any OK Gerd

2 1

Commit r4454: Correct WrongAngleFixer: Avoid to disconnect end points of routable lines from non-routable lines even when the end point causes a distortion of the non-routable line.
by svn commit 20 Feb '20

20 Feb '20

Version mkgmap-r4454 was committed by gerd on Thu, 20 Feb 2020 Correct WrongAngleFixer: Avoid to disconnect end points of routable lines from non-routable lines even when the end point causes a distortion of the non-routable line. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4454

1 0

Connected ways rendered as Unconnected ways due to Garmin low resolution
by AnkEric 19 Feb '20

19 Feb '20

Hi All, Minor, but irritating and hard to find issue. I have searched in Archive for "Unconnected ways", but I cannot find any relevant postings on the subject. Issue: in JOSM we can and should map accurately. A roundabout is a circle (Create Circle), a building is a rectangle (Orthogonalize Shape). Looking at the Map in https://www.openstreetmap.org/ it's perfect, in OsmAnd it's rather oké, but MkgMap on Garmin Device (or BaseCamp) is a "sloppy" polygon. More important: connected highways are sometimes (sometimes!) rendered as not connected. Therefore routing is not possible because of "Unconnected ways". These exceptions are hard to find (for me it is). Validation Tools (JOSM, Osmose, OSMI, Keep Right) won't find these errors because on OSM it's oké. One example: <http://gis.19327.n8.nabble.com/file/t344065/MKGMAP_NOT_Connected_highways.p…> To resolve (IF I do find an exception): - and/or: Simplify ways, most specific for a roundabout (8 nodes is preferred to 16 nodes). - and/or: Move the Connecting node (which is Unconnected on the Map) very slightly. Small, minor move is always enough to resolve. Also: Rendering can resolve. If the issue does occur on a bicycle map (highways are rendered by narrow lines) than the issue will not occur if the width of a highway is rendered larger (on a Motorcar/general map). I'm prepared for an answer like: "This is Garmin, not MkgMap!" Or is something like "snap to grid" an option for MkgMap to resolve by a work-around? Or improved logging of exceptions? If I can find these "errors" I can resolve! Most annoying (for me): my attempts to improve card quality leads to "routing errors". / Eric (AnkEric) -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html

2 5