- mkgmap-dev - The mkgmap lists

Line direction flag, merging etc
by Ticker Berkin 19 May '21

19 May '21

Hi Gerd and others I'm starting a dedicated thread as previous posts are split between various svn commits. Looking at the current trunk code and ignore-oneway-for-lines.patch, there are bits I don't understand or didn't expect. This is what I hope for: --line-types-with-direction lists the lineTypes for which the initial state of the hasDirection flag is considered true. It should be independent of --allow-reverse-merge (see later). The purpose of this is to reduce the need to edit styles and clarity as to which lineTypes are displayed with direction. In the following, road means line with [road_class, road_speed], so includes ferries. Style processing, having produced a line/road, sets hasDirection, in order of precedence: 1/ value of mkgmap:has-direction if tag exists 2/ true if oneway road 3/ true if in line-types-with-direction list RoadMerger merges roads with same lineType, names, class, speed, oneway and hasDirection. It must not reverse oneway or hasDirection=true roads when doing this. I don't think we need --allow-reverse-merge. LineMergeFilter operates for level > 0. It merges any line/road with the same lineType, names, hasDirection. It must not reverse hasDirection=true. Ticker

2 20

Commit r4726: modify evaluation of direction flag (again)
by svn commit 19 May '21

19 May '21

Version mkgmap-r4726 was committed by gerd on Wed, 19 May 2021 modify evaluation of direction flag (again) (dirFlagSetting_v2.patch by Ticker Berkin, modified) - don't ignore option --line-types-with-direction if --allow-reverse-merge option is not set - allow to have direction-flag unset even for ways with oneway=yes/-1 "The ambition was to be able to turn off hasDirection if [oneway=yes/-1] (roads only) and/or --lines-types-with-direction would have it on." http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4726

1 0

4179
by Felix Hartmann 18 May '21

18 May '21

Hi Gerd oneway tag no longer influences the direction flag of non-routable lines. Note that oneway=-1 still means line is reversed and oneway=yes is set. I think this is only needed if the linetype is listed under --line-types-with-direction If not listed here nor routable oneway=-1 is as irrelevant as oneway=yes I do not understand why we would have different handling of onway=yes and oneway=-1 Reversing the road should not be needed because it does not matter for the layout, nor for the routing. -- Felix Hartman - Openmtbmap.org & VeloMap.org

3 19

Different levels in Overview map
by Thomas Morgenstern 16 May '21

16 May '21

Hi, I noticed, that the linetyp highway=motorway is treated different in the overview map . For example the motorway A9 is Data1, motorway A73 is Data0 (I use GpsMapedit for analyse: polish map format). Polyline 0x01 : in Zoomlevel1 =6493 entrys, in Zoomlevel0=13676 entrys. Also polygon 0x27 : in Zoomlevel2=1519 entrys, in Zoomlevel0=20641 entrys. .Some entrys have Data2, others have Data0. Because that, when I zoom in or out, some motorways are displayed, others not displayed. I would expect, that same objects come to the same Level. I use my own STYLE. but is not very different from default. What can I do to avoid such inconsistence ? In my opinion, the same object should be completely contained at the same level. Thomas

2 1

Commit r4715: rework of options for reverse merge
by svn commit 16 May '21

16 May '21

Version mkgmap-r4715 was committed by gerd on Fri, 14 May 2021 rework of options for reverse merge - replace option --x-force-reverse-merge by --allow-reverse-merge which has to be set to enable reversing for merge, add documentation - implement new option --line-types-with-direction to list line types which should not be reversed, also documented - special tag mkgmap:has-direction=yes/1/true can be used to to mark a line as not reversable - special tag mkgmap:has-direction=no/0/false can be used to to mark a line as reversable (does not overwrite oneway=yes or oneway=-1 tag, only the --line-types-with-direction option) - remove code to detect if style sets mkgmap:has-direction=true - remove code to propagte the mkgmap:has-direction=true tag to underlying roads, might not be needed this reverts r4713 and r4714 and partly r4703 - don't merge lines with different has-direction flag (as r4710 in the low-res-opt branch) http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4715

5 22

Patches ignore oneway tag for non-routable lines
by Gerd Petermann 15 May '21

15 May '21

Hi all, following the discussion about commit r4715 here is a small patch to change mkgmap so that it doesn't set the direction flag in IMG when an OSM way has a oneway=1 or oneway=-1 tag when the corresponding line is not a road (a routable line with roadclass or road speed). Two patches because Ticker suggests to evaluate oneway also for lines and assume that the style will set mkgmap:has-direction=no to overwrite it. The other patch simply doesn't evaluate oneway for the direction flag. This gives smaller image files for styles which wee not yet changed. Gerd

2 1

java.lang.NumberFormatException: For input string: ""
by Felix Hartmann 15 May '21

15 May '21

This error happens on conoturlines generation - any ideas? Should I upload the files for debug? I first thought phyghtmap may have produced data with an empty string and on the ft to m conversion this error appears. However I kinda excluded that from happening by making sure only lines with a number are used & ( ele>0 | ele=0 | ele<0 ) Happens on a couple of countries worldwide and seems to be style related - but the same style works on most countries data so the style itself is not broken. SEVERE (global): Unexpected error java.lang.NumberFormatException: For input string: "" at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:68) at java.base/java.lang.Integer.parseInt(Integer.java:662) at java.base/java.lang.Integer.parseInt(Integer.java:770) at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195) at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578) at uk.me.parabola.mkgmap.build.MapBuilder.parseDemDists(MapBuilder.java:280) at uk.me.parabola.mkgmap.build.MapBuilder.config(MapBuilder.java:275) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:113) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:70) at uk.me.parabola.mkgmap.main.Main.lambda$processFilename$1(Main.java:290) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) at java.base/java.lang.Thread.run(Thread.java:832) SEVERE (global): Exiting due to unexpected error Number of ExitExceptions: 1 Time finished: Sat May 15 14:27:05 CEST 2021 -- Felix Hartman - Openmtbmap.org & VeloMap.org

2 2

Commit 4710
by Felix Hartmann 15 May '21

15 May '21

fix error in LineMergeFilter reg. lines with direction The line merger should not merge lines if one has the direction flag set and the other has not. Problem exists also in trunk. Hmm fixing this stopped all the nice size optimization. Map size got much bigger again. I did not find any place where this mattered. Routing was also not affected badly. Maybe I did not look good enough? I do not see why not to merge them. As long as it`s not the opposite it seems fine... Map size increase/decrease is around 1.5% with my style. So thats quite a big difference. -- Felix Hartman - Openmtbmap.org & VeloMap.org

4 44

Commit r4717: cleanup, no change in output, maybe minimal performance improvement
by svn commit 15 May '21

15 May '21

Version mkgmap-r4717 was committed by gerd on Sat, 15 May 2021 cleanup, no change in output, maybe minimal performance improvement - remove debug code - remove field index in ConvertedWay, is no longer needed to produce stable results in RoadMerger http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4717

1 0

TYP file UseOrientation
by Gerd Petermann 14 May '21

14 May '21

Hi all, I just noticed the UseOrientation=Y/N setting in TYP files. Is this related to the direction flag of the line in IMG? Gerd

4 3