- mkgmap-dev - The mkgmap lists

special cases in restriction relations, r3178 still not perfect
by Gerd Petermann 11 Apr '14

11 Apr '14

Hi all, I found a few more very special cases, some can be easily fixed in the code, but one is maybe a problem in OSM: See http://www.openstreetmap.org/relation/1626132 The 'to' way starts and ends at the via point. In combination with the tag restriction=only_straight_on it is clear what this means, but the current implementation in mkgmap is not prepared for that. It would probable create a different result if the points of the 'to' way would go clockwise and not ccw. I think the wiki doesn't say that this is not correct, so to support this mkgmap has to interpret the restriction. Up to now it just checked if it is a only_xxx or an no_xxx restriction. It is much more complex to interpret the angle and find out what is meant. This seems too much work for that special case, so I prefer to print a warning and ignore the restriction. OK? Gerd

3 5

Commit: r3182: - don't ignore no_entry restriction relation if it has
by svn commit 11 Apr '14

11 Apr '14

Version mkgmap-r3182 was committed by gerd on Fri, 11 Apr 2014 - don't ignore no_entry restriction relation if it has multiple 'from' ways and one way is not routable or outside bbox, as long as one routable 'from' way remains - don't ignore no_exit restriction relation if it has multiple 'to' ways and one way is not routable or outside bbox as long as one routable 'to' way remains

1 0

Commit: r3181: adapt expected TRE size in unit test
by svn commit 11 Apr '14

11 Apr '14

Version mkgmap-r3181 was committed by gerd on Fri, 11 Apr 2014 adapt expected TRE size in unit test

1 0

Commit: r3180: - don't merge via nodes with boundary nodes in WrongAngleFixer
by svn commit 11 Apr '14

11 Apr '14

Version mkgmap-r3180 was committed by gerd on Fri, 11 Apr 2014 - don't merge via nodes with boundary nodes in WrongAngleFixer - don't merge end points of a way if way has only two points, even if they have highPrecEqual() coordinates. These ways may be created by the LinkDestinationHook. - print error message if a way that is referenced in a restriction is outside of bbox, but was (partly) inside before WrongAngleFixer was executed.

1 0

Commit: r3179: add check to make sure that all ways that are referenced in
by svn commit 11 Apr '14

11 Apr '14

Version mkgmap-r3179 was committed by gerd on Fri, 11 Apr 2014 add check to make sure that all ways that are referenced in a restriction relation have at least two points and that first and last point are not identical. Print warning if the check fails and ignore the restriction.

1 0

r3177 and open question
by Gerd Petermann 10 Apr '14

10 Apr '14

Hi all, r3177 should fix the reported crashes. It still prints error messages for restriction relations, e.g. Schwerwiegend (RestrictionRelation): e:\osm_out_work\germany\20140205_071837\63240003.o5m: Turn restriction (only_right_turn) http://www.openstreetmap.org/browse/relation/2456606 (at http://www.openstreetmap.org/?mlat=51.296499&mlon=6.925914&zoom=17) way http://www.openstreetmap.org/browse/way/184456457 doesn't have required node or Schwerwiegend (RestrictionRelation): e:\osm_out_work\germany\20140205_071837\63240054.o5m: Turn restriction (only_straight_on) http://www.openstreetmap.org/browse/relation/3310817 (at http://www.openstreetmap.org/?mlat=51.480335&mlon=12.018367&zoom=17) via node is not a routing node I am not sure what to do in these cases. The typical reason is that the restriction is valid, but one of the ways is not a road (style doesn't assign road_speed or road_class). I guess I should change the level to warning in such a case? The alternative would be to add a tag like highway=unclassified to the ways used in restriction relations if they don't have a highway=* tag. Gerd

3 2

r3178
by Gerd Petermann 10 Apr '14

10 Apr '14

Hi all, with mkgmap r3178 and splitter r321 you should not see any Turn restriction ... doesn't have required node error messages. If you see them, please report details. Gerd

1 0

Commit: r3178: - fix error: if the 'to' way of a restriction relation was merged to a
by svn commit 10 Apr '14

10 Apr '14

Version mkgmap-r3178 was committed by gerd on Thu, 10 Apr 2014 - fix error: if the 'to' way of a restriction relation was merged to a p-shaped way with the via node appearing twice, make sure that splitWayAt() tells the restriction relation to use the correct part after splitting. - don't print error message "way ... doesn't have required node" for restrictions when referenced ways are not routable, instead print warning "restriction ... is ignored because referenced way ... is not routable" or "restriction ... is ignored because referenced way ... is ignored" in case the way has less than 2 points or no tags.

1 0

Commit: r3176: add copyright info, no functional change
by svn commit 10 Apr '14

10 Apr '14

Version mkgmap-r3176 was committed by gerd on Thu, 10 Apr 2014 add copyright info, no functional change

4 7

Commit: r3177: - fix possible NPE for invalid restriction relation
by svn commit 10 Apr '14

10 Apr '14

Version mkgmap-r3177 was committed by gerd on Thu, 10 Apr 2014 - fix possible NPE for invalid restriction relation - fix possible assertion that is not an error

1 0