- mkgmap-dev - The mkgmap lists

refactoring
by Gerd Petermann 27 Apr '14

27 Apr '14

Hi all, please test / review the changes in the branch. Users: You should find no differences in map output between trunk r3215 and branch r3214, but maybe the log is different. Programmers: please have a closer look at the source. The intended changes : 1) Create new class AccessTagsAndBits which contains code to map tags which are relevant for routing to bit masks. I prefer to have to bit 1 for "access allowed" to avoid double negations like in "if (!noAccess[i]) ..." I hope that is okay for you as well. All routines which read data are now using the same bit constants regarding CAR,FOOT,BICYCLE,TRUCK, etc. to fill a bit mask field. The write routines convert the internal representatio to that used in the img format. @WanMil: Special case: Code in StyledConverter near roadLog.isInfoEnabled() formats the content of the TabAAcesss field in RoadDef which contains the img format. I think this is okay because the intention of the log is to show exactly the content of this field. 2) Create class ConvertedWay which combines an OSM Way instance with a reference to a GType instance. Instead of copying and modifying fields (roadClass, roadSpeed) in GType instances this is now done in ConvertedWay. Many tags which are relevant for routing are evaluated once when the ConvertedWay instance is created. The results are kept in bit masks, this allows a quick compare. Also, RoadMerger uses this class instead of creating new Road instances. @WanMil: The new code produces a different log on debug level because some comparisons are done in different order. I've changed the code to compare the bit mask fields instead of the tags, but the code still lists (most of) the compared tags to be able to produce debug info. Let me know if that is okay for you. Another solution could be to implement the debugging in ConvertedWay e.g. something like public String compareAccess(ConvertedWay other) could return a String like "mkgmap:truck is different 'no' <> 'null' " 3) With r3214 I've renamed a few methods. Please check if you find better names: http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3214

2 3

Commit: r3232: oops, forgot to commit one file
by svn commit 27 Apr '14

27 Apr '14

Version mkgmap-r3232 was committed by gerd on Sun, 27 Apr 2014 oops, forgot to commit one file

1 0

Commit: r3231: rework of evaluation of restriction vehicles.
by svn commit 27 Apr '14

27 Apr '14

Version mkgmap-r3231 was committed by gerd on Sun, 27 Apr 2014 rework of evaluation of restriction vehicles. - don't use motorcycle as synonym for motorcar in RestrictionRelation (use the relations style file if you want to treat motorcycle like motorcar) - restriction doesn't apply to emergency, unless "type=restriction:emergency" or "restriction:emergency=*" is used - evaluate also vehicle as synonym for "motor_vehicle" and "bicycle" - evaluate psv as synonym for "bus" and "taxi", not just "bus" - remove vehicle "delivery" - added some unit tests to test the vehicle evaluation

1 0

Attribution
by Roger Calvert 27 Apr '14

27 Apr '14

I have a simple (I think) and not very important, query: My Garmin reports my mkgmap-generated map as 'mapsource' (presumably the default - I do not use Mapsource to upload it). Is there a way to make it say 'mkgmap' (or something else) instead? Thanks, Roger -- ------------------------------------------------------------------------ Roger Calvert ------------------------------------------------------------------------

3 3

delete name not working
by franco_bez 25 Apr '14

25 Apr '14

Hi all, I'm facing a very strange problem with the style function delete. in the points file I have the following rule In the past this removed unwanted labels on post boxes in the map. Since quite some time, I assume since the change to the new style rules a few month ago, the labels re-appeared in the map. I tried many different things to get rid of them but I always failed. Any Idea what's going wrong here ? I composed a testcase for the bug, sample osm data and style is included: happens everywhere but my testcase is located here <http://www.openstreetmap.org/?mlat=47.87609&mlon=10.62906#map=19/47.87609/1…> Download Testcase <http://files.mkgmap.org.uk/download/205/delete_name_bug_testcase.tgz> here's a screenshot of a "points only" map from the testcase <http://gis.19327.n5.nabble.com/file/n5804145/102.bmp> -- View this message in context: http://gis.19327.n5.nabble.com/delete-name-not-working-tp5804145.html Sent from the Mkgmap Development mailing list archive at Nabble.com.

3 6

Re: [mkgmap-dev] Problem with this restriction?
by Bernd Weigelt 25 Apr '14

25 Apr '14

Thank you , Gerd Hier sollte eigentlich eine Signatur stehen. -----Original Message----- From: Gerd Petermann <gpetermann_muenchen(a)hotmail.com> To: "mkgmap-dev(a)lists.mkgmap.org.uk" <mkgmap-dev(a)lists.mkgmap.org.uk> Sent: Do., 24 Apr. 2014 23:06 Subject: Re: [mkgmap-dev] Problem with this restriction? Hi Bernd, the error is fixed with r3229. I am also checking why the restriction 2254003 is ignored. The angle doesn't look that bad, but mkgmap calculates an angle which seems to say right turn. Gerd > From: weigelt.bernd(a)web.de > To: mkgmap-dev(a)lists.mkgmap.org.uk > Date: Thu, 24 Apr 2014 21:00:47 +0200 > Subject: [mkgmap-dev] Problem with this restriction? > > > Hi > > I got this error if i build a map around DE-Starnberg > > Time started: Thu Apr 24 20:50:22 CEST 2014 > java.lang.AssertionError > at > uk.me.parabola.imgfmt.app.net.RouteRestriction.<init>(RouteRestriction.java:88) > at > uk.me.parabola.imgfmt.app.net.RoadNetwork.addRestriction(RoadNetwork.java:536) > at > uk.me.parabola.mkgmap.general.MapDetails.addRestriction(MapDetails.java:131) > at > uk.me.parabola.mkgmap.reader.osm.RestrictionRelation.addRestriction(RestrictionRelation.java:535) > at > uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:495) > at > uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:248) > at > uk.me.parabola.mkgmap.reader.osm.o5m.O5mBinMapDataSource.load(O5mBinMapDataSource.java:53) > at > uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:127) > at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:167) > at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:63) > at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:220) > at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:216) > at java.util.concurrent.FutureTask.run(FutureTask.java:262) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:744) > Time finished: Thu Apr 24 20:50:54 CEST 2014 > Total time taken: 31241ms > > > last entry in mkgmap.log.0 > 2014/04/24 20:50:53 Warnung (RoadNetwork): > /home/bernd/map_build/tiles/65020018.o5m: Turn restriction (no_u_turn) > http://www.openstreetmap.org/browse/relation/2254003 (at > http://www.openstreetmap.org/?mlat=48.119082&mlon=11.583557&zoom=17) the angle > of the from and to way don't match the restriction > > http://www.openstreetmap.org/relation/2254003 > > link to mapdata > http://files.mkgmap.org.uk/download/204/65020018.o5m > > Bernd > > _______________________________________________ > mkgmap-dev mailing list > mkgmap-dev(a)lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

2 3

Commit: r3230: partly revert r3228 & r3229
by svn commit 25 Apr '14

25 Apr '14

Version mkgmap-r3230 was committed by gerd on Fri, 25 Apr 2014 partly revert r3228 & r3229 Don't combine routable and non-routable lines in WrongAngleFixer. This causes more distorted lines at crossings with railways (tram)

1 0

oneway reverse patch
by Gerd Petermann 25 Apr '14

25 Apr '14

Hi all, did anybody try this patch attached to this post regarding reversed oneways? http://gis.19327.n5.nabble.com/mkgmap-ToDo-list-tp5803388p5803456.html If anybody is interested in this, I'll create a version that checks the style version file. Idea: If the version is 2 or higher, use the code in the patch, else not. Gerd

4 21

Problem with this restriction?
by Bernd Weigelt 24 Apr '14

24 Apr '14

Hi I got this error if i build a map around DE-Starnberg Time started: Thu Apr 24 20:50:22 CEST 2014 java.lang.AssertionError at uk.me.parabola.imgfmt.app.net.RouteRestriction.<init>(RouteRestriction.java:88) at uk.me.parabola.imgfmt.app.net.RoadNetwork.addRestriction(RoadNetwork.java:536) at uk.me.parabola.mkgmap.general.MapDetails.addRestriction(MapDetails.java:131) at uk.me.parabola.mkgmap.reader.osm.RestrictionRelation.addRestriction(RestrictionRelation.java:535) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:495) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:248) at uk.me.parabola.mkgmap.reader.osm.o5m.O5mBinMapDataSource.load(O5mBinMapDataSource.java:53) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:127) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:167) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:63) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:220) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:216) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) Time finished: Thu Apr 24 20:50:54 CEST 2014 Total time taken: 31241ms last entry in mkgmap.log.0 2014/04/24 20:50:53 Warnung (RoadNetwork): /home/bernd/map_build/tiles/65020018.o5m: Turn restriction (no_u_turn) http://www.openstreetmap.org/browse/relation/2254003 (at http://www.openstreetmap.org/?mlat=48.119082&mlon=11.583557&zoom=17) the angle of the from and to way don't match the restriction http://www.openstreetmap.org/relation/2254003 link to mapdata http://files.mkgmap.org.uk/download/204/65020018.o5m Bernd

2 2

Commit: r3229: fix possible assertion: don't make assumptions about direction of
by svn commit 24 Apr '14

24 Apr '14

Version mkgmap-r3229 was committed by gerd on Thu, 24 Apr 2014 fix possible assertion: don't make assumptions about direction of via way arcs. The arc is only reversed if the dest node = via node to which the restriction is added.

1 0