- mkgmap-dev - The mkgmap lists

Commit r4819: relationlabel.patch by Mike Baggaley:
by svn commit 29 Nov '21

29 Nov '21

Version mkgmap-r4819 was committed by gerd on Mon, 29 Nov 2021 relationlabel.patch by Mike Baggaley: "Allows a node tagged with a role of label or admin_centre to be still used if it has no name defined, rather than only if it matches the name on the relation. Also an improvement in the diagnostic message when a role label node is not being used." http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4819

1 0

Small problem with global index
by Gerd Petermann 28 Nov '21

28 Nov '21

Hi Ticker, while experimenting with the index and unicode I found a rather simple case that doesn't work as expected. I've attached a small example file and a patch for the default style. A map produced with these options and the patched style --style-file=d:\mkgmap\resources\styles\default --lower-case --preserve-element-order --code-page=1252 --gmapi --index --housenumbers --bounds=bounds.zip bad-search.osm produces a map that shows an error in the POI search. I search for name=abc123x in region Bayern and get the correct result list of three different restaurants named abc123x. I search for name=abc123x in region reg1 and get the correct result list of three different restaurants named abc123x. Now I also fill the search field city with Burgpreppach. with name=abc123x in city Burgpreppach and region Bayern the result is still correct. with name=abc123x in city Burgpreppach and region reg1 the result is not correct, it also lists the objects in region Bayern So far I found no correction for this. It also doesn't seem to depend on the lower-case option. Any idea? Gerd

3 30

Re: [mkgmap-dev] Failure to understand apply logic in relations - or failure in the logic
by Felix Hartmann 25 Nov '21

25 Nov '21

I think there is a bug in mkgmap. This line works as intended: set route_name_hiking1 = '${route_name_hiking1} + ${name|not-contained: + :route_name_hiking1}' | 'IWN ${name}' | '${route_name_hiking1}' | 'IWN' while this line in the relations file fails to work as expected - the part after the + is not added - or at least not visible (strangely the map size is pretty similar). set route_name_hiking1 = '${route_name_hiking1} + ${name}' | 'IWN ${name}' | '${route_name_hiking1}' | 'IWN' So only by including the not-contained filter ithe relations file is actually adding the names of the routes after each other - while they are not added without such a filter. On Wed, 24 Nov 2021 at 10:45, Felix Hartmann <extremecarver(a)gmail.com> wrote: > I will try your example to see where it goes wrong. Apply_once is about > forward and backward relations. It should not matter: > https://www.mkgmap.org.uk/pipermail/mkgmap-dev/2010q1/006268.html > > On Tue, 23 Nov 2021, 19:32 Mike Baggaley <mike(a)tvage.co.uk> wrote: > >> Hi Felix, >> >> >> >> This is what I have in my relations file for routes: >> >> >> >> type=route & state!=proposed & route~'.*bicycle.*' & network~'.*ncn.*' & >> ref~'\d*' { apply_once { set nationalbicycleroute=yes; set rn='$(rn) & ${ >> ref|not-contained: & :rn}' | '$(rn)' | '${ref}'; set nrn='$(nrn) & ${ >> ref|not-contained: & :nrn}' | '$(nrn)' | '${ref}'; } } >> >> type=route & state!=proposed & route~'.*bicycle.*' & network~'.*rcn.*' & >> ref~'\d*' { apply_once { set regionalbicycleroute=yes; set rn='$(rn) & ${ >> ref|not-contained: & :rn}' | '$(rn)' | '${ref}'; } } >> >> type=route & state!=proposed & (route~'.*foot.*' | route~'.*hiking.*') & >> network~'.*[nr]wn.*' & name~".*$.*$" { set name='${name|subst >> :"$.*$~>"}'} >> >> type=route & state!=proposed & (route~'.*foot.*' | route~'.*hiking.*') & >> network~'.*nwn.*' & name=* { apply_once { set nationalhikingroute=yes; >> set rn='$(rn) & ${name|not-contained: & :rn}' | '$(rn)' | '${name}'; set >> nrn='$(nrn) & ${name|not-contained: & :nrn}' | '$(nrn)' | '${name}'; set >> nwrn='$(nwrn) & ${name|not-contained: & :nwrn}' | '$(nwrn)' | '${name}'; >> } } >> >> type=route & state!=proposed & (route~'.*foot.*' | route~'.*hiking.*') & >> network~'.*rwn.*' & name=* { apply_once { set regionalhikingroute=yes; >> set rn='$(rn) & ${name|not-contained: & :rn}' | '$(rn)' | '${name}'; } } >> >> >> >> The most significant difference is that I have apply_once rather than >> apply. >> >> >> >> Hope this helps, >> >> Mike >> >> >> >> *From:* Felix Hartmann [mailto:extremecarver@gmail.com] >> *Sent:* 23 November 2021 13:31 >> *To:* Development list for mkgmap <mkgmap-dev(a)lists.mkgmap.org.uk> >> *Subject:* [mkgmap-dev] Failure to understand apply logic in relations - >> or failure in the logic >> >> >> >> route=hiking { apply { set route=hiking; set route_name = '${route_name} >> & ${name}' | '${name}'; add route_ref = '${ref}'; } } >> >> >> >> I would expect that this rule if several relations are matching one line, >> adds all names of route=hiking relations to the route_name variable >> separated by "&". However it is only adding the first found. >> >> >> >> Where is my mistake? >> >> >> >> -- >> >> Felix Hartman - Openmtbmap.org & VeloMap.org >> >> >> > -- Felix Hartman - Openmtbmap.org & VeloMap.org

1 2

Problem in splitter643
by valentin_k＠inbox.ru 25 Nov '21

25 Nov '21

Hi all. In the last few days I getting a problem in splitter643 with Geofafrik whole Asia extract. But splitter615 works without errors with the same osm source file. java -Xmx18g -jar splitter643.jar --geonames-file=./cities1000.zip --no-trim --max-nodes=1000000 --output-dir=../splitterTiles-ASIA --output=pbf ./asia-latest.o5m Exception in thread "main" java.lang.StackOverflowError at uk.me.parabola.splitter.solver.Tile.countInside(Tile.java:643) at uk.me.parabola.splitter.solver.Tile.getMinParts(Tile.java:634) at uk.me.parabola.splitter.solver.SplittableDensityArea$Solver.solve(SplittableDensityArea.java:1081) at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384) at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290) at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731) at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) at java.util.concurrent.ForkJoinTask.doInvoke(ForkJoinTask.java:401) at java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:734) at java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159) at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173) at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233) at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485) at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:650) at uk.me.parabola.splitter.solver.SplittableDensityArea.solveRectangularAreaParallel(SplittableDensityArea.java:595) at uk.me.parabola.splitter.solver.SplittableDensityArea.solveRectangularAreaParallel(SplittableDensityArea.java:627) ---the same string repeated more then one thousand times--- at uk.me.parabola.splitter.solver.SplittableDensityArea.solveRectangularAreaParallel(SplittableDensityArea.java:627) *** Error code 1 Stop. Link to the splitter643 log file: https://maptourist.org/tmp/asia-split-log.zip Link to the densities-out file: https://maptourist.org/tmp/densities-out.zip -- С уважением, Валентин Кудрявцев mailto:valentin_k@inbox.ru

2 2

search for cities on GPSMAP 66s/st and etrex 32x
by 7770 24 Nov '21

24 Nov '21

Hi. I am creating a map over parts of Europe, including Poland. The very same map img-file is loaded onto one GPSMAP 66st and one etrex 32x. When searching for cities (FIND -> cities) and searching for any city, town or villiage in the county of Małopolska (Lesser poland i think it is in English), such as Kraków, Tarnów, Wieliczka, etc. it does show up on the etrex 32x but not on GPSMAP 66st. It's not an error with the entire map, because if i search for "Krakow" (with ó or o does not matter) on the GPSMAP 66st, other Krakows (in other counties) are found, only the places in Małopolska are not found and only on the GPSMAP 66st unit. On the etrex 32x locations within the county are found. I get the feeling that thre is an issue with parts of the map and i wonder how i can find out more? Could it be that something is incorrect with the original map data for the county of Małoplska? Regards Karl

3 8

Failure to understand apply logic in relations - or failure in the logic
by Felix Hartmann 23 Nov '21

23 Nov '21

route=hiking { apply { set route=hiking; set route_name = '${route_name} & ${name}' | '${name}'; add route_ref = '${ref}'; } } I would expect that this rule if several relations are matching one line, adds all names of route=hiking relations to the route_name variable separated by "&". However it is only adding the first found. Where is my mistake? -- Felix Hartman - Openmtbmap.org & VeloMap.org

1 0

Some new (?) findings about global index structure MDR 3
by Gerd Petermann 23 Nov '21

23 Nov '21

Hi all, I think MDR 3 is just like MDR 4, see https://www.mkgmap.org.uk/websvn/listing.php?repname=display&rev=562 and https://www.mkgmap.org.uk/websvn/listing.php?repname=display&rev=563 In both sections we have the "unknown" byte with values from 0 .. 3 (all values spotted) and so far I can only guess that these are bit flags. MdrCheck should read this section to avoid error messages like ERROR: 49908: poi 29158 type was 41, expected 4100 Gerd

3 2

Experimental patches reg. Collator.strength and other index issues
by Gerd Petermann 22 Nov '21

22 Nov '21

Hi devs, with the attached patch for MdrCheck I see no error messages reg. wrong repeat flags for maps from Garmin. The patch for mkgmap shoud get us closer to what MapSource (or Garmin) does. - strength is changed from secondary to tertiary (maybe even string.equals can be used) - mdr11 records are also sorted and grouped by city id (need a new createSortKey() method to avoid the DoubleSortKey I've noticed that a gmapsupp index created by MapSource for a map which contains only POI but no highways has a different "extra value" in Mdr11, e.g. 0x51 instead of 0x91. Both have a Mdr17, so I guess we need some extra logic in Mdr11.getExtraValue(). MapSource writes a different I've started again to find out what the "unknown" byte in Mdr4 might mean. Unfortunately this section is not recalculated by MapSource, it simply seems to copy the value that is written by mkgmap. Gerd

1 0

New assertion, now with code-page=632 and Japan tile
by Carlos Dávila 19 Nov '21

19 Nov '21

The command below produces an assertion while compiling this tile <https://files.mkgmap.org.uk/download/526/31191025.o5m> from Japan. Process continues with remaining tiles and finishes without "Number of MapFailedExceptions: 1" as expected. This is with r4813, but I also tried with an old version of mkgmap with the same result. java -Xmx27G -ea -jar mkgmap.jar--code-page=632 31191025.o5m Mkgmap version 4813 Time started: Tue Nov 09 20:18:16 CET 2021 WARNING (global): Setting max-jobs to 8 Exception in thread "main" java.lang.AssertionError: found trailing 0 in chars at uk.me.parabola.imgfmt.app.labelenc.EncodedText.<init>(EncodedText.java:39) at uk.me.parabola.imgfmt.app.labelenc.AnyCharsetEncoder.encodeText(AnyCharsetEncoder.java:112) at uk.me.parabola.imgfmt.app.lbl.LBLFile.newLabel(LBLFile.java:132) at uk.me.parabola.imgfmt.app.lbl.PlacesFile.createPOI(PlacesFile.java:253) at uk.me.parabola.imgfmt.app.lbl.LBLFile.createPOI(LBLFile.java:172) at uk.me.parabola.mkgmap.build.MapBuilder.processPOIs(MapBuilder.java:670) at uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:325) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:114) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:62) at uk.me.parabola.mkgmap.main.Main.lambda$processFilename$1(Main.java:291) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829)

5 25

Commit r4818: mdrUnicode_v9a.patch by Ticker Berkin
by svn commit 19 Nov '21

19 Nov '21

Version mkgmap-r4818 was committed by gerd on Fri, 19 Nov 2021 mdrUnicode_v9a.patch by Ticker Berkin "While looking at the mdr output from Mapinstall and the differences in the street repeat flags, mainly where there are shield/road-ref entries, I realised my change to Sort.java for undefined sortOrder went to far and it disrupts this ordering for Unicode. Missing or 0 sortOrder (anything before the first "<" in sort/cp*.txt) means the character is ignored by the key sort and collator.compare(), so TERTIARY and EQUAL can give different answers. Attached is mdrUnicode_v9a.patch that generates a fake sortOrder only for rows where no sortOrders are defined, instead of for anything in Unicode with no/0 sortOrder. With this patch it becomes possible for Unicode to trigger the original problem again." http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4818

1 0