- mkgmap-dev - The mkgmap lists

construction as industry?
by nwillink 10 Feb '17

10 Feb '17

Hi I just realised that in the default polygon style construction, whether its residential or industrial , is always defined as industrial 0x0c. I understand the' logic' , in that there are many 'mobile' industries constructing residential or industrial buildings. In my city there are numerous large construction sites, all of them constructing residential housing. If I were unknown to the city and plan a route through an industrial area I would expect to find the following : a) industrial blocks / units / working businesses b) roads entering and crossing industrial areas safe from barriers,fencing,cones,mud-sweepers,grumpiness or foremen etc Personally I would provide a separate polygon , ie 0x27 perhaps Just a thought. Nick -- View this message in context: http://gis.19327.n8.nabble.com/construction-as-industry-tp5890573.html Sent from the Mkgmap Development mailing list archive at Nabble.com.

3 4

[Patch v1] sorted tags in echotags and log files
by Gerd Petermann 10 Feb '17

10 Feb '17

Hi all, while comparing results of the patches for the "unpaved problem" I noticed (again) that the echotags function has no specific order, this makes it difficult to compare different outputs of mkgmap. Attached is a patch which changes the way how tags are printed in logs or with the echotags style function. A binary is here: http://files.mkgmap.org.uk/download/333/mkgmap.jar The patch places the tags (key=val) in a SortedSet and uses the toString() method of that set. Effect: - tags are sorted by key - a blank is added as a separator Sample: old: Way 28312451 [highway=path,bicycle=yes,foot=yes,mkgmap:unpaved=1,mtb:scale=1,sac_scale=mountain_hiking,mkgmap:label:1=29,ref=29] new:Way 28312451 [bicycle=yes, foot=yes, highway=path, mkgmap:label:1=29, mkgmap:unpaved=1, mtb:scale=1, ref=29, sac_scale=mountain_hiking] If you analyse the logs with scripts, please check if the additional blanks will cause problems in your tool chain. The patch is quite large because the change allows to remove a lot of code. If I hear no complains, I'll commit this patch next Monday. Gerd

2 2

Split-Shape branch ready to merge?
by Gerd Petermann 10 Feb '17

10 Feb '17

Hi all, my work on a new code for type=multipolygon relation needs more changes than expected, esp. because the code is also used for the generation of precompiled sea and bounds and I don't want to create incompatible versions without a good reason. I think we can merge the branch to trunk as it is now. Expected effects: - nice speed improvements for option --order-by-decreasing-area - slightly deceased img size with and without option --order-by-decreasing-area It would be great if you could try the binary from the branch to make sure that it doesn't crash with your style and configuration. If I hear no complains I'll merge next Monday. Gerd

1 0

[Patch] unpaved roads
by Gerd Petermann 10 Feb '17

10 Feb '17

Hi all, I've created two different patches, both treat surface=cobblestone as paved. The major difference between v1 and v2 is in the handling of possibly conflicting attributes. For example, I found quite a lot of ways with highway=track, surface=paved , tracktype=3 in my hometown area. With v1 and also with unpatched default style this will be treated as unpaved, with v2 it is paved. The logic in v2 is that we first find surface tags which say "road is paved" and for those roads we will never set mkgmap:unpaved=1. Which one would you prefer? Gerd

6 17

Commit r3796: ExpressionReader.patch for preventing a crash when two
by svn commit 09 Feb '17

09 Feb '17

Version mkgmap-r3796 was committed by gerd on Thu, 09 Feb 2017 ExpressionReader.patch for preventing a crash when two regular expressions are used but the 'and' or 'or' separating them is missing, for example: landuse=meadow & (name~'[Mm]eadow' name~'[Ff]ield') {delete name;} The existing code crashes. - Mike Baggaley http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3796

1 0

Problems with -- gmapi (and possibly --gmapsupp also)
by Patrik Brunner 08 Feb '17

08 Feb '17

Gents, I've just noticed that the quite new option --gmapi does not work properly regarding overview maps: - I first build the img files where all is correct, overview maps are properly built and set at the different needed locations (*.tdb file, elsewhere ?) - running mkgmap with the option --gmapi (complete output shown below) causes that the overview maps are not anymore shown in BaseCamp I've tried different versions of options but I do not get the overview maps working with --gmapi. BTW: Something similar happens probably with --gmapsupp: there are now overview maps visible on the GPS itself. Here the call of mkgmap and its output: java -Xmx1536M -Dfile.encoding=UTF-8 -jar D:/fzk/develop/fzk-mde-garmin/Freizeitkarte-Entwicklung/tools/mkgmap/mkgmap.jar --max-jobs=2 --index --code-page=1252 --gmapi --license-file=Freizeitkarte_LUX.license --product-id=1 --family-id=6442 --family-name="Freizeitkarte_LUX" --series-name="Freizeitkarte_LUX" --description="Freizeitkarte_LUX (Release 17.02)" --product-version="6442" 6442*.img 6442.TYP --tdbfile --show-profiles=1 Time started: Sun Feb 05 16:10:10 CET 2017 Number of MapFailedExceptions: 0 Number of ExitExceptions: 0 Time finished: Sun Feb 05 16:10:12 CET 2017 Total time taken: 1858ms Am I doing something wrong or is this a 'defect' in the newly implemented gmapi option ? Thanks for helping Patrik

3 9

unit test fails in branch
by Gerd Petermann 08 Feb '17

08 Feb '17

Hi Ticker, please check: The unit test testCombiningSupps() in class GmapsuppTest fails: SCHWERWIEGEND (MapFailedException): (thrown in Area.split()) Area split shift align problems uk.me.parabola.imgfmt.MapFailedException: Area split shift align problems at uk.me.parabola.imgfmt.app.Area.split(Area.java:174) at uk.me.parabola.mkgmap.build.MapArea.split(MapArea.java:206) at uk.me.parabola.mkgmap.build.MapSplitter.splitMaxSize(MapSplitter.java:234) at uk.me.parabola.mkgmap.build.MapSplitter.split(MapSplitter.java:103) at uk.me.parabola.mkgmap.build.MapBuilder.makeMapAreas(MapBuilder.java:698) at uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:234) at uk.me.parabola.mkgmap.combiners.OverviewBuilder.writeOverviewMap(OverviewBuilder.java:184) at uk.me.parabola.mkgmap.combiners.OverviewBuilder.onFinish(OverviewBuilder.java:91) at uk.me.parabola.mkgmap.main.Main.endOptions(Main.java:620) at uk.me.parabola.mkgmap.CommandArgsReader.readArgs(CommandArgsReader.java:128) at uk.me.parabola.mkgmap.main.Main.mainStart(Main.java:138) at uk.me.parabola.mkgmap.main.Main.mainNoSystemExit(Main.java:105) at func.files.GmapsuppTest.testCombiningSupps(GmapsuppTest.java:129) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:678) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192) Number of ExitExceptions: 1

2 5

is_in filter
by Carlos Dávila 08 Feb '17

08 Feb '17

One matter that has been discussed several times on this list is the need to remove buildings. While removing buildings is becoming absolutely necessary in many cities, due to massive building imports, it may be quite convenient to keep them at rural or low densely populated areas. Would it be possible to have a filter to know if a building is inside/outside an area tagged landuse=residential, so that a different rendering may be applied. Ideally area size could be also evaluated. Perhaps some logic currently existing in mkgmap, used to assign addresses from bounds, could be reused.

6 17

r3784 produces large img files than r3773
by Gerd Petermann 08 Feb '17

08 Feb '17

Hi Ticker, I compared the sizes for a map of spain with and without option --order-by-decreasing-area, I always see larger files with r3784. With r3777 and r3778 the files are typically a bit smaller than with r3773. Is there a good reason for that ? Gerd

3 16

Commit r3792: make sure that pbf header contains bbox before trying to read it
by svn commit 07 Feb '17

07 Feb '17

Version mkgmap-r3792 was committed by gerd on Tue, 07 Feb 2017 make sure that pbf header contains bbox before trying to read it http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3792

1 0