May 2021 - mkgmap-dev - The mkgmap lists

java.lang.NumberFormatException: For input string: ""
by Felix Hartmann 15 May '21

15 May '21

This error happens on conoturlines generation - any ideas? Should I upload the files for debug? I first thought phyghtmap may have produced data with an empty string and on the ft to m conversion this error appears. However I kinda excluded that from happening by making sure only lines with a number are used & ( ele>0 | ele=0 | ele<0 ) Happens on a couple of countries worldwide and seems to be style related - but the same style works on most countries data so the style itself is not broken. SEVERE (global): Unexpected error java.lang.NumberFormatException: For input string: "" at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:68) at java.base/java.lang.Integer.parseInt(Integer.java:662) at java.base/java.lang.Integer.parseInt(Integer.java:770) at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195) at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578) at uk.me.parabola.mkgmap.build.MapBuilder.parseDemDists(MapBuilder.java:280) at uk.me.parabola.mkgmap.build.MapBuilder.config(MapBuilder.java:275) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:113) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:70) at uk.me.parabola.mkgmap.main.Main.lambda$processFilename$1(Main.java:290) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) at java.base/java.lang.Thread.run(Thread.java:832) SEVERE (global): Exiting due to unexpected error Number of ExitExceptions: 1 Time finished: Sat May 15 14:27:05 CEST 2021 -- Felix Hartman - Openmtbmap.org & VeloMap.org

2 2

Commit 4710
by Felix Hartmann 15 May '21

15 May '21

fix error in LineMergeFilter reg. lines with direction The line merger should not merge lines if one has the direction flag set and the other has not. Problem exists also in trunk. Hmm fixing this stopped all the nice size optimization. Map size got much bigger again. I did not find any place where this mattered. Routing was also not affected badly. Maybe I did not look good enough? I do not see why not to merge them. As long as it`s not the opposite it seems fine... Map size increase/decrease is around 1.5% with my style. So thats quite a big difference. -- Felix Hartman - Openmtbmap.org & VeloMap.org

4 44

Commit r4717: cleanup, no change in output, maybe minimal performance improvement
by svn commit 15 May '21

15 May '21

Version mkgmap-r4717 was committed by gerd on Sat, 15 May 2021 cleanup, no change in output, maybe minimal performance improvement - remove debug code - remove field index in ConvertedWay, is no longer needed to produce stable results in RoadMerger http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4717

1 0

TYP file UseOrientation
by Gerd Petermann 14 May '21

14 May '21

Hi all, I just noticed the UseOrientation=Y/N setting in TYP files. Is this related to the direction flag of the line in IMG? Gerd

4 3

Commit r4714: improve code in containsAction
by svn commit 13 May '21

13 May '21

Version mkgmap-r4714 was committed by gerd on Thu, 13 May 2021 improve code in containsAction - don't check finalizeRule in ExpressionRule - check single actions instead of combining them first (to avoid possible matches created by combining) http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4714

1 0

Commit r4713: fix check which detects if lines rules add or set special tag mkgmap:has-direction=true.
by svn commit 13 May '21

13 May '21

Version mkgmap-r4713 was committed by gerd on Thu, 13 May 2021 fix check which detects if lines rules add or set special tag mkgmap:has-direction=true. Old code only found the case that the style checked if a line has the tag, as in mkgmap:has-direction=true {echotags "direction"} Don't invest too much time in this, maybe it will be reverted, the tag might not be the best way to pass the needed information. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4713

1 0

Commit r4712: fix error introduced with r4549: logged action rules did not contain target
by svn commit 13 May '21

13 May '21

Version mkgmap-r4712 was committed by gerd on Thu, 13 May 2021 fix error introduced with r4549: logged action rules did not contain target e.g. instead of "[set mkgmap:country=${mkgmap:admin_level2};]" only "[set ]" was logged Probably only visible when logging or debugging, else this would have caused massive trouble. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4712

1 0

Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch)
by Mike Baggaley 13 May '21

13 May '21

That sounds really promising Gerd. Does this only apply to roads, or can it also handle other lines? I would like to also reduce multiple railway lines to a single line at lower resolutions. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 12 May 2021 16:56 To: Development list for mkgmap <mkgmap-dev(a)lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Hi Felix, see https://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4711 I think I see a way to really improve rendering of dual carriage ways. Needs some more experimenting. At the moment only size is reduced in RemoveObsoletePointsFilter, but the new code seems to be able detect dual carriage ways. Work in progress... Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces(a)lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver(a)gmail.com> Gesendet: Mittwoch, 12. Mai 2021 16:58 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Ah true, if the dp filter changes differently it would not be good. I think the key could include the max level for no direction change. Just on add the smaller resolution would need to be considered. However with level 0 dp filter being invisible in changes anyhow, it's really only important for level 1 or higher if direction for continue ways can be merged or not. Also oneway street could be reversed at level 1 or higher. On Wed, 12 May 2021, 22:37 Gerd Petermann <gpetermann_muenchen(a)hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, I don't understand why you think that the direction is only important at level 0. Doesn't that depend on the TYP file and the style? Still, you are probably right that mkgmap could ignore the direction if that doesn't produce visible differences. We just have to find out if there is a fixed limit or if we need more options or special tags. What I try to avoid is the situation that the road is merged and therefore possibly reduced to a straight line while overlay lines are not merged and possibly zig-zagging along the road. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces(a)lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk>> im Auftrag von Felix Hartmann <extremecarver(a)gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Mittwoch, 12. Mai 2021 15:08 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Actually besides rivers all lines can be reversed from level1 onwards - Is that possible or can ways not be reversed if the direction may not be changed in level 0? Also it would be good if adding {add mkgmap:has-direction=true} is only relevant for future lines if continue with_actions is used, but not if continue is used. E.g. if a road has cycleway = lane:left I display it only at resolution 24, however the road itself can be reversed. Just not the cycleway line that is a second line to the left side of the road. The road also is later in my style vs the cycleway. That way maybe some additional lines can be reversed. In general for Austria or Germany this gives pretty nice improvements in map size. For less developed countries the differences are smaller... On Tue, 11 May 2021 at 19:21, Gerd Petermann <gpetermann_muenchen(a)hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> > wrote: Hi Mike, it is off by default because it will cause trouble with some styles / TYP files which rely on the direction but don't set that the new special tag (yet). Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces(a)lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces(a)lists.mkgmap.org.uk>>> im Auftrag von Mike Baggaley <mike(a)tvage.co.uk<mailto:mike@tvage.co.uk><mailto:mike@tvage.co.uk<mailto:mi ke(a)tvage.co.uk>>> Gesendet: Dienstag, 11. Mai 2021 13:15 An: mkgmap-dev(a)lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Hi Gerd, I may be misunderstanding this, but the explanation of when it is enabled seems illogical. It seems to me that reversing should be the default except on ways that have mkgmap:has-direction=true unless a switch is given to disable it. Or it could be off by default and a switch enables it, except for ways that have mkgmap:has-direction=true. Cheers, Mike -----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk<mailto:svn@mkgmap.org.uk><mailto:svn@mkgmap.org.uk <mailto:svn@mkgmap.org.uk>>] Sent: 11 May 2021 11:22 To: mkgmap-svn(a)lists.mkgmap.org.uk<mailto:mkgmap-svn@lists.mkgmap.org.uk><mailto :mkgmap-svn@lists.mkgmap.org.uk<mailto:mkgmap-svn@lists.mkgmap.org.uk>>; mkgmap-dev(a)lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> Subject: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021 improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged. The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703 _______________________________________________ mkgmap-dev mailing list mkgmap-dev(a)lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev(a)lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org _______________________________________________ mkgmap-dev mailing list mkgmap-dev(a)lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

3 2

MDR building out-of-memory
by Ticker Berkin 12 May '21

12 May '21

Hi Gerd Since downloading loading britain-and-ireland-latest.osm.pbf I had been unable to build a gmapsupp because of running out of heap (my hardware is 32 bit, -Xmx1540M is largest value allowed) My problem is mainly because I have 1731146 cities (along with 1046096 streets) Looking at Mdr5 processing, I've changed it in 3 ways to improve memory usage and garbage collection. 1/ use trimToSize() after all the cities are loaded from the individual tile .img. I presume that the growth factor gradually increases as it runs out of allocated array space. I had to change the declaration from List<Mdr5Record> to ArrayList<Mdr5Record> to allow this, but I can't see any problem in this. 2/ Move the main part of preWriteImpl into its own method so the first sortKeys ArrayList and Sort can be freed before calcMdr20/1/2() each create another massive SortKeys and Sort. 3/ Move the scope of mdr20s to a class variable. This is referenced by all the Mdr5Records and the scope of where it was declared before seemed to to cause the garbage collector major problems - it churned for 5 mins using all the processors before running out of memory. After moving it, the whole of mdr is built in a couple of mins with cpu usage mostly < 125%. Ticker

2 11

Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch)
by svn commit 12 May '21

12 May '21

Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021 improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged. The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703

4 7