February 2017 - mkgmap-dev - The mkgmap lists

Is smoothness=bad unpaved?
by lig fietser 07 Feb '17

07 Feb '17

Hi list, On the Garmin OSM forum there is a discussion started whether we should consider smoothness=bad as unpaved. In the default rules it is treated as unpaved. What do you think? Should we adapt the rules and skip 'bad' from the unpaved list? https://forum.openstreetmap.org/viewtopic.php?pid=628555#p628555

4 7

Commit r3786: clean up code for -gmapi option: add static modifier were appropriate, no functional change
by svn commit 06 Feb '17

06 Feb '17

Version mkgmap-r3786 was committed by gerd on Mon, 06 Feb 2017 clean up code for -gmapi option: add static modifier were appropriate, no functional change http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3786

1 0

patch for style file reader crash
by Mike Baggaley 06 Feb '17

06 Feb '17

Hi Gerd, please find attached a small patch for preventing a crash when two regular expressions are used but the 'and' or 'or' separating them is missing, for example: landuse=meadow & (name~'[Mm]eadow' name~'[Ff]ield') {delete name;} The existing code crashes with the following trace: java.lang.AssertionError at uk.me.parabola.mkgmap.osmstyle.eval.RegexOp.setSecond(RegexOp.java:49) at uk.me.parabola.mkgmap.osmstyle.eval.ExpressionReader.runOp(ExpressionReader. java:180) at uk.me.parabola.mkgmap.osmstyle.eval.ExpressionReader.saveOp(ExpressionReader .java:143) at uk.me.parabola.mkgmap.osmstyle.eval.ExpressionReader.readConditions(Expressi onReader.java:62) at uk.me.parabola.mkgmap.osmstyle.RuleFileReader.loadFile(RuleFileReader.java:1 15) at uk.me.parabola.mkgmap.osmstyle.RuleFileReader.load(RuleFileReader.java:86) at uk.me.parabola.mkgmap.osmstyle.StyleImpl.readRules(StyleImpl.java:302) at uk.me.parabola.mkgmap.osmstyle.StyleImpl.<init>(StyleImpl.java:160) at uk.me.parabola.mkgmap.osmstyle.StyleImpl.readStyle(StyleImpl.java:554) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.createConverter(OsmMapData Source.java:289) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.setupHandler(OsmMapDataSou rce.java:187) at uk.me.parabola.mkgmap.reader.osm.o5m.O5mBinMapDataSource.load(O5mBinMapDataS ource.java:43) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java :138) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:265) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:261) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) With the patch, I get an error message as follows: Error in style: Error: (points:76): Invalid arguments to REGEX: FUNCTION ($[Mm]eadow) and REGEX (($name~'[Ff]ield')) (Actually I get the message 4 times, but that is a minor issue.) I have moved 3 lines of code from before various syntax checks to after the checks. Please try the patch and commit if happy. Thanks, Mike

2 1

Is height: filter working as described?
by Carlos Dávila 04 Feb '17

04 Feb '17

According to style manual the rule natural=peak {name '${name|def:}${ele|height:m=>ft|def:}' } [0x6616 resolution 24] from default style should convert ele values from meters to feet, assuming ele is in meters, but this is what map shows for the following ele values: ele=500, map: ", 500 m" ele=500m, map: ", 500 m" ele=500ft, map: ", 152 m" So it seems to be doing right the opposite, converting from feet to meters. Also, with m=>ft rule, map should show ft units, not m. If I invert the rule from m=>ft to ft=>m this is what happens: ele=500, map: ", 46 m" ele=500m, map: ", 152 m" ele=500ft, map: ", 46 m" Now it seems when values are in feet conversion factor is applied twice. It seems when height: is used it always does a ft to m conversion first and then it applies what is specified in the rule. For the same examples, conv: filter gives the right values.

5 24

Commit r3785: height_v2.patch : Make sure that target unit is feet
by svn commit 04 Feb '17

04 Feb '17

Version mkgmap-r3785 was committed by gerd on Sat, 04 Feb 2017 height_v2.patch : Make sure that target unit is feet http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3785

1 0

Error in branch
by Gerd Petermann 03 Feb '17

03 Feb '17

Hi Ticket, I found another problem in the branch which probably was introduced with r3779 and still exists with r3782: java.lang.AssertionError at uk.me.parabola.imgfmt.app.net.RoadIndex.write(RoadIndex.java:45) at uk.me.parabola.imgfmt.app.net.RoadDef.writeLevelDivs(RoadDef.java:361) at uk.me.parabola.imgfmt.app.net.RoadDef.writeNet1(RoadDef.java:230) at uk.me.parabola.imgfmt.app.net.NETFile.write(NETFile.java:66) at uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:263) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:107) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:69) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:265) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:261) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) See http://files.mkgmap.org.uk/download/331/63240003.osm.pbf Needed options to reproduce the error with r3782: java -ea -jar mkgmap.jar --link-pois-to-ways --route 63240003.osm.pbf For r3779 these options will not create a crash, but with options --bounds=f:\osm\bounds.zip --route --link-pois-to-ways I see it, too. My bounds.zip is quite new, it contains version.txt wih content 20170103. Gerd

3 4

Re: [mkgmap-dev] Problems with r3781
by Gerd Petermann 02 Feb '17

02 Feb '17

Hi Ticker, okay, I wait for yor results. Besides that I think the de-duplication should better be done in StyledConverter. Gerd ________________________________________ Von: Ticker Berkin <RIBerkin(a)jagIT.co.uk> Gesendet: Donnerstag, 2. Februar 2017 11:36:31 An: GPetermann_muenchen(a)hotmail.com Betreff: Re: [mkgmap-dev] Problems with r3781 Hi Gerd Having electrical problem at the moment so don't have correct computer/sources/email system with correct from email for mkgmap dev list etc, so sending direct to you. Please reply to list. 1/ with the last patch, I changed the behaviour slightly of when lines and shape (unless OrderBy...) get shifted into their own MapArea/subDivision. When this happens, shapeMergeFilter won't merge them. I plan to think about this a bit more. 2/ Behaviour of when highPrecEqual coords get set to the same coord has changed slightly during shape splitting operations. Old logic tended to save a hash of all points, do the operation, then look up each point in the list and use that. New logic only does something similar for points exactly on the boundary (normally created by the split). Ticker -----Original Message----- From: Gerd Petermann Sent: Thursday, February 02, 2017 8:45 AM To: Development list for mkgmap Subject: Re: [mkgmap-dev] Problems with r3781 Hi Ticker, I did some more tests with r3782, also with other styles like that for openfietsmap.nl (by Minko aka ligfietser) http://mijndev.openstreetmap.nl/%7Eligfietser/openfietsmap/Scripts/Styles/ I've compared the results with trunk version r3773 and noticed that the branch produces fewer messages from ShapeMergeFilter like "ignoring duplicate shape with id 144075839 at http://www.openstreetmap.org/?mlat=54.606792&mlon=8.374727&zoom=17 with type 0x53 for resolution 22" and in fact the branch writes those duplicated shapes two times while trunk doesn't. The style adds two equal 0x53 polygons for the way 144075839 , one because it has natural=beach, one because it has surface=sand. The trunk version seems to filter those duplicated shapes while the branch doesn't. The result is an increased img size for this style, while the branch typically creates smaller files for the default style. Do you see why the this happens? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces(a)lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap(a)jagit.co.uk> Gesendet: Mittwoch, 1. Februar 2017 17:47:59 An: mkgmap-dev(a)lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Problems with r3781 Hi Gerd Fixed this and committed - I think the problem was always there but excess MapArea splitting made it very unlikely to happen. There is still a little bit of old logic that I'm not sure about, but I've removed for now which is safe. Some time I'll think if something similar needs to be put back Ticker On Wed, 2017-02-01 at 11:32 +0000, Ticker Berkin wrote: > Hi Gerd > > Sorry - I wasn't paying attention and missed the vital bit of your > mail: northwest-territories-latest.osm.pbf > > Will try with the correct file! > > Ticker > > > On Wed, 2017-02-01 at 10:17 +0000, Ticker Berkin wrote: > > Hi Gerd > > > > Using your new areas.list file and > > Splitter version 573 compiled 2017-01-12T17:28:57+0000 > > on: > > 3094949146 Jan 13 10:00 germany-latest.osm.pbf > > > > all the output files osm.pbf files are only 106 bytes long! > > > > No obvious errors from the splitter. > > > > I'll investigate further > > > > Ticker > > > > On Wed, 2017-02-01 at 09:17 +0000, Ticker Berkin wrote: > > > Hi Gerd > > > > > > I'l check this out > > > > > > Ticker > > > > > > On Wed, 2017-02-01 at 09:11 +0000, Gerd Petermann wrote: > > > > Hi Ticker, > > > > > > > > I see some error messages when creating a map for northwest > > > > -territories-latest.osm.pbf: > > > > SCHW: uk.me.parabola.imgfmt.app.trergn.Polyline > > > > e:\osm_out_work\northwest > > > > -territories\20170123_113606\63240008.osm.pbf: Problem writing > > > > line > > > > (class uk.me.parabola.imgfmt.app.trergn.Polyline) of type 0x1d > > > > containing 3 points and starting at > > > > http://www.openstreetmap.org/?mlat=58.143592&mlon=-110.006011&z > > > > oo > > > > m= > > > > 17 > > > > SCHW: uk.me.parabola.imgfmt.app.trergn.Polyline > > > > e:\osm_out_work\northwest > > > > -territories\20170123_113606\63240008.osm.pbf: Subdivision > > > > shift > > > > is > > > > 0 and its centre is at > > > > http://www.openstreetmap.org/?mlat=58.538117&mlon=-110.791583&z > > > > oo > > > > m= > > > > 17 > > > > SCHW: uk.me.parabola.imgfmt.app.trergn.Polyline > > > > e:\osm_out_work\northwest > > > > -territories\20170123_113606\63240008.osm.pbf: deltaLong = > > > > 36610 > > > > SCHW: uk.me.parabola.imgfmt.app.trergn.Polyline > > > > e:\osm_out_work\northwest > > > > -territories\20170123_113606\63240008.osm.pbf: Problem writing > > > > line > > > > (class uk.me.parabola.imgfmt.app.trergn.Polyline) of type 0x1d > > > > containing 3 points and starting at > > > > http://www.openstreetmap.org/?mlat=58.143592&mlon=-110.006011&z > > > > oo > > > > m= > > > > 17 > > > > SCHW: uk.me.parabola.imgfmt.app.trergn.Polyline > > > > e:\osm_out_work\northwest > > > > -territories\20170123_113606\63240008.osm.pbf: Subdivision > > > > shift > > > > is > > > > 0 and its centre is at > > > > http://www.openstreetmap.org/?mlat=58.538117&mlon=-110.791583&z > > > > oo > > > > m= > > > > 17 > > > > ... > > > > > > > > You should be able to reproduce it with this command: > > > > java -ea -jar d:\mkgmap\dist\mkgmap.jar 63240008.osm.pbf > > > > using the attached split file. > > > > > > > > Gerd > > > > _______________________________________________ > > > > mkgmap-dev mailing list > > > > mkgmap-dev(a)lists.mkgmap.org.uk > > > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > > > _______________________________________________ > > > mkgmap-dev mailing list > > > mkgmap-dev(a)lists.mkgmap.org.uk > _______________________________________________ > mkgmap-dev mailing list > mkgmap-dev(a)lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev(a)lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev(a)lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

1 0

Problems with r3781
by Gerd Petermann 02 Feb '17

02 Feb '17

Hi Ticker, I see some error messages when creating a map for northwest-territories-latest.osm.pbf: SCHW: uk.me.parabola.imgfmt.app.trergn.Polyline e:\osm_out_work\northwest-territories\20170123_113606\63240008.osm.pbf: Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polyline) of type 0x1d containing 3 points and starting at http://www.openstreetmap.org/?mlat=58.143592&mlon=-110.006011&zoom=17 SCHW: uk.me.parabola.imgfmt.app.trergn.Polyline e:\osm_out_work\northwest-territories\20170123_113606\63240008.osm.pbf: Subdivision shift is 0 and its centre is at http://www.openstreetmap.org/?mlat=58.538117&mlon=-110.791583&zoom=17 SCHW: uk.me.parabola.imgfmt.app.trergn.Polyline e:\osm_out_work\northwest-territories\20170123_113606\63240008.osm.pbf: deltaLong = 36610 SCHW: uk.me.parabola.imgfmt.app.trergn.Polyline e:\osm_out_work\northwest-territories\20170123_113606\63240008.osm.pbf: Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polyline) of type 0x1d containing 3 points and starting at http://www.openstreetmap.org/?mlat=58.143592&mlon=-110.006011&zoom=17 SCHW: uk.me.parabola.imgfmt.app.trergn.Polyline e:\osm_out_work\northwest-territories\20170123_113606\63240008.osm.pbf: Subdivision shift is 0 and its centre is at http://www.openstreetmap.org/?mlat=58.538117&mlon=-110.791583&zoom=17 ... You should be able to reproduce it with this command: java -ea -jar d:\mkgmap\dist\mkgmap.jar 63240008.osm.pbf using the attached split file. Gerd

3 7

Unable to build splitter
by Paul 01 Feb '17

01 Feb '17

I'm not sure if this is a splitter problem or OS problem but I thought I'd ask here first as I think that this problem is likely to have started with r570 (http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2017q1/025847.html) The following has been tried on both openSuSE 13.2 and 42.2 I checked out the latest splitter into an empty directory, ran "ant dist" and received an error regarding junit.jar. I then installed ant-junit and now when running "ant dist" I get resolve-test: compile.tests: [javac] Compiling 13 source files to /home/bos/Maps/tile-splitter/splitter/build/test-classes run.tests: [junit] Running uk.me.parabola.splitter.AreaSetTest [junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.042 sec [junit] TEST uk.me.parabola.splitter.AreaSetTest FAILED [junit] Running uk.me.parabola.splitter.ConvertTest [junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec [junit] TEST uk.me.parabola.splitter.ConvertTest FAILED [junit] Running uk.me.parabola.splitter.RoundingTest [junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec [junit] TEST uk.me.parabola.splitter.RoundingTest FAILED [junit] Running uk.me.parabola.splitter.geo.CityFinderTest [junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec [junit] TEST uk.me.parabola.splitter.geo.CityFinderTest FAILED [junit] Running uk.me.parabola.splitter.tools.CustomCollectionsTest [junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec [junit] TEST uk.me.parabola.splitter.tools.CustomCollectionsTest FAILED [junit] Running uk.me.parabola.splitter.tools.SparseBitSetTest [junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec [junit] TEST uk.me.parabola.splitter.tools.SparseBitSetTest FAILED [junit] Tests FAILED [junitreport] Processing /home/bos/Maps/tile-splitter/splitter/tmp/TESTS-TestSuites.xml to /tmp/null380785018 [junitreport] Loading stylesheet jar:file:/usr/share/java/ant/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl [junitreport] Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. [junitreport] Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. [junitreport] Transform time: 303ms [junitreport] Deleting: /tmp/null380785018 BUILD FAILED /home/bos/Maps/tile-splitter/splitter/build.xml:261: Test failed. See test-reports/index.html Total time: 5 seconds If I then look in test-reports/index.html and expand the failures I get the following No tests found in uk.me.parabola.splitter.AreaSetTest junit.framework.AssertionFailedError: No tests found in uk.me.parabola.splitter.AreaSetTest If you need more information please ask Thanks Paul

4 10

WG: Please help
by Gerd Petermann 01 Feb '17

01 Feb '17

Hi Ticker, I tried to reach you with a PM but that was returned, so I try again via list... Gerd ________________________________________ Von: Gerd Petermann Gesendet: Mittwoch, 1. Februar 2017 16:09 An: Ticker Berkin Betreff: Please help Hi Ticker, I try to understand why ShapeSplitter complains about a polygon created by my new algo. Attached is a patch and an input file. Command: java -Dlog.config=mkgmap_log.props -ea -jar dist\mkgmap.jar f:\osm\test.osm.pbf My mkgmap_log.props contains .level=WARNING and I see this warning: WARN: uk.me.parabola.util.ShapeSplitter f:\osm\test.osm.pbf: Direction of shape and hole conflict; probably self-intersecting polygon this: fp=146086642 lp=146173971 area=19324813903 #=134 http://www.openstreetmap.org/?mlat=48.975820&mlon=13.355620&zoom=17 http://www.openstreetmap.org/?mlat=48.988628&mlon=13.389160&zoom=17 other: fp=146153055 lp=146161739 area=22313626 #=6 http://www.openstreetmap.org/?mlat=49.002597&mlon=13.353453&zoom=17 http://www.openstreetmap.org/?mlat=49.003250&mlon=13.352696&zoom=17 I don't see what's wrong here. Gerd

2 4