November 2014 - mkgmap-dev - The mkgmap lists

[Patch v2] style filter country-ISO
by Gerd Petermann 28 Nov '14

28 Nov '14

Attached is v2 of the patch, now based on r3357, as v1 causes a conflict. I've also added a unit test and a bit of documentation. If I hear no complains I'll commit this on Monday. Gerd

1 0

Commit: r3357: Allow a space between the pipe symbol and the filter name.
by svn commit 28 Nov '14

28 Nov '14

Version mkgmap-r3357 was committed by steve on Fri, 28 Nov 2014 Allow a space between the pipe symbol and the filter name. In the unquoted syntax allow spaces '${rcnname | substring:1:5}' Also added an error when the filter name is not recognised, instead of silently ignoring it.

1 0

Manage drive-on-left/drive-on-right in resources\LocatorConfig.xml
by Gerd Petermann 28 Nov '14

28 Nov '14

Hi all, this point is on the to do list, but I am not sure what the target is. I guess it should replace the two options drive-on-right and drive-on-left. ("dor","dol") A possible implementation looks like this: 1) add property driveOnLeft="true" to the appropriate countries in LocatorConfig.xml 2) add methods to lookup the property for a given roundabout 3) count the number of "dol" and "dor" roundabouts 4) If neither the --drive-on-left option or --drive-on-right option is set, use the counters: if the "dol" number is larger than the "dor" number, set the "dol" flag in the NOD header to 1. So far so easy. I guess in most usage cases one of the counters is 0 and the other is not, so that would work fine. Open questions: 1) What should happen for those tiles containing both "dol" and "dor" roundabouts? 2) What should happen if the --drive-on-left option is given and the tile contains only "dor" roundabouts (or vice-versa) ? Should we ignore the option given by the user and print a corresponding warning? 3) We have the --check-roundabouts option which also might set the flag in the NOD header if the user doesn't specify --drive-on-left or --drive-on-right. The current implementation simply uses the direction of first roundabout (clockwise or not) to decide which driving side is to be used and it reverses the direction of all following roundabouts which don't match the direction of the first one. I assume this should be changed so that we use the above counters as well? @Steve: The data in the LocatorConfig.xml seems to be only used in combination with the --bounds option, without precompiled bounds the default style will not set mkgmap:country which is used to get the data from the LocatorConfig.xml. I did expect that an option like --country-name or --country-abbr could be used to set a default, and the code really passes the values to a method in Locator called setDefaultCountry(), but that method is only adding /overwriting a HashMap of country-name+iso-code which is filled from LocatorConfig.xml . Is that intended?

6 16

[Patch v1] style filter country-ISO
by Gerd Petermann 28 Nov '14

28 Nov '14

Hi all, see also http://gis.19327.n5.nabble.com/useless-rules-in-default-style-inc-address-t… attached is a patch that implements a style filter to convert country names to the 3 character ISO code which is used in e.g. the address rules. It also changes two rules in inc/address to use this filter and adds a simple check to ValueBuilder to report the case when a filter is expected but not recognized because of parser or syntax errors like in the case reported here: http://gis.19327.n5.nabble.com/Substring-returns-full-string-tp5825603.html Gerd

3 2

useless rules in default style inc/address
by Gerd Petermann 28 Nov '14

28 Nov '14

Hi all, the default style file inc/address starts with these three rules: # first set the country code mkgmap:country!=* & mkgmap:admin_level2=* { set mkgmap:country='${mkgmap:admin_level2}' } mkgmap:country!=* & addr:country=* { set mkgmap:country='${addr:country}' } mkgmap:country!=* & is_in:country=* { set mkgmap:country='${is_in:country}' } I found no code in the mkgmap java sources that sets mkgmap:country, so the first rule will always set mkgmap:country unless one manipulates the OSM data. The following rules evaluate mkgmap:country and expect the ISO 1366 code with 3 characters, e.g. DEU for Germany. The wiki for tag addr:country says that it should contain the 2 character ISO code, e.g. DE for Germany. The is_in:country tag contains the country name, not the iso code. I think we should remove the two useless rules unless someone finds a working alternative. Gerd

4 6

[Patch v1] use --country-name / --country-abbr to set mkgmap:admin_level2
by Gerd Petermann 27 Nov '14

27 Nov '14

Hi all, attached is a small patch which allows to use the options country-name or country-abbr to set a default value for the tag mkgmap:country which is important for the address rules. This should help those users who live in a big country like the USA and try to create a map without downloading the precompiled boundaries and instead use the boundaries contained in the OSM file for e.g. one state. The patch works like this: If the LocationHook did not set mkgmap:admin_level2 : if --country-abbr is given, use the value to set mkgmap:admin_level2 else if --country-name is given, get the ISO name from LocatorConfig.xml and set mkgmap:admin_level2 with that. Of course this happens before style evaluation. Gerd

1 0

Commit: r3356: commit styleStats-v5.patch + small change to make unit tests work
by svn commit 27 Nov '14

27 Nov '14

Version mkgmap-r3356 was committed by gerd on Thu, 27 Nov 2014 commit styleStats-v5.patch + small change to make unit tests work

1 0

Non-rectangular tiles
by Steve Ratcliffe 27 Nov '14

27 Nov '14

Hi I was meaning to write a message about this for a while and since the thread for drive-on-left/right has brought this up already today and since it is a mkgmap birthday (8 years!) this might be a good time to set the ball rolling. Currently we use rectangular tiles, but it is perfectly possible to have arbitrarily shaped tiles - in particular tiles can be shaped to exactly follow a country border or be conveniently split by straight lines between countries separated by sea. This means that every rule could be customised for each country. This is probably the biggest feature that we don't have that we can achieve with what we know about the format. I am sure that it can be done, but it is a large task and will need more than one person working on it. If there is any interest I shall outline my thoughts tomorrow. ..Steve

5 4

evaluation of boolean options
by Gerd Petermann 27 Nov '14

27 Nov '14

Hi programmers, the evaluation of boolean options in mkgmap is a bit confusing. It is possible to specify e.g. --drive-on-left or --drive-on-left=true or --drive-on-left=false or --drive-on-left=any-value In the current code both all have the same effect, because the evaluation is done like this: driveOnLeft = props.getProperty("drive-on-left") != null; On the other hand, --keep-going and --keep-going=false do not have the same effect, and that is true for most boolean options, because typically we use this kind of evaluation: linkPOIsToWays = props.getProperty("link-pois-to-ways", false); I think we should always use the latter method. Do you agree? Gerd

3 3

[Patch v2] manage drive-on-left/drive-on-right in resources\LocatorConfig.xml
by Gerd Petermann 26 Nov '14

26 Nov '14

Hi all, only change to v1: if neither drive-on-left nor drive-on-right is set by user and the number of "dol" roundabouts is smaller than the number of "dor" ones: set drive-on-right so that check-roundabouts doesn't set drive-on-left flag in NOD header if first roundabout is a drive-on-left one. Note that the counters are only set when the location hook works, so precompiled bounds are needed (--bounds) Binary is here: http://files.mkgmap.org.uk/download/232/mkgmap.jar Gerd

1 0