May 2010 - mkgmap-dev - The mkgmap lists

Re: [mkgmap-dev] Bad routing error here in Rome...
by Marco Certelli 21 May '11

21 May '11

Hello. I'll re-test the situation every week. Compiled italy.osm.bz2 from download.geofabrik.de 1) latest mkgmap + latest splitter: Routing Error in Mapsource and Nuvi 255 2) mkgmap 1188 + oldest splitter (51kB): No Error in Mapsource and No error in Nuvi 255 Ciao, Marco. --- Dom 31/1/10, Marco Certelli <marco_certelli(a)yahoo.it> ha scritto: > Da: Marco Certelli <marco_certelli(a)yahoo.it> > Oggetto: Re: [mkgmap-dev] Bad routing error here in Rome... > A: "Development list for mkgmap" <mkgmap-dev(a)lists.mkgmap.org.uk> > Data: Domenica 31 gennaio 2010, 16:43 > Hi Mark. > > No way. I reduced maxnode to 500000 (Italy is splitted in > 42 tiles) > > I tested latest splitter and latest mkgmap: exactly same > error as before in mapsource routing. > > Ciao, Marco. > > > --- Sab 30/1/10, Mark Burton <markb(a)ordern.com> > ha scritto: > > > Da: Mark Burton <markb(a)ordern.com> > > Oggetto: Re: [mkgmap-dev] Bad routing error here in > Rome... > > A: mkgmap-dev(a)lists.mkgmap.org.uk > > Data: Sabato 30 gennaio 2010, 17:00 > > > > Hi Marco, > > > > > Here is the part of the cmd script doing the > actual > > job: > > > > > > java -enableassertions -Xmx1000m -jar > > ..\bin\splitter.jar --mapid=66%FID%001 > --max-nodes=1000000 > > ..\OSM-Data\%osmfile% > > > > > > java -enableassertions -Xmx1000m -jar > > ..\bin\mkgmap.jar --code-page=1252 > > --country-name="%country%" --latin1 --family-id=%FID% > > --mapname=66%FID%001 --overview-mapname=66%FID%000 > --tdbfile > > --series-name="OSM-%country%" > --family-name="OpenStreetMap: > > %country%" --road-name-pois --add-pois-to-areas > > --no-poi-address --ignore-maxspeeds > --remove-short-arcs > > --preserve-element-order > > --style-file=..\bin\resources\styles\ --style=%style% > > --description="%country%" --route --net --gmapsupp -c > > template.args > > > > OK - thanks. > > > > Have you tried using smaller tile sizes? i.e. does the > same > > problem > > exist if you use, say, 500000 for max nodes? > > > > Also, does the map show any other problems in that > area > > apart from > > routing not working? > > > > Mark > > _______________________________________________ > > mkgmap-dev mailing list > > mkgmap-dev(a)lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > > > > > >

6 15

[PATCH] Add a substring filter to the style language.
by Jeffrey C. Ollie 28 Sep '10

28 Sep '10

This can be used to extract substrings from values. If the "name" tag on an object was equal to "abcdef": '${name|substring:2}' => 'cdef' '${name|substring:2:4}' => 'cd' As an example, it can be used to clean up the "ref" element on route relations: type=route & route=road & network=US:I & ref ~ 'I\d+' { apply { set route_network='US:I'; set route_ref='${ref|substring:1}'; } } type=route & route=road & network=US:I & ref ~ 'I \d+' { apply { set route_network='US:I'; set route_ref='${ref|substring:2}'; } } type=route & route=road & network=US:I & ref ~ 'I-\d+' { apply { set route_network='US:I'; set route_ref='${ref|substring:2}'; } } type=route & route=road & network=US:I & ref ~ '\d+' { apply { set route_network='US:I'; set route_ref='${ref}'; } } --- .../mkgmap/osmstyle/actions/SubstringFilter.java | 66 ++++++++++++++++++++ .../mkgmap/osmstyle/actions/ValueBuilder.java | 2 + 2 files changed, 68 insertions(+), 0 deletions(-) create mode 100644 src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java diff --git a/src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java b/src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java new file mode 100644 index 0000000..823d402 --- /dev/null +++ b/src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java @@ -0,0 +1,66 @@ +/* + * Copyright (C) 2010 Jeffrey C. Ollie + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * + * Author: Jeffrey C. Ollie + * Create date: 08-March-2010 + */ +package uk.me.parabola.mkgmap.osmstyle.actions; + +import uk.me.parabola.mkgmap.reader.osm.Element; + +/** + * Extract a substring from a value + * + * @author Jeffrey C. Ollie + */ +public class SubstringFilter extends ValueFilter { + private int args; + private int start; + private int end; + + public SubstringFilter(String arg) { + start = 0; + end = 0; + args = 0; + + String[] temp = arg.split(":"); + + try { + if (temp.length == 1) { + start = Integer.parseInt(temp[0]); + args = 1; + } else if (temp.length == 2) { + start = Integer.parseInt(temp[0]); + end = Integer.parseInt(temp[1]); + args = 2; + } else { + start = 0; + end = 0; + args = 0; + } + } catch (NumberFormatException e) { + } + } + + protected String doFilter(String value, Element el) { + if (value == null) return null; + + if (args == 1) { + return value.substring(start); + } + if (args == 2) { + return value.substring(start, end); + } + return value; + } +} diff --git a/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java b/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java index 27b861d..1100b15 100644 --- a/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java +++ b/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java @@ -171,6 +171,8 @@ public class ValueBuilder { item.addFilter(new HeightFilter(arg)); } else if (cmd.equals("not-equal")) { item.addFilter(new NotEqualFilter(arg)); + } else if (cmd.equals("substring")) { + item.addFilter(new SubstringFilter(arg)); } } -- 1.7.0.1

3 2

[PATCH v5] - Code around highway shield crap when sorting labels
by Mark Burton 21 Jun '10

21 Jun '10

v5 - now understands the 0x1b prefix code that introduces a lower case letter (and also is used to prefix a couple of separators (0x1b and 0x1c). I thought great, now I can prefix my road names with ^\ (aka 0x1c) and they won't show up so readily when zoomed out. That worked as expected but, unfortunately, it broke the address search stuff so the bottom line is that you can't use the separators as a prefix (sob). Also, for those of you wondering why the display names and other refs are not showing up in the mapsource address search - it's because the MDR building code only reads the first label for a road and ignores any others. Shame that. I don't think there's a good reason why it couldn't read the other labels, it's just doesn't do that at the moment. BTW - the basic address search on the etrex and Nuvi still sees those alternative road labels. So, those people who are tracking this patch series, please test and if it doesn't bite your arse, I will commit it soonish -------- v4 - found the motorways (and a load of other roads too!) -------- v3 - now works harder to clean up road names for use in MDR file - not sure if this will have a beneficial effect but it could possibly fix the issue recently reported by Felix. Motorways are still not showing up. ------- v2 - remove more duplicate labels that only differ in letter case - remove leading spaces from labels even if they start with a Garmin code. Still something wrong with motorway names because on the UK map, only the M74 appears in the mapsource road names - all other motorways are missing - very odd. ------- This patch codes around the problems introduced by highway shields with regard to the sorted roads: 1 - the sort order should now be much improved 2 - no duplicate symbols (shield version + non-shield version) It also includes a fix to the label reading code so that labels with a highway shield prefix are read in correctly when generating the MDR file. For me, in mapsource, road search for roads with highway shields now works apart from motorways which don't seem to searchable - perhaps that's deliberate on Garmin's part? All feedback appreciated. Mark

9 19

avg speed on roads
by Florian Lohoff 05 Jun '10

05 Jun '10

Hi, i remember dark that the Garmin Data modell contains some classification for road speeds e.g. used for time calculation in routing. Is there any osm tag used for hinting those speeds except the highway type? The question i ask is that i am currently on la palma and i am mapping when family lets me go - i found that routing times are off by a factor or 2 or 3. Measuring the avg. speed for sections of 10-20km on primarys is something low like 35km/h on some parts and something like 55km/h on fast parts. The max speed on these sections is mostly 80km/h but in the end nobody gets that fast. The low avg speed is caused by very tight slopes the roads wind up the mountains. So is there something like "avgspeed=" which gets used? I could hint the long distance roads like primarys in the sections i measured the avg. speed. Flo -- Florian Lohoff f(a)zz.de "Es ist ein grobes Missverständnis und eine Fehlwahrnehmung, dem Staat im Internet Zensur- und Überwachungsabsichten zu unterstellen." - - Bundesminister Dr. Wolfgang Schäuble -- 10. Juli in Berlin

7 12

linesCutEachOther() always returns false
by Steve Ratcliffe 04 Jun '10

04 Jun '10

Could someone who understands these things please look at the linesCutEachOther() routine in MultiPolygonRelation.java and let me know what needs to be done to it. Currently it never returns true. ..Steve

2 1

Add link-to-tags features that behaves like the link-pois-to-ways Command for the lines style-file
by Felix Hartmann 02 Jun '10

02 Jun '10

I am coming to a point when maintaining my lines file, that adding a single key on top, means 200-300 lines more. This is becoming unmaintainable. It would be great to have the option to have rules just like the ones we have for POI that one can run on certain keys. e.g. lanes=2 & oneway=yes { add mkgmap:road-speed = '-1'; add mkgmap:road-class = '-1'; } This should then be matched to all lines that are generated after this command. As this is already possible for POI, I hope someone could without much effort implement this for rules based on tags too. This would be very useful as it saves many many lines of code. Currently if you would like to do something like this, it means that you have to add the rule to every line (with autorouting) in your lines file. This is okay for one or to tags (like some people do for maxspeed), but it becomes impossible to keep track once you have 10 tags you like to be enacted. If there are several rules matching, they should simply add up. (or equalise themselves if +1 meets -1...) It would be really great if someone could implement this feature. As it exists already for POI when using link-pois-to-ways I have the great hope that it is easy to implement and program and someone finds some spare time to do it. This could really help to avoid creating a ton of rules and open up many new possibilities to much better finetune road_class and road_speed. It would be a plus, if one could only "apply" this rule until a stop rule is given. Quick example lanes=2 & oneway=yes { add mkgmap:road-speed = '+1'; add mkgmap:road-class = '+1'; set rule=1 } highway=primary & maxspeed=100 {road_class=3 road_speed=4 0x02] highway=primary .... highway=secondary... .... rule=1 {stop execution}

2 5

Question regarding house numbers
by Daniela Duerbeck 02 Jun '10

02 Jun '10

Hi! When a house number is mapped in osm as a POI, I can see the house number in my device but when it is mapped in a polygon (e.g.with building=yes) the POI is rendered but I can see just the word "Punkt" as additional information. Should I add something in the polygons file? Thanks a lot in advance, Dani

2 5

Bug in Format6Encoder.encodeText()
by Paul Ortyl 31 May '10

31 May '10

Hi, I've got a bug to report for r1651 of mkgmap: java.lang.ArrayIndexOutOfBoundsException: 3 at uk.me.parabola.imgfmt.app.labelenc.Format6Encoder.put6(Format6Encoder.java:137) at uk.me.parabola.imgfmt.app.labelenc.Format6Encoder.encodeText(Format6Encoder.java:91) at uk.me.parabola.imgfmt.app.Label.write(Label.java:115) at uk.me.parabola.imgfmt.app.lbl.LBLFile.newLabel(LBLFile.java:125) at uk.me.parabola.mkgmap.build.MapBuilder.processPOIs(MapBuilder.java:456) at uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:191) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:96) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:61) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:189) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:186) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) comes for the following POI <node id='299073581' lat='49.7950742' lon='9.9312049'> <tag k='addr:postcode' v='97070'/> <tag k='addr:housenumber' v='½'/> <tag k='shop' v='clothes'/> <tag k='addr:street' v='Schönbornstraße'/> <tag k='addr:city' v='Würzburg'/> <tag k='name' v='Marc O´Polo'/> </node> The problem is at the unicode character '1/2' for housenumber. Thanks, Paul -- Don't take life too seriously; you will never get out of it alive. -- Elbert Hubbard

3 3

Commit: r1652: increase the minimum buffer size for a lable so
by svn commit 31 May '10

31 May '10

Version 1652 was commited by steve on 2010-05-31 23:15:17 +0100 (Mon, 31 May 2010) increase the minimum buffer size for a lable so that short labels that happen to require a number of bytes to represent them will fit.

1 0

Commit: r1651: add back routine needed for display.
by svn commit 31 May '10

31 May '10

Version 1651 was commited by steve on 2010-05-31 13:51:28 +0100 (Mon, 31 May 2010) add back routine needed for display.

3 3