April 2010 - mkgmap-dev - The mkgmap lists

Re: [mkgmap-dev] Bad routing error here in Rome...
by Marco Certelli 21 May '11

21 May '11

Hello. I'll re-test the situation every week. Compiled italy.osm.bz2 from download.geofabrik.de 1) latest mkgmap + latest splitter: Routing Error in Mapsource and Nuvi 255 2) mkgmap 1188 + oldest splitter (51kB): No Error in Mapsource and No error in Nuvi 255 Ciao, Marco. --- Dom 31/1/10, Marco Certelli <marco_certelli(a)yahoo.it> ha scritto: > Da: Marco Certelli <marco_certelli(a)yahoo.it> > Oggetto: Re: [mkgmap-dev] Bad routing error here in Rome... > A: "Development list for mkgmap" <mkgmap-dev(a)lists.mkgmap.org.uk> > Data: Domenica 31 gennaio 2010, 16:43 > Hi Mark. > > No way. I reduced maxnode to 500000 (Italy is splitted in > 42 tiles) > > I tested latest splitter and latest mkgmap: exactly same > error as before in mapsource routing. > > Ciao, Marco. > > > --- Sab 30/1/10, Mark Burton <markb(a)ordern.com> > ha scritto: > > > Da: Mark Burton <markb(a)ordern.com> > > Oggetto: Re: [mkgmap-dev] Bad routing error here in > Rome... > > A: mkgmap-dev(a)lists.mkgmap.org.uk > > Data: Sabato 30 gennaio 2010, 17:00 > > > > Hi Marco, > > > > > Here is the part of the cmd script doing the > actual > > job: > > > > > > java -enableassertions -Xmx1000m -jar > > ..\bin\splitter.jar --mapid=66%FID%001 > --max-nodes=1000000 > > ..\OSM-Data\%osmfile% > > > > > > java -enableassertions -Xmx1000m -jar > > ..\bin\mkgmap.jar --code-page=1252 > > --country-name="%country%" --latin1 --family-id=%FID% > > --mapname=66%FID%001 --overview-mapname=66%FID%000 > --tdbfile > > --series-name="OSM-%country%" > --family-name="OpenStreetMap: > > %country%" --road-name-pois --add-pois-to-areas > > --no-poi-address --ignore-maxspeeds > --remove-short-arcs > > --preserve-element-order > > --style-file=..\bin\resources\styles\ --style=%style% > > --description="%country%" --route --net --gmapsupp -c > > template.args > > > > OK - thanks. > > > > Have you tried using smaller tile sizes? i.e. does the > same > > problem > > exist if you use, say, 500000 for max nodes? > > > > Also, does the map show any other problems in that > area > > apart from > > routing not working? > > > > Mark > > _______________________________________________ > > mkgmap-dev mailing list > > mkgmap-dev(a)lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > > > > > >

6 15

[PATCH] Add a substring filter to the style language.
by Jeffrey C. Ollie 28 Sep '10

28 Sep '10

This can be used to extract substrings from values. If the "name" tag on an object was equal to "abcdef": '${name|substring:2}' => 'cdef' '${name|substring:2:4}' => 'cd' As an example, it can be used to clean up the "ref" element on route relations: type=route & route=road & network=US:I & ref ~ 'I\d+' { apply { set route_network='US:I'; set route_ref='${ref|substring:1}'; } } type=route & route=road & network=US:I & ref ~ 'I \d+' { apply { set route_network='US:I'; set route_ref='${ref|substring:2}'; } } type=route & route=road & network=US:I & ref ~ 'I-\d+' { apply { set route_network='US:I'; set route_ref='${ref|substring:2}'; } } type=route & route=road & network=US:I & ref ~ '\d+' { apply { set route_network='US:I'; set route_ref='${ref}'; } } --- .../mkgmap/osmstyle/actions/SubstringFilter.java | 66 ++++++++++++++++++++ .../mkgmap/osmstyle/actions/ValueBuilder.java | 2 + 2 files changed, 68 insertions(+), 0 deletions(-) create mode 100644 src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java diff --git a/src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java b/src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java new file mode 100644 index 0000000..823d402 --- /dev/null +++ b/src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java @@ -0,0 +1,66 @@ +/* + * Copyright (C) 2010 Jeffrey C. Ollie + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * + * Author: Jeffrey C. Ollie + * Create date: 08-March-2010 + */ +package uk.me.parabola.mkgmap.osmstyle.actions; + +import uk.me.parabola.mkgmap.reader.osm.Element; + +/** + * Extract a substring from a value + * + * @author Jeffrey C. Ollie + */ +public class SubstringFilter extends ValueFilter { + private int args; + private int start; + private int end; + + public SubstringFilter(String arg) { + start = 0; + end = 0; + args = 0; + + String[] temp = arg.split(":"); + + try { + if (temp.length == 1) { + start = Integer.parseInt(temp[0]); + args = 1; + } else if (temp.length == 2) { + start = Integer.parseInt(temp[0]); + end = Integer.parseInt(temp[1]); + args = 2; + } else { + start = 0; + end = 0; + args = 0; + } + } catch (NumberFormatException e) { + } + } + + protected String doFilter(String value, Element el) { + if (value == null) return null; + + if (args == 1) { + return value.substring(start); + } + if (args == 2) { + return value.substring(start, end); + } + return value; + } +} diff --git a/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java b/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java index 27b861d..1100b15 100644 --- a/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java +++ b/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java @@ -171,6 +171,8 @@ public class ValueBuilder { item.addFilter(new HeightFilter(arg)); } else if (cmd.equals("not-equal")) { item.addFilter(new NotEqualFilter(arg)); + } else if (cmd.equals("substring")) { + item.addFilter(new SubstringFilter(arg)); } } -- 1.7.0.1

3 2

[PATCH v5] - Code around highway shield crap when sorting labels
by Mark Burton 21 Jun '10

21 Jun '10

v5 - now understands the 0x1b prefix code that introduces a lower case letter (and also is used to prefix a couple of separators (0x1b and 0x1c). I thought great, now I can prefix my road names with ^\ (aka 0x1c) and they won't show up so readily when zoomed out. That worked as expected but, unfortunately, it broke the address search stuff so the bottom line is that you can't use the separators as a prefix (sob). Also, for those of you wondering why the display names and other refs are not showing up in the mapsource address search - it's because the MDR building code only reads the first label for a road and ignores any others. Shame that. I don't think there's a good reason why it couldn't read the other labels, it's just doesn't do that at the moment. BTW - the basic address search on the etrex and Nuvi still sees those alternative road labels. So, those people who are tracking this patch series, please test and if it doesn't bite your arse, I will commit it soonish -------- v4 - found the motorways (and a load of other roads too!) -------- v3 - now works harder to clean up road names for use in MDR file - not sure if this will have a beneficial effect but it could possibly fix the issue recently reported by Felix. Motorways are still not showing up. ------- v2 - remove more duplicate labels that only differ in letter case - remove leading spaces from labels even if they start with a Garmin code. Still something wrong with motorway names because on the UK map, only the M74 appears in the mapsource road names - all other motorways are missing - very odd. ------- This patch codes around the problems introduced by highway shields with regard to the sorted roads: 1 - the sort order should now be much improved 2 - no duplicate symbols (shield version + non-shield version) It also includes a fix to the label reading code so that labels with a highway shield prefix are read in correctly when generating the MDR file. For me, in mapsource, road search for roads with highway shields now works apart from motorways which don't seem to searchable - perhaps that's deliberate on Garmin's part? All feedback appreciated. Mark

9 19

avg speed on roads
by Florian Lohoff 05 Jun '10

05 Jun '10

Hi, i remember dark that the Garmin Data modell contains some classification for road speeds e.g. used for time calculation in routing. Is there any osm tag used for hinting those speeds except the highway type? The question i ask is that i am currently on la palma and i am mapping when family lets me go - i found that routing times are off by a factor or 2 or 3. Measuring the avg. speed for sections of 10-20km on primarys is something low like 35km/h on some parts and something like 55km/h on fast parts. The max speed on these sections is mostly 80km/h but in the end nobody gets that fast. The low avg speed is caused by very tight slopes the roads wind up the mountains. So is there something like "avgspeed=" which gets used? I could hint the long distance roads like primarys in the sections i measured the avg. speed. Flo -- Florian Lohoff f(a)zz.de "Es ist ein grobes Missverständnis und eine Fehlwahrnehmung, dem Staat im Internet Zensur- und Überwachungsabsichten zu unterstellen." - - Bundesminister Dr. Wolfgang Schäuble -- 10. Juli in Berlin

7 12

Question regarding house numbers
by Daniela Duerbeck 02 Jun '10

02 Jun '10

Hi! When a house number is mapped in osm as a POI, I can see the house number in my device but when it is mapped in a polygon (e.g.with building=yes) the POI is rendered but I can see just the word "Punkt" as additional information. Should I add something in the polygons file? Thanks a lot in advance, Dani

2 5

Re: [mkgmap-dev] [PATCH] Routable pedestrian areas
by Minko 20 May '10

20 May '10

Well, I compiled the map with version 1620, and on my map the outlines of those pedestrian areas are rendered as footway, and are routable (dotted lines). The polygon is rendered grey. See a screenshot of my map at http://img249.imageshack.us/img249/993/dam.jpg The osm data of this square: http://www.openstreetmap.org/browse/way/34132635 IF those are connected to other roads, you can make a good routing already without a patch. In my style file the continue statement makes sure the pedestrian roads are rendered (as footway) as well as the area. Minko Marko Mäkelä wrote An educated guess: you cannot translate the same way to both a polygon (area) and a line, or can you now that the style branch has been merged to trunk? I would prefer to see this in the style file. The fewer hard-coded tweaks in the mkgmap core, the better. Is there now a way to implement the oneway-cycleway duplication in the style file? If there is, could the current code be removed from the core?

8 9

Suggested improvements to naming in default style
by Charlie Ferrero 05 May '10

05 May '10

Hi Marko or others, I have some suggestions for the default style which I think improve the naming of various sports-related things, of hotels, and of tourist information POIs: [Polygons style file] leisure=stadium {name '${name} (${sport})' | '${name}' } [0x19 resolution 19] leisure=track {name '${name} (${sport})' | '${name}' } [0x19 resolution 18] leisure=pitch {name '${name} (${sport})' | '${name}' | '${sport}' } [0x19 resolution 20] leisure=sports_center | leisure=sports_centre {name '${name} (${sport})' | '${name}' } [0x19 resolution 20] [Points style file] leisure=stadium {name '${name} (${sport})' | '${name}' } [0x2c08 resolution 21] leisure=track {name '${name} (${sport})' | '${name}' } [0x2c08 resolution 21] leisure=pitch {name '${name} (${sport})' | '${name}' | '${sport}' } [0x2c08 resolution 21] leisure=sports_center | leisure=sports_centre {name '${name} (${sport})' | '${name}' } [0x2d0a resolution 20] tourism=hotel | tourism=motel { name '${name} (${operator}) (${stars}*)' | '${name} (${stars}*)' | '${operator} (${stars}*)' | '${name}' } [0x2b01 resolution 20] tourism=information {name '${name} - ${description} (${operator})'| '${name} - (${description})' | '${name}' | '${description}' | '${operator}' | '${ref}'} [0x2f0c resolution 20] tourism=viewpoint {name '${name} - ${description}' | '${name}'} [0x2c04 resolution 20] Would it also make sense to harmonise resolution levels between the points and polygons style files (i.e. leisure=stadium should have the same resolution in both points and polygons files)? Or are they deliberately set at different resolutions? -- Charlie

3 2

Buildings color
by Prescott 03 May '10

03 May '10

Hello! It's able to change color of buildings in default style to more shiny? Because there are buildings on the map but it's hard to recognize it because the color of buildings is about same like the background :-( ...I hope that you will catch that i wannt to say because my english it's not perfect :-) -- View this message in context: http://gis.638310.n2.nabble.com/Buildings-color-tp4962195p4962195.html Sent from the Mkgmap Development mailing list archive at Nabble.com.

5 20

Change mkgmap default options to make mkgmap more userfriendly
by Felix Hartmann 03 May '10

03 May '10

For most people understanding which mkgmap options they should choose, is not easy - as one first needs to have quite thorough understanding. I think in general useful options should be the default - and not stick for ages to old behavior. I'm afraid I make to many mistakes if I change it myself, but I would propose the following default option changes: *changes that only need a default change because one can disable them by setting the value to 0* --reduce-point-density=5.4 --remove-short-arcs=2.8 --location-autofill=1 *option needs to able to be switched off* --generate-sea=extend-sea-sectors,close-gaps=6000 (including this by default, may keep people more aware of coastline nondestruction) *options that would need to be reversed* --supress-dead-end-nodes --adjust-turn-headings --add-pois-to-areas (this seems to be the default behaviour of most renderers now) --ignore-maxspeeds (the current handling sucks, If we would change this to become default, I would be willing to rework the default style to make use of sensible maxspeeds) --route (the default style is routable, hence the default map should be routable too)

5 6

Handling of boundary multipolygons
by WanMil 02 May '10

02 May '10

I am thinking about how to handle boundary multipolygons and want get some feedback and ideas from you. There are two possible ways to use boundary information: 1. Draw the boundaries as lines 2. Draw the boundaries as polygons with different colours for different administrative levels I think the 2nd option cannot be realized (at the moment). I see no way how to define a style that differently colours adjoining polygons with rather identical tags (e.g. boundary=adminstrative, admin_level=2). So let's concentrate on the 1st option. One way may be part of different boundary relations. (admin_level=2 && admin_level=3 && admin_level=4 ....). To be able to process all of them with the style system the way must be duplicated for each relation. The multipolygon handling of boundaries might work as follows: For all ways (role=outer and inner) part of the boundary relation - Clone the original way - Tag the cloned way with the boundary information of the mp - Remove all tags from the original way that are also contained in the mp (with the same value) - Split all closed ways (polygons) in two ways to ensure that only ways are tagged with the boundary information What do you think? If no one really complains I will start implementing this (and expect that it will be accepted when I am ready :-). In case other multipolygon type also require such a processing we might add a config file in future which types are handled in this way. So this is ready to be more generic. WanMil

2 10