March 2010 - mkgmap-dev - The mkgmap lists

Re: [mkgmap-dev] Bad routing error here in Rome...
by Marco Certelli 21 May '11

21 May '11

Hello. I'll re-test the situation every week. Compiled italy.osm.bz2 from download.geofabrik.de 1) latest mkgmap + latest splitter: Routing Error in Mapsource and Nuvi 255 2) mkgmap 1188 + oldest splitter (51kB): No Error in Mapsource and No error in Nuvi 255 Ciao, Marco. --- Dom 31/1/10, Marco Certelli <marco_certelli(a)yahoo.it> ha scritto: > Da: Marco Certelli <marco_certelli(a)yahoo.it> > Oggetto: Re: [mkgmap-dev] Bad routing error here in Rome... > A: "Development list for mkgmap" <mkgmap-dev(a)lists.mkgmap.org.uk> > Data: Domenica 31 gennaio 2010, 16:43 > Hi Mark. > > No way. I reduced maxnode to 500000 (Italy is splitted in > 42 tiles) > > I tested latest splitter and latest mkgmap: exactly same > error as before in mapsource routing. > > Ciao, Marco. > > > --- Sab 30/1/10, Mark Burton <markb(a)ordern.com> > ha scritto: > > > Da: Mark Burton <markb(a)ordern.com> > > Oggetto: Re: [mkgmap-dev] Bad routing error here in > Rome... > > A: mkgmap-dev(a)lists.mkgmap.org.uk > > Data: Sabato 30 gennaio 2010, 17:00 > > > > Hi Marco, > > > > > Here is the part of the cmd script doing the > actual > > job: > > > > > > java -enableassertions -Xmx1000m -jar > > ..\bin\splitter.jar --mapid=66%FID%001 > --max-nodes=1000000 > > ..\OSM-Data\%osmfile% > > > > > > java -enableassertions -Xmx1000m -jar > > ..\bin\mkgmap.jar --code-page=1252 > > --country-name="%country%" --latin1 --family-id=%FID% > > --mapname=66%FID%001 --overview-mapname=66%FID%000 > --tdbfile > > --series-name="OSM-%country%" > --family-name="OpenStreetMap: > > %country%" --road-name-pois --add-pois-to-areas > > --no-poi-address --ignore-maxspeeds > --remove-short-arcs > > --preserve-element-order > > --style-file=..\bin\resources\styles\ --style=%style% > > --description="%country%" --route --net --gmapsupp -c > > template.args > > > > OK - thanks. > > > > Have you tried using smaller tile sizes? i.e. does the > same > > problem > > exist if you use, say, 500000 for max nodes? > > > > Also, does the map show any other problems in that > area > > apart from > > routing not working? > > > > Mark > > _______________________________________________ > > mkgmap-dev mailing list > > mkgmap-dev(a)lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > > > > > >

6 15

[PATCH] Add a substring filter to the style language.
by Jeffrey C. Ollie 28 Sep '10

28 Sep '10

This can be used to extract substrings from values. If the "name" tag on an object was equal to "abcdef": '${name|substring:2}' => 'cdef' '${name|substring:2:4}' => 'cd' As an example, it can be used to clean up the "ref" element on route relations: type=route & route=road & network=US:I & ref ~ 'I\d+' { apply { set route_network='US:I'; set route_ref='${ref|substring:1}'; } } type=route & route=road & network=US:I & ref ~ 'I \d+' { apply { set route_network='US:I'; set route_ref='${ref|substring:2}'; } } type=route & route=road & network=US:I & ref ~ 'I-\d+' { apply { set route_network='US:I'; set route_ref='${ref|substring:2}'; } } type=route & route=road & network=US:I & ref ~ '\d+' { apply { set route_network='US:I'; set route_ref='${ref}'; } } --- .../mkgmap/osmstyle/actions/SubstringFilter.java | 66 ++++++++++++++++++++ .../mkgmap/osmstyle/actions/ValueBuilder.java | 2 + 2 files changed, 68 insertions(+), 0 deletions(-) create mode 100644 src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java diff --git a/src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java b/src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java new file mode 100644 index 0000000..823d402 --- /dev/null +++ b/src/uk/me/parabola/mkgmap/osmstyle/actions/SubstringFilter.java @@ -0,0 +1,66 @@ +/* + * Copyright (C) 2010 Jeffrey C. Ollie + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * + * Author: Jeffrey C. Ollie + * Create date: 08-March-2010 + */ +package uk.me.parabola.mkgmap.osmstyle.actions; + +import uk.me.parabola.mkgmap.reader.osm.Element; + +/** + * Extract a substring from a value + * + * @author Jeffrey C. Ollie + */ +public class SubstringFilter extends ValueFilter { + private int args; + private int start; + private int end; + + public SubstringFilter(String arg) { + start = 0; + end = 0; + args = 0; + + String[] temp = arg.split(":"); + + try { + if (temp.length == 1) { + start = Integer.parseInt(temp[0]); + args = 1; + } else if (temp.length == 2) { + start = Integer.parseInt(temp[0]); + end = Integer.parseInt(temp[1]); + args = 2; + } else { + start = 0; + end = 0; + args = 0; + } + } catch (NumberFormatException e) { + } + } + + protected String doFilter(String value, Element el) { + if (value == null) return null; + + if (args == 1) { + return value.substring(start); + } + if (args == 2) { + return value.substring(start, end); + } + return value; + } +} diff --git a/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java b/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java index 27b861d..1100b15 100644 --- a/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java +++ b/src/uk/me/parabola/mkgmap/osmstyle/actions/ValueBuilder.java @@ -171,6 +171,8 @@ public class ValueBuilder { item.addFilter(new HeightFilter(arg)); } else if (cmd.equals("not-equal")) { item.addFilter(new NotEqualFilter(arg)); + } else if (cmd.equals("substring")) { + item.addFilter(new SubstringFilter(arg)); } } -- 1.7.0.1

3 2

[PATCH v5] - Code around highway shield crap when sorting labels
by Mark Burton 21 Jun '10

21 Jun '10

v5 - now understands the 0x1b prefix code that introduces a lower case letter (and also is used to prefix a couple of separators (0x1b and 0x1c). I thought great, now I can prefix my road names with ^\ (aka 0x1c) and they won't show up so readily when zoomed out. That worked as expected but, unfortunately, it broke the address search stuff so the bottom line is that you can't use the separators as a prefix (sob). Also, for those of you wondering why the display names and other refs are not showing up in the mapsource address search - it's because the MDR building code only reads the first label for a road and ignores any others. Shame that. I don't think there's a good reason why it couldn't read the other labels, it's just doesn't do that at the moment. BTW - the basic address search on the etrex and Nuvi still sees those alternative road labels. So, those people who are tracking this patch series, please test and if it doesn't bite your arse, I will commit it soonish -------- v4 - found the motorways (and a load of other roads too!) -------- v3 - now works harder to clean up road names for use in MDR file - not sure if this will have a beneficial effect but it could possibly fix the issue recently reported by Felix. Motorways are still not showing up. ------- v2 - remove more duplicate labels that only differ in letter case - remove leading spaces from labels even if they start with a Garmin code. Still something wrong with motorway names because on the UK map, only the M74 appears in the mapsource road names - all other motorways are missing - very odd. ------- This patch codes around the problems introduced by highway shields with regard to the sorted roads: 1 - the sort order should now be much improved 2 - no duplicate symbols (shield version + non-shield version) It also includes a fix to the label reading code so that labels with a highway shield prefix are read in correctly when generating the MDR file. For me, in mapsource, road search for roads with highway shields now works apart from motorways which don't seem to searchable - perhaps that's deliberate on Garmin's part? All feedback appreciated. Mark

9 19

a FIXME map style
by maning sambale 18 Apr '10

18 Apr '10

Hi, Just got this idea of creating Garmin maps designed for fixing the data (I use Garmin primarily to collect and fix OSM). Some have started doing this like the nonames style and the All in One Garmin (http://wiki.openstreetmap.org/wiki/DE:All_in_one_Garmin_Map#Openstreetbugs) but I hope to expand the style to include all the QA tools available in OSM. Some data/style we can integrate are: * No name roads (use the noname style) * Openstreetbug reports * Keep Right reports * POI with names but no other tags Anyone doing a similar map? Maybe you can share some tools. -- cheers, maning ------------------------------------------------------ "Freedom is still the most radical idea of all" -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ ------------------------------------------------------

8 21

[PATCH v1] Do not process boundary relations
by WanMil 15 Apr '10

15 Apr '10

At the moment processing of multipolygon boundary relations creates a lot of unwanted effects (artificial boundaries on tile bounds, lots of warnings etc.). The patch excludes the boundary relations from the multipolygon processing. This can be changed with the new option --process-boundary-relations. An additional spin-off is the improved performance and less warnings. WanMil

3 5

Highway name or ref
by Lambertus 07 Apr '10

07 Apr '10

There's a question on the OSM forum about the naming of highways in the default stylesheet which comes down to this: if a ref is available then that seems always used even if a name is also available, can this be changed to show the name as well? http://forum.openstreetmap.org/viewtopic.php?pid=68439#p68439

5 8

Tile boundary artefacts
by WanMil 06 Apr '10

06 Apr '10

I have attached an interesting screenshot from my Oregon 400t. The map is the All in one map Europe (http://wiki.openstreetmap.org/wiki/All_in_one_Garmin_Map) You see that the light grey industrial area is splitted by a considerable yellow line. But the dark grey buildings do not have it although they are splitted by the tile bounds in the same manner. There is no multipolygon defined in the screenshots area. Maybe the boundary clipper sometimes cuts too much? I have never seen such artefacts on original garmin maps. WanMil

2 4

Question to --add-pois-to-areas
by Daniela Duerbeck 06 Apr '10

06 Apr '10

Hi! How should --add-pois-to-areas work? Here is a Zoo:http://www.openstreetmap.org/?lat=28.40885&lon=-16.56398&zoom=17&layers… but it has got neighter icon nor can it be found in the POI search. How is this option expected to work? TIA, Dani P.S: This part is very small so maps are generated very fast: http://download.geofabrik.de/osm/africa/canary_islands.osm.bz2

4 11

Distance Icon - Text
by Daniela Duerbeck 06 Apr '10

06 Apr '10

Hi! I think that the distance between icon and corresponding text is a bit too large, see http://www.deltadelta.de/nmz/sc18.png Can I decrease it? Thanks a lot in advance, Dani

3 3

Commit: r1625: Translate amenity=zoo at resolution 20 like tourism=zoo,
by svn commit 05 Apr '10

05 Apr '10

Version 1625 was commited by marko on 2010-03-29 09:16:46 +0100 (Mon, 29 Mar 2010) Translate amenity=zoo at resolution 20 like tourism=zoo, and note that amenity=supermarket and amenity=zoo are deprecated.

6 9