March 2009 - mkgmap-dev - The mkgmap lists

Exits warnings 3
by Carlos Dávila 21 Mar '09

21 Mar '09

After support for exits was committed to trunk, no more warnings appear while generating maps, and I'm afraid all previous errors have not been magically fixed ;-) . Where have they gone? Cheers Carlos

3 3

[PATCH] Area POI patch
by Bernhard Heibler 21 Mar '09

21 Mar '09

Hi, until now the --add-pois-to-areas function only checked area types that are listed in the polygon style file. This patch for the latest trunk R974 removes this restriction. Patch also include the address support for area pois. Please let me know if this one is useful... Thanks Berni. Index: mkgmap/src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java =================================================================== --- mkgmap/src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java (.../upstream) (revision 317) +++ mkgmap/src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java (.../work_areapoi) (revision 317) @@ -89,7 +89,8 @@ private final Rule nodeRules; private final Rule relationRules; - + private boolean add_pois_to_areas = false; + class AccessMapping { private final String type; private final int index; @@ -134,7 +135,12 @@ if (overlayAdder != null) lineAdder = overlayAdder; } - + + public void enableAreasPois(boolean enable) + { + add_pois_to_areas = enable; + } + /** * This takes the way and works out what kind of map feature it is and makes * the relevant call to the mapper callback. @@ -151,19 +157,46 @@ preConvertRules(way); GType foundType = wayRules.resolveType(way); - if (foundType == null) - return; + + MapShape shape = null; + + if (foundType != null) + { + postConvertRules(way, foundType); - postConvertRules(way, foundType); + if (foundType.getFeatureKind() == GType.POLYLINE) { + if(foundType.isRoad()) + addRoad(way, foundType); + else + addLine(way, foundType); + } + else + shape = addShape(way, foundType); + } - if (foundType.getFeatureKind() == GType.POLYLINE) { - if(foundType.isRoad()) - addRoad(way, foundType); - else - addLine(way, foundType); + // Now check for area poi stuff + + if(add_pois_to_areas) + { + GType pointType = nodeRules.resolveType(way); + + if(pointType != null) + { + if(shape == null) // Check if a shape was created for this poi + { + // If not create a dummy shape with type 0 + shape = new MapShape(); + postConvertRules(way, pointType); + elementSetup(shape, pointType, way); + shape.setType(0); + shape.setPoints(way.getPoints()); + clipper.clipShape(shape, collector); + shape.setPoiType(pointType.getType()); + // We will later remove this dummy shapes while we build up the area pois + } + shape.setPoiType(pointType.getType()); + } } - else - addShape(way, foundType); } /** @@ -271,17 +304,12 @@ clipper.clipLine(line, lineAdder); } - private void addShape(Way way, GType gt) { + private MapShape addShape(Way way, GType gt) { MapShape shape = new MapShape(); elementSetup(shape, gt, way); shape.setPoints(way.getPoints()); - - clipper.clipShape(shape, collector); - - GType pointType = nodeRules.resolveType(way); - - if(pointType != null) - shape.setPoiType(pointType.getType()); + clipper.clipShape(shape, collector); + return shape; } private void addPoint(Node node, GType gt) { Index: mkgmap/src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java =================================================================== --- mkgmap/src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java (.../upstream) (revision 317) +++ mkgmap/src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java (.../work_areapoi) (revision 317) @@ -78,6 +78,7 @@ private final boolean ignoreBounds; private final boolean ignoreTurnRestrictions; private final boolean routing; + private final boolean add_pois_to_areas; private final String frigRoundabouts; public Osm5XmlHandler(EnhancedProperties props) { @@ -94,6 +95,7 @@ wayMap = new HashMap<Long, Way>(5000); relationMap = new HashMap<Long, Relation>(); } + add_pois_to_areas = props.getProperty("add-pois-to-areas",false); } /** @@ -322,6 +324,9 @@ */ public void endDocument() throws SAXException { coordMap = null; + + converter.enableAreasPois(add_pois_to_areas); + for (Relation r : relationMap.values()) converter.convertRelation(r); Index: mkgmap/src/uk/me/parabola/mkgmap/reader/osm/OsmConverter.java =================================================================== --- mkgmap/src/uk/me/parabola/mkgmap/reader/osm/OsmConverter.java (.../upstream) (revision 317) +++ mkgmap/src/uk/me/parabola/mkgmap/reader/osm/OsmConverter.java (.../work_areapoi) (revision 317) @@ -67,5 +67,7 @@ * @param bbox The bounding area. */ public void setBoundingBox(Area bbox); + + public void enableAreasPois(boolean enable); } Index: mkgmap/src/uk/me/parabola/mkgmap/main/MapMaker.java =================================================================== --- mkgmap/src/uk/me/parabola/mkgmap/main/MapMaker.java (.../upstream) (revision 317) +++ mkgmap/src/uk/me/parabola/mkgmap/main/MapMaker.java (.../work_areapoi) (revision 317) @@ -22,6 +22,7 @@ import java.util.HashSet; import java.util.List; import java.util.Set; +import java.util.Vector; import uk.me.parabola.imgfmt.ExitException; import uk.me.parabola.imgfmt.FileExistsException; @@ -150,6 +151,8 @@ poiMap.put(null, point); } + List<MapShape> shapeToRemove = new Vector<MapShape>(); + for (MapShape shape : src.getShapes()) { String shapeName = shape.getName(); @@ -158,8 +161,10 @@ // only make a point if the shape has a name and we know what type of point to make if (pointType == 0) continue; - + if(shape.getType() == 0) + shapeToRemove.add(shape); + // We don't want to add unnamed cities !! if(MapPoint.isCityType(pointType) && shapeName == null) continue; @@ -170,12 +175,18 @@ { MapPoint newPoint = new MapPoint(); newPoint.setName(shapeName); + newPoint.copyAddress(shape); newPoint.setType(pointType); newPoint.setLocation(shape.getLocation()); // TODO use centriod src.getPoints().add(newPoint); log.info("created POI ", shapeName, "from shape"); } } + + for (MapShape shape : shapeToRemove) + { + src.getShapes().remove(shape); + } } } Index: mkgmap/src/uk/me/parabola/mkgmap/general/MapElement.java =================================================================== --- mkgmap/src/uk/me/parabola/mkgmap/general/MapElement.java (.../upstream) (revision 317) +++ mkgmap/src/uk/me/parabola/mkgmap/general/MapElement.java (.../work_areapoi) (revision 317) @@ -57,7 +57,7 @@ * @return the copy; */ public abstract MapElement copy(); - + public String getName() { return name; } @@ -67,6 +67,15 @@ this.name = name.toUpperCase(); } + public void copyAddress(MapElement orig) + { + zipCode = orig.zipCode; + city = orig.city; + region = orig.region; + country = orig.country; + attributes.putAll(orig.attributes); + } + public String getCity() { return city; }

2 1

mkgmaps locks up on "self-referencing" style file entries (SVN985)
by Thilo Hannemann 20 Mar '09

20 Mar '09

When adding the line foot=no { add foot=no } to the top of the default lines style file, mkgmap svn revision 985 locks up (100% processor, does not finish), seemingly not depending on the data processed. For reference: it locks up with the data received from curl -L "http://www.informationfreeway.org/api/0.5/map?bbox=11.0338,49.6932,11.0827,… " -o data.osm But any data I use locks it. Some experiments show that this breaks in revision 951. Rev. 950 works, rev. 951 does not work. Why would anybody want to use such an entry? I discovered this bug while using the entry maxspeed=* { set maxspeed=no; } to get rid of any maxspeed setting for routing experiments. Another command "remove" besides "add" and "set" would be useful for that purpose, but those "self-referencing" entries should not lock mkgmap anyway. Best regards Thilo

1 0

[PATCH v7] - alpha patch to support road find by name
by Mark Burton 20 Mar '09

20 Mar '09

v7 - now supports zip records for roads (data comes from addr:postcode tag). Also supports multiple ref names separated by ";" (e.g. ref="A123;B999") extra spaces should not matter. It still works for non-multiple ref names but I haven't actually tested it with multiple ref names (lack of suitable OSM data), feedback would be appreciated. ----------- Hi, The attached patch is for the current SVN trunk and it generates the sorted road data that is required by the gps to find roads/intersections by name. As for the number field, I haven't thought yet how that would get its data. Please test this patch and report success/failure. If it doesn't break anything for anyone, I would like to commit it fairly soon as I think that quite a few people will be happy to have street finding added to the trunk. Cheers, Mark

5 13

Commit: r985: default style: copy access rules for highway=pedestrian from highway=footway
by svn commit 20 Mar '09

20 Mar '09

Version 985 was commited by robert on 2009-03-20 10:29:41 +0000 (Fri, 20 Mar 2009) default style: copy access rules for highway=pedestrian from highway=footway

1 0

[PATCH] Nicer messages for Splitter
by Andre Hinrichs 20 Mar '09

20 Mar '09

Hi List! I'm new to the splitter software and just checked it out from SVN. First I recognized that the doc directory is missing ('ant dist' complains about this). Simply creating the doc directory solves it. It should probably be added to the repository. Then I saw some ugly messages 'Crosses too many areas node1234567890'. The attached patch changes these messages to "Node 1234567890 crosses too many areas." Hope you like it... Thanks anyway for this good pice of software! Regards Andre

1 0

Exits warnings 2
by Carlos Dávila 19 Mar '09

19 Mar '09

While generating a map I get the following error: GRAVE (StyledConverter): Motorway exit E.S. Vía de la Plata (OSM id 361586448) located at 39,88299/-6,27618 has no motorway! (either make the exit share a node with the motorway or specify the motorway ref with a exit:road_ref tag) But mentioned node is not a motorway exit but a highway=services. Is that behaviour expected? Cheers Carlos

4 3

Multipolygons in Tile splitter
by liosha 19 Mar '09

19 Mar '09

Hi! Seems that Tile splitter loses multipolygons. I've splitted osm-cut of Russia from Cloudmade with splitter r26 and there are no multipolygon relations in result .osm files. -- liosha mailto:xliosha@gmail.com

3 2

disabling / removing the basemap on Garmin Etrex Vista
by Ben Konrath 18 Mar '09

18 Mar '09

Hi, I'm just wondering if it's possible to disable or remove the basemap on the Garmin Etrex Vista? I'm seeing Exits from the US while I'm in Costa Rica. I guess this is the same problem that Mark is having. Thanks, Ben

3 4

[patch] some tweaks to the default style
by Ben Konrath 18 Mar '09

18 Mar '09

Hi, Please find a patch that tweaks a few settings in the default style. The patch adds the following: * accepts leisure=sports_center or leisure=sports_centre This isn't consistent in the default style so it's probably not consistent in the OSM data. * add name / operator magic for banks, hotels and gas stations Comments are welcome. Cheers, Ben Index: /home/ben/workspace/mkgmap2/resources/styles/default/polygons =================================================================== --- /home/ben/workspace/mkgmap2/resources/styles/default/polygons (revision 984) +++ /home/ben/workspace/mkgmap2/resources/styles/default/polygons (working copy) @@ -39,7 +39,7 @@ leisure=park [0x17 resolution 20] leisure=pitch [0x19 resolution 20] leisure=playground [0x17 resolution 20] -leisure=sports_center [0x19 resolution 20] +leisure=sports_center | leisure=sports_centre [0x19 resolution 20] leisure=stadium [0x19 resolution 19] leisure=track [0x19 resolution 18] leisure=water_park [0x09 resolution 18] Index: /home/ben/workspace/mkgmap2/resources/styles/default/points =================================================================== --- /home/ben/workspace/mkgmap2/resources/styles/default/points (revision 984) +++ /home/ben/workspace/mkgmap2/resources/styles/default/points (working copy) @@ -4,6 +4,7 @@ aeroway=terminal [0x2f04 resolution 20] amenity=atm [0x2f06 resolution 21] +amenity=bank { name '${name} (${operator})' | '${name}' | '${operator}' } amenity=bank [0x2f06 resolution 21] amenity=biergarten [0x2d02 resolution 21] amenity=bus_station [0x2f08 resolution 21] @@ -20,6 +21,7 @@ amenity=drinking_water [0x5000 resolution 23] amenity=fast_food [0x2a07 resolution 21] amenity=fire_station [0x3008 resolution 21] +amenity=fuel { name '${name} (${operator})' | '${name}' | '${operator}' } amenity=fuel & shop=convenience [ 0x2e06 resolution 19 ] amenity=fuel [0x2f01 resolution 19] amenity=grave_yard [0x6403 resolution 21] @@ -59,7 +61,7 @@ leisure=marina [0x4300 resolution 21] leisure=park [0x2c06 resolution 21] leisure=pitch [0x2c08 resolution 21] -leisure=sports_centre [0x2d0a resolution 21] +leisure=sports_center | leisure=sports_centre [0x2d0a resolution 21] leisure=stadium [0x2c08 resolution 21] leisure=track [0x2c08 resolution 21] @@ -119,6 +121,7 @@ tourism=camp_site [0x2b03 resolution 20] tourism=caravan_site [0x2b03 resolution 20] tourism=hostel [0x2b02 resolution 20] +tourism=hotel { name '${name} ${operator}' | '${name}' | '${operator}' } tourism=hotel [0x2b01 resolution 20] tourism=information [0x4c00 resolution 20] tourism=motel [0x2b01 resolution 20]

1 0